From: Jakub Kicinski <kuba@kernel.org>
To: Justin Chen <justin.chen@broadcom.com>
Cc: Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
pabeni@redhat.com, edumazet@google.com, davem@davemloft.net,
andrew+netdev@lunn.ch, florian.fainelli@broadcom.com
Subject: Re: [PATCH net] net: bcmasp: fix double frees during remove
Date: Sat, 14 Mar 2026 08:45:10 -0700 [thread overview]
Message-ID: <20260314084510.14f17e59@kernel.org> (raw)
In-Reply-To: <02ddee5f-260d-47bc-a842-8938cddc55f5@broadcom.com>
On Fri, 13 Mar 2026 13:21:13 -0700 Justin Chen wrote:
> >> - Switch to devm_clk_get_optional() instead of
> >> devm_clk_get_optional_enabled() so we can manage the clock ourselves.
> >
> > But it is unclear to me what problem this is solving.
> > Or how it relates to the first point - usually the aim
> > is to have one fix per patch.
> >
> > Could you elaborate?
> >
> The double free happens because we double disable the clock. Guess it is
> not exactly a double free. We manage the clock at the driver level so we
> disable it when it is unneeded. The default state is clock disabled when
> no interfaces are up. After we bring down the interfaces, the clock is
> disabled, then when we unbind the driver, it hits a double disable.
AI points out we're not missing a bunch of disable calls if we fail
further down in .probe
> Sure I can turn this into two fixes.
Yes, please
--
pw-bot: cr
prev parent reply other threads:[~2026-03-14 15:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 20:08 [PATCH net] net: bcmasp: fix double frees during remove justin.chen
2026-03-13 16:55 ` Simon Horman
2026-03-13 20:21 ` Justin Chen
2026-03-14 15:45 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260314084510.14f17e59@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=horms@kernel.org \
--cc=justin.chen@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.