From: Yixun Lan <dlan@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Junzhong Pan <junzhong.pan@spacemit.com>,
Guodong Xu <guodong@riscstar.com>,
devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
spacemit@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: soc: spacemit: k3: Decouple composite reset lines
Date: Sat, 14 Mar 2026 16:05:37 +0800 [thread overview]
Message-ID: <20260314080537-GKA415778@kernel.org> (raw)
In-Reply-To: <20260313-certain-idealistic-urchin-001e96@quoll>
Hi Krzysztof,
On 14:42 Fri 13 Mar , Krzysztof Kozlowski wrote:
> On Thu, Mar 12, 2026 at 10:34:19AM +0000, Yixun Lan wrote:
> > Instead of grouping several different reset lines into one composite
> > reset, decouple them to individual ones which make it more aligned
> > with underlying hardware.
> >
> > The DWC3 USB host controller in K3 SoC has three reset lines - AHB, VCC,
> > PHY. The PCIe controller also has three reset lines - DBI, Slave, Master.
>
> Either this is ABI break, which would need explanation, or it is not,
> which also needs explanation and then fixing current bindings before
> they are released.
>
Literally, Changing IDs would result an ABI breakage, but since we have
no consumers - no driver/DT use those IDs so far, so we could safely
renumber it and push as a fix for it. This issue was already raised by
Philipp in this thread [1], and I agreeed, will put some explanations.
Link: https://lore.kernel.org/r/20260312112858-GKH302167@kernel.org [1]
--
Yixun Lan (dlan)
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Yixun Lan <dlan@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Junzhong Pan <junzhong.pan@spacemit.com>,
Guodong Xu <guodong@riscstar.com>,
devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
spacemit@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: soc: spacemit: k3: Decouple composite reset lines
Date: Sat, 14 Mar 2026 16:05:37 +0800 [thread overview]
Message-ID: <20260314080537-GKA415778@kernel.org> (raw)
In-Reply-To: <20260313-certain-idealistic-urchin-001e96@quoll>
Hi Krzysztof,
On 14:42 Fri 13 Mar , Krzysztof Kozlowski wrote:
> On Thu, Mar 12, 2026 at 10:34:19AM +0000, Yixun Lan wrote:
> > Instead of grouping several different reset lines into one composite
> > reset, decouple them to individual ones which make it more aligned
> > with underlying hardware.
> >
> > The DWC3 USB host controller in K3 SoC has three reset lines - AHB, VCC,
> > PHY. The PCIe controller also has three reset lines - DBI, Slave, Master.
>
> Either this is ABI break, which would need explanation, or it is not,
> which also needs explanation and then fixing current bindings before
> they are released.
>
Literally, Changing IDs would result an ABI breakage, but since we have
no consumers - no driver/DT use those IDs so far, so we could safely
renumber it and push as a fix for it. This issue was already raised by
Philipp in this thread [1], and I agreeed, will put some explanations.
Link: https://lore.kernel.org/r/20260312112858-GKH302167@kernel.org [1]
--
Yixun Lan (dlan)
next prev parent reply other threads:[~2026-03-14 8:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 10:34 [PATCH 0/2] reset: spacemit: k3: Decouple the composite reset Yixun Lan
2026-03-12 10:34 ` Yixun Lan
2026-03-12 10:34 ` [PATCH 1/2] dt-bindings: soc: spacemit: k3: Decouple composite reset lines Yixun Lan
2026-03-12 10:34 ` Yixun Lan
2026-03-12 11:09 ` Philipp Zabel
2026-03-12 11:09 ` Philipp Zabel
2026-03-12 11:28 ` Yixun Lan
2026-03-12 11:28 ` Yixun Lan
2026-03-12 17:30 ` Conor Dooley
2026-03-12 17:30 ` Conor Dooley
2026-03-13 0:23 ` Yixun Lan
2026-03-13 0:23 ` Yixun Lan
2026-03-13 15:08 ` Philipp Zabel
2026-03-13 15:08 ` Philipp Zabel
2026-03-13 13:42 ` Krzysztof Kozlowski
2026-03-13 13:42 ` Krzysztof Kozlowski
2026-03-14 8:05 ` Yixun Lan [this message]
2026-03-14 8:05 ` Yixun Lan
2026-03-12 10:34 ` [PATCH 2/2] reset: spacemit: k3: Add individual reset lines for USB, PCIe Yixun Lan
2026-03-12 10:34 ` Yixun Lan
2026-03-12 11:11 ` Philipp Zabel
2026-03-12 11:11 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260314080537-GKA415778@kernel.org \
--to=dlan@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=guodong@riscstar.com \
--cc=junzhong.pan@spacemit.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=spacemit@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.