From: Jakub Kicinski <kuba@kernel.org>
To: I Viswanath <viswanathiyyappan@gmail.com>
Cc: stfomichev@gmail.com, horms@kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, davem@davemloft.net,
eperezma@redhat.com, xuanzhuo@linux.alibaba.com,
jasowang@redhat.com, mst@redhat.com,
przemyslaw.kitszel@intel.com, anthony.l.nguyen@intel.com,
jacob.e.keller@intel.com, ronak.doshi@broadcom.com,
pcnet32@frontier.com, bcm-kernel-feedback-list@broadcom.com,
netdev@vger.kernel.org, virtualization@lists.linux.dev,
intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH net-next v9 0/7] Introduce async callback ndo_set_rx_mode_async
Date: Sat, 14 Mar 2026 13:06:01 -0700 [thread overview]
Message-ID: <20260314130601.0ec7a534@kernel.org> (raw)
In-Reply-To: <20260314182809.362808-1-viswanathiyyappan@gmail.com>
On Sat, 14 Mar 2026 23:58:02 +0530 I Viswanath wrote:
> This is an implementation of the idea provided by Jakub here
>
> https://lore.kernel.org/netdev/20250923163727.5e97abdb@kernel.org/
>
> The set_rx_mode callback is invoked under the addr_lock spinlock which
> makes it illegal to sleep. This means set_rx_mode is prone to
> sleep-in-atomic bugs as drivers have a tendency to do the I/O directly
> in the callback.
Stan is actively working on this:
https://lore.kernel.org/20260313145113.1424442-1-sdf@fomichev.me
I feel like I spent enough time reviewing your attempts and Stan
will not need as much maintainer attention to bring this to
a closure so let him cook. Sorry.
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: I Viswanath <viswanathiyyappan@gmail.com>
Cc: stfomichev@gmail.com, horms@kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, davem@davemloft.net,
eperezma@redhat.com, xuanzhuo@linux.alibaba.com,
jasowang@redhat.com, mst@redhat.com,
przemyslaw.kitszel@intel.com, anthony.l.nguyen@intel.com,
jacob.e.keller@intel.com, ronak.doshi@broadcom.com,
pcnet32@frontier.com, bcm-kernel-feedback-list@broadcom.com,
netdev@vger.kernel.org, virtualization@lists.linux.dev,
intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v9 0/7] Introduce async callback ndo_set_rx_mode_async
Date: Sat, 14 Mar 2026 13:06:01 -0700 [thread overview]
Message-ID: <20260314130601.0ec7a534@kernel.org> (raw)
In-Reply-To: <20260314182809.362808-1-viswanathiyyappan@gmail.com>
On Sat, 14 Mar 2026 23:58:02 +0530 I Viswanath wrote:
> This is an implementation of the idea provided by Jakub here
>
> https://lore.kernel.org/netdev/20250923163727.5e97abdb@kernel.org/
>
> The set_rx_mode callback is invoked under the addr_lock spinlock which
> makes it illegal to sleep. This means set_rx_mode is prone to
> sleep-in-atomic bugs as drivers have a tendency to do the I/O directly
> in the callback.
Stan is actively working on this:
https://lore.kernel.org/20260313145113.1424442-1-sdf@fomichev.me
I feel like I spent enough time reviewing your attempts and Stan
will not need as much maintainer attention to bring this to
a closure so let him cook. Sorry.
next prev parent reply other threads:[~2026-03-14 20:06 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-14 18:28 [Intel-wired-lan] [PATCH net-next v9 0/7] Introduce async callback ndo_set_rx_mode_async I Viswanath
2026-03-14 18:28 ` I Viswanath
2026-03-14 18:28 ` [Intel-wired-lan] [PATCH net-next v9 1/7] net: core: Add state tracking for async netdev ops I Viswanath
2026-03-14 18:28 ` I Viswanath
2026-03-16 7:25 ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-03-16 7:25 ` Loktionov, Aleksandr
2026-03-14 18:28 ` [Intel-wired-lan] [PATCH net-next v9 2/7] net: core: Introduce callback ndo_set_rx_mode_async I Viswanath
2026-03-14 18:28 ` I Viswanath
2026-03-16 7:29 ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-03-16 7:29 ` Loktionov, Aleksandr
2026-03-14 18:28 ` [Intel-wired-lan] [PATCH net-next v9 3/7] virtio-net: Implement ndo_set_rx_mode_async callback I Viswanath
2026-03-14 18:28 ` I Viswanath
2026-03-16 7:30 ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-03-16 7:30 ` Loktionov, Aleksandr
2026-03-14 18:28 ` [Intel-wired-lan] [PATCH net-next v9 4/7] e1000: " I Viswanath
2026-03-14 18:28 ` I Viswanath
2026-03-16 7:30 ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-03-16 7:30 ` Loktionov, Aleksandr
2026-03-14 18:28 ` [Intel-wired-lan] [PATCH net-next v9 5/7] 8139cp: " I Viswanath
2026-03-14 18:28 ` I Viswanath
2026-03-16 7:34 ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-03-16 7:34 ` Loktionov, Aleksandr
2026-03-14 18:28 ` [Intel-wired-lan] [PATCH net-next v9 6/7] vmxnet3: " I Viswanath
2026-03-14 18:28 ` I Viswanath
2026-03-16 7:35 ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-03-16 7:35 ` Loktionov, Aleksandr
2026-03-14 18:28 ` [Intel-wired-lan] [PATCH net-next v9 7/7] pcnet32: " I Viswanath
2026-03-14 18:28 ` I Viswanath
2026-03-16 7:35 ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-03-16 7:35 ` Loktionov, Aleksandr
2026-03-14 20:06 ` Jakub Kicinski [this message]
2026-03-14 20:06 ` [PATCH net-next v9 0/7] Introduce async callback ndo_set_rx_mode_async Jakub Kicinski
2026-03-14 19:59 ` [Intel-wired-lan] " I Viswanath
2026-03-14 19:59 ` I Viswanath
2026-03-17 16:15 ` [Intel-wired-lan] " Jakub Kicinski
2026-03-17 16:15 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260314130601.0ec7a534@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pcnet32@frontier.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=ronak.doshi@broadcom.com \
--cc=stfomichev@gmail.com \
--cc=virtualization@lists.linux.dev \
--cc=viswanathiyyappan@gmail.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.