All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Heiko Stuebner <heiko@sntech.de>
Cc: arm@kernel.org, soc@kernel.org,
	linux-rockchip@lists.infradead.org,
	 linux-arm-kernel@lists.infradead.org
Subject: Re: [GIT PULL] Rockchip dts fixes for 7.0 #1
Date: Tue, 17 Mar 2026 09:45:30 +0100	[thread overview]
Message-ID: <20260317-clever-flat-wolverine-313a4c@quoll> (raw)
In-Reply-To: <5055064.GXAFRqVoOG@phil>

On Sat, Mar 14, 2026 at 07:42:38PM +0100, Heiko Stuebner wrote:
> Hi SoC maintainers,
> 
> please find a below some Rockchip fixes for the current 7.0 release-cycle.
> And in the next PR, even one driver-fix this time.
> 
> Please pull
> 
> Thanks
> Heiko
> 
> 
> The following changes since commit 6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f:
> 
>   Linux 7.0-rc1 (2026-02-22 13:18:59 -0800)
> 
> are available in the Git repository at:
> 
>   https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git tags/v7.0-rockchip-dtsfixes1
> 
> for you to fetch changes up to 2ed11ad1c2b4c191cb2ed6741be127eb99f8634f:
> 
>   arm64: dts: rockchip: Correct Joystick Axes on Gameforce Ace (2026-03-12 20:52:53 +0100)
> 
> ----------------------------------------------------------------
> A big number of changes fixing dt-schema issues on the ARM32 side,
> fixes for the Gameforce-Ace to make the hardware work properly
> (including thermals) as well as fixing issues both on Beelink A1 (spdif)
> and Pinebook Pro (Wifi) by reverting the commits that created the issues
> 
> ----------------------------------------------------------------
> Chris Morgan (2):
>       arm64: dts: rockchip: Correct Fan Supply for Gameforce Ace
>       arm64: dts: rockchip: Correct Joystick Axes on Gameforce Ace
> 
> Fabio Estevam (11):
>       ARM: dts: rockchip: Remove rockchip,grf from rk3288 tsadc
>       ARM: dts: rockchip: Move PHY reset to ethernet-phy node on rk3036 boards
>       ARM: dts: rockchip: Fix RTC compatible on rk3288-phycore-rdk
>       ARM: dts: rockchip: Use mount-matrix on rk3188-bqedison2qc
>       ARM: dts: rockchip: Remove invalid regulator-property from rk3288-veyron

Not a fix.

>       ARM: dts: rockchip: Fix the Bluetooth node name on rk3288-veyron

Not a fix. This is a pure style change. Fixes for current cycle means
either important issues being fixed or errors introduced in current
cycle.

Changing style from one to another is not a fix.

>       ARM: dts: rockchip: Fix the trackpad supply on rk3288-veyron-jerry
>       ARM: dts: rockchip: Add missing the touchscreen interrupt on rk3288-phycore-rdk
>       ARM: dts: rockchip: Fix RTC description on rk3288-firefly-reload

Not a fix. Style of node name is not a bug, otherwise describe user
visible (not "internal tools" visible) impact.

>       ARM: dts: rockchip: Fix GMAC description n RK3288 boards
>       ARM: dts: rockchip: Fix LED node names on rk3288-phycore-rdk

Several other are questionable as well, since they were in DTS for long
time. Please also read Linus' explanation here from some time ago - if
the issue is for long time and no one cared, then changing it is a normal
development.

Several changed pieces here look like 3 or more years old, so does not
fit criteria of current cycle fix at all.

Please split the pull.

Best regards,
Krzysztof



WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Heiko Stuebner <heiko@sntech.de>
Cc: arm@kernel.org, soc@kernel.org,
	linux-rockchip@lists.infradead.org,
	 linux-arm-kernel@lists.infradead.org
Subject: Re: [GIT PULL] Rockchip dts fixes for 7.0 #1
Date: Tue, 17 Mar 2026 09:45:30 +0100	[thread overview]
Message-ID: <20260317-clever-flat-wolverine-313a4c@quoll> (raw)
In-Reply-To: <5055064.GXAFRqVoOG@phil>

On Sat, Mar 14, 2026 at 07:42:38PM +0100, Heiko Stuebner wrote:
> Hi SoC maintainers,
> 
> please find a below some Rockchip fixes for the current 7.0 release-cycle.
> And in the next PR, even one driver-fix this time.
> 
> Please pull
> 
> Thanks
> Heiko
> 
> 
> The following changes since commit 6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f:
> 
>   Linux 7.0-rc1 (2026-02-22 13:18:59 -0800)
> 
> are available in the Git repository at:
> 
>   https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git tags/v7.0-rockchip-dtsfixes1
> 
> for you to fetch changes up to 2ed11ad1c2b4c191cb2ed6741be127eb99f8634f:
> 
>   arm64: dts: rockchip: Correct Joystick Axes on Gameforce Ace (2026-03-12 20:52:53 +0100)
> 
> ----------------------------------------------------------------
> A big number of changes fixing dt-schema issues on the ARM32 side,
> fixes for the Gameforce-Ace to make the hardware work properly
> (including thermals) as well as fixing issues both on Beelink A1 (spdif)
> and Pinebook Pro (Wifi) by reverting the commits that created the issues
> 
> ----------------------------------------------------------------
> Chris Morgan (2):
>       arm64: dts: rockchip: Correct Fan Supply for Gameforce Ace
>       arm64: dts: rockchip: Correct Joystick Axes on Gameforce Ace
> 
> Fabio Estevam (11):
>       ARM: dts: rockchip: Remove rockchip,grf from rk3288 tsadc
>       ARM: dts: rockchip: Move PHY reset to ethernet-phy node on rk3036 boards
>       ARM: dts: rockchip: Fix RTC compatible on rk3288-phycore-rdk
>       ARM: dts: rockchip: Use mount-matrix on rk3188-bqedison2qc
>       ARM: dts: rockchip: Remove invalid regulator-property from rk3288-veyron

Not a fix.

>       ARM: dts: rockchip: Fix the Bluetooth node name on rk3288-veyron

Not a fix. This is a pure style change. Fixes for current cycle means
either important issues being fixed or errors introduced in current
cycle.

Changing style from one to another is not a fix.

>       ARM: dts: rockchip: Fix the trackpad supply on rk3288-veyron-jerry
>       ARM: dts: rockchip: Add missing the touchscreen interrupt on rk3288-phycore-rdk
>       ARM: dts: rockchip: Fix RTC description on rk3288-firefly-reload

Not a fix. Style of node name is not a bug, otherwise describe user
visible (not "internal tools" visible) impact.

>       ARM: dts: rockchip: Fix GMAC description n RK3288 boards
>       ARM: dts: rockchip: Fix LED node names on rk3288-phycore-rdk

Several other are questionable as well, since they were in DTS for long
time. Please also read Linus' explanation here from some time ago - if
the issue is for long time and no one cared, then changing it is a normal
development.

Several changed pieces here look like 3 or more years old, so does not
fit criteria of current cycle fix at all.

Please split the pull.

Best regards,
Krzysztof


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2026-03-17  8:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-14 18:42 [GIT PULL] Rockchip dts fixes for 7.0 #1 Heiko Stuebner
2026-03-14 18:42 ` Heiko Stuebner
2026-03-17  8:45 ` Krzysztof Kozlowski [this message]
2026-03-17  8:45   ` Krzysztof Kozlowski
2026-03-17  9:05   ` Heiko Stuebner
2026-03-17  9:05     ` Heiko Stuebner
2026-03-17  9:19     ` Krzysztof Kozlowski
2026-03-17  9:19       ` Krzysztof Kozlowski
2026-03-17 10:02       ` Heiko Stuebner
2026-03-17 10:02         ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260317-clever-flat-wolverine-313a4c@quoll \
    --to=krzk@kernel.org \
    --cc=arm@kernel.org \
    --cc=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=soc@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.