All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denis@denix.org>
To: a-christidis@ti.com
Cc: reatmon@ti.com, denys@konsulko.com, meta-arago@lists.yoctoproject.org
Subject: Re: [meta-arago][master][PATCH 1/2] libsdl2: Add tests package
Date: Tue, 17 Mar 2026 15:14:26 -0400	[thread overview]
Message-ID: <20260317191426.GA11121@denix.org> (raw)
In-Reply-To: <20260317185724.34717-2-a-christidis@ti.com>

On Tue, Mar 17, 2026 at 01:57:23PM -0500, Antonios Christidis via lists.yoctoproject.org wrote:
> From: Antonios Christidis <a-christidis@ti.com>
> 
> The software provides tests, configure cmake to build and install them.
> Package the tests in -tests package.

This might be useful to get it upstreamed as a new PACKAGECONFIG to OE-Core...


> Signed-off-by: Antonios Christidis <a-christidis@ti.com>
> ---
>  meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc     | 6 ++++++
>  meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend | 4 ++++
>  2 files changed, 10 insertions(+)
>  create mode 100644 meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc
>  create mode 100644 meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend
> 
> diff --git a/meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc b/meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc
> new file mode 100644
> index 00000000..f33ff909
> --- /dev/null
> +++ b/meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc
> @@ -0,0 +1,6 @@
> +EXTRA_OECMAKE:append = " -DSDL_TESTS=ON \
> +                         -DSDL_INSTALL_TESTS=ON \
> +                       "

There's no reason for :append here, while += could work just fine.


> +PACKAGE_BEFORE_PN = "${PN}-tests"

> +FILES:${PN}-tests += "${libexecdir} ${datadir}/installed-tests/SDL2"
> +FILES:${PN}-tests:class-nativesdk += "${libexecdir} ${datadir}/installed-tests/SDL2"

If the values for these 2 are identical, why do you need to set 
class-nativesdk variant explixitly?


> diff --git a/meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend b/meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend
> new file mode 100644
> index 00000000..385aa801
> --- /dev/null
> +++ b/meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend
> @@ -0,0 +1,4 @@
> +LIBSDL2_TI = ""
> +LIBSDL2_TI:ti-soc = "libsdl2-ti.inc"
> +
> +require ${LIBSDL2_TI}
> -- 
> 2.34.1


  reply	other threads:[~2026-03-17 19:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-17 18:57 [meta-arago][master][PATCH 0/2] Add libsdl2 test support a-christidis
2026-03-17 18:57 ` [meta-arago][master][PATCH 1/2] libsdl2: Add tests package a-christidis
2026-03-17 19:14   ` Denys Dmytriyenko [this message]
2026-03-17 19:27     ` Ryan Eatmon
2026-03-17 19:29     ` Antonios Christidis
2026-03-17 19:56       ` Denys Dmytriyenko
2026-03-17 19:58       ` Ryan Eatmon
2026-03-17 18:57 ` [meta-arago][master][PATCH 2/2] ti-test: Add libsdl2-tests to packagegroup a-christidis
2026-03-17 19:03 ` [meta-arago][master][PATCH 0/2] Add libsdl2 test support PRC Automation

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260317191426.GA11121@denix.org \
    --to=denis@denix.org \
    --cc=a-christidis@ti.com \
    --cc=denys@konsulko.com \
    --cc=meta-arago@lists.yoctoproject.org \
    --cc=reatmon@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.