Re: [meta-arago][master][PATCH 1/2] libsdl2: Add tests package

[Ryan Eatmon <reatmon@ti.com>]

On 3/17/2026 2:14 PM, Denys Dmytriyenko wrote:
> On Tue, Mar 17, 2026 at 01:57:23PM -0500, Antonios Christidis via lists.yoctoproject.org wrote:
>> From: Antonios Christidis <a-christidis@ti.com>
>>
>> The software provides tests, configure cmake to build and install them.
>> Package the tests in -tests package.
> 
> This might be useful to get it upstreamed as a new PACKAGECONFIG to OE-Core...

Good idea.


> 
>> Signed-off-by: Antonios Christidis <a-christidis@ti.com>
>> ---
>>   meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc     | 6 ++++++
>>   meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend | 4 ++++
>>   2 files changed, 10 insertions(+)
>>   create mode 100644 meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc
>>   create mode 100644 meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend
>>
>> diff --git a/meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc b/meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc
>> new file mode 100644
>> index 00000000..f33ff909
>> --- /dev/null
>> +++ b/meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc
>> @@ -0,0 +1,6 @@
>> +EXTRA_OECMAKE:append = " -DSDL_TESTS=ON \
>> +                         -DSDL_INSTALL_TESTS=ON \
>> +                       "
> 
> There's no reason for :append here, while += could work just fine.
> 
> 
>> +PACKAGE_BEFORE_PN = "${PN}-tests"
> 
>> +FILES:${PN}-tests += "${libexecdir} ${datadir}/installed-tests/SDL2"
>> +FILES:${PN}-tests:class-nativesdk += "${libexecdir} ${datadir}/installed-tests/SDL2"
> 
> If the values for these 2 are identical, why do you need to set
> class-nativesdk variant explixitly?
> 
> 
>> diff --git a/meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend b/meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend
>> new file mode 100644
>> index 00000000..385aa801
>> --- /dev/null
>> +++ b/meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend
>> @@ -0,0 +1,4 @@
>> +LIBSDL2_TI = ""
>> +LIBSDL2_TI:ti-soc = "libsdl2-ti.inc"
>> +
>> +require ${LIBSDL2_TI}
>> -- 
>> 2.34.1

-- 
Ryan Eatmon                reatmon@ti.com
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS