[iwlwifi-next:nan_mac80211_phase2 16/57] drivers/net/wireless/virtual/mac80211_hwsim_nan.c:97:13: warning: the comparison will always evaluate as 'true' for the address of 'cluster_id' will never be NULL

[iwlwifi-next:nan_mac80211_phase2 16/57] drivers/net/wireless/virtual/mac80211_hwsim_nan.c:97:13: warning: the comparison will always evaluate as 'true' for the address of 'cluster_id' will never be NULL

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-next.git nan_mac80211_phase2
head:   58d5be8674f5cfc433f052fc97babb86d56bea7b
commit: e1650f3f7a57295eb773434169d90fc5a87db97a [16/57] wifi: mac80211_hwsim: split NAN handling into separate file
config: x86_64-rhel-9.4-ltp (https://download.01.org/0day-ci/archive/20260317/202603172200.lfgarRbI-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260317/202603172200.lfgarRbI-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603172200.lfgarRbI-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/net/wireless/virtual/mac80211_hwsim_nan.c: In function 'mac80211_hwsim_nan_start':
>> drivers/net/wireless/virtual/mac80211_hwsim_nan.c:97:13: warning: the comparison will always evaluate as 'true' for the address of 'cluster_id' will never be NULL [-Waddress]
      97 |         if (conf->cluster_id && !is_zero_ether_addr(conf->cluster_id) &&
         |             ^~~~
   In file included from include/net/mac80211.h:22,
                    from drivers/net/wireless/virtual/mac80211_hwsim_i.h:13,
                    from drivers/net/wireless/virtual/mac80211_hwsim_nan.c:7:
   include/net/cfg80211.h:4118:12: note: 'cluster_id' declared here
    4118 |         u8 cluster_id[ETH_ALEN] __aligned(2);
         |            ^~~~~~~~~~


vim +97 drivers/net/wireless/virtual/mac80211_hwsim_nan.c

    68	
    69	int mac80211_hwsim_nan_start(struct ieee80211_hw *hw,
    70				     struct ieee80211_vif *vif,
    71				     struct cfg80211_nan_conf *conf)
    72	{
    73		struct mac80211_hwsim_data *data = hw->priv;
    74		u64 tsf = mac80211_hwsim_get_tsf(hw, NULL);
    75		u32 dw_int = 512 * 1000;
    76		u64 until_dw = dw_int - do_div(tsf, dw_int);
    77		struct wireless_dev *wdev = ieee80211_vif_to_wdev(vif);
    78	
    79		if (vif->type != NL80211_IFTYPE_NAN)
    80			return -EINVAL;
    81	
    82		if (data->nan.device_vif)
    83			return -EALREADY;
    84	
    85		/* set this before starting the timer, as preemption might occur */
    86		data->nan.device_vif = vif;
    87		data->nan.bands = conf->bands;
    88		data->nan.curr_dw_band = NL80211_BAND_2GHZ;
    89	
    90		wiphy_debug(hw->wiphy, "nan_started, next_dw=%llu\n",
    91			    until_dw);
    92	
    93		hrtimer_start(&data->nan.timer,
    94			      ns_to_ktime(until_dw * NSEC_PER_USEC),
    95			      HRTIMER_MODE_REL_SOFT);
    96	
  > 97		if (conf->cluster_id && !is_zero_ether_addr(conf->cluster_id) &&
    98		    is_zero_ether_addr(hwsim_nan_cluster_id)) {
    99			memcpy(hwsim_nan_cluster_id, conf->cluster_id, ETH_ALEN);
   100		} else if (is_zero_ether_addr(hwsim_nan_cluster_id)) {
   101			hwsim_nan_cluster_id[0] = 0x50;
   102			hwsim_nan_cluster_id[1] = 0x6f;
   103			hwsim_nan_cluster_id[2] = 0x9a;
   104			hwsim_nan_cluster_id[3] = 0x01;
   105			hwsim_nan_cluster_id[4] = get_random_u8();
   106			hwsim_nan_cluster_id[5] = get_random_u8();
   107		}
   108	
   109		data->nan.notify_dw = conf->enable_dw_notification;
   110	
   111		cfg80211_nan_cluster_joined(wdev, hwsim_nan_cluster_id, true,
   112					    GFP_KERNEL);
   113	
   114		return 0;
   115	}
   116	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki