All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Bobby Eshleman <bobbyeshleman@gmail.com>
Cc: Stanislav Fomichev <stfomichev@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	Shuah Khan <shuah@kernel.org>,
	Stanislav Fomichev <sdf@fomichev.me>,
	Mina Almasry <almasrymina@google.com>, Wei Wang <weibunny@fb.com>,
	David Wei <dw@davidwei.uk>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-kselftest@vger.kernel.org, bpf@vger.kernel.org,
	Bobby Eshleman <bobbyeshleman@meta.com>
Subject: Re: [PATCH net-next 5/6] selftests: drv-net: add netkit devmem RX test
Date: Wed, 18 Mar 2026 16:10:10 -0700	[thread overview]
Message-ID: <20260318161010.2d7338b5@kernel.org> (raw)
In-Reply-To: <abrRDNi79H9ircl1@devvm11784.nha0.facebook.com>

On Wed, 18 Mar 2026 09:21:32 -0700 Bobby Eshleman wrote:
> > > IIUC, we could have main() do something like:
> > > 
> > > for env [NetDrvContEnv, NetDrvEpEnv]:
> > >     with env as cfg:
> > >         [...]
> > >         ksft_run(tests, args=(cfg,))
> > > 
> > > 
> > > And then the tests could call helpers that check cfg.netns to use the
> > > nk_{guest,host}_ip6 addresses when true, otherwise use the regular
> > > addresses?
> > > 
> > > It should be doable if I'm following your drift.  
> > 
> > Yeah, yeah, this plus some small changes here and there (to pass your
> > new -n in the netns mode for example).  
> 
> Sounds good, I'll give it a look.

I haven't actually looked but double check ksft_run can actually 
be called multiple times. We may have some global state :S

  reply	other threads:[~2026-03-18 23:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-16 22:29 [PATCH net-next 0/6] net: devmem: support devmem with netkit devices Bobby Eshleman
2026-03-16 22:29 ` [PATCH net-next 1/6] net: devmem: support TX through netkit leased queues Bobby Eshleman
2026-03-16 22:29 ` [PATCH net-next 2/6] selftests: drv-net: extract _find_bss_map_id helper in NetDrvContEnv Bobby Eshleman
2026-03-16 22:29 ` [PATCH net-next 3/6] selftests: drv-net: add skip-config flag to ncdevmem Bobby Eshleman
2026-03-16 22:29 ` [PATCH net-next 4/6] selftests: drv-net: add primary RX redirect support to NetDrvContEnv Bobby Eshleman
2026-03-16 22:29 ` [PATCH net-next 5/6] selftests: drv-net: add netkit devmem RX test Bobby Eshleman
2026-03-18  0:08   ` Stanislav Fomichev
2026-03-18  0:54     ` Bobby Eshleman
2026-03-18 14:59       ` Stanislav Fomichev
2026-03-18 16:21         ` Bobby Eshleman
2026-03-18 23:10           ` Jakub Kicinski [this message]
2026-03-19  0:01             ` Bobby Eshleman
2026-03-16 22:29 ` [PATCH net-next 6/6] selftests: drv-net: add netkit devmem TX test Bobby Eshleman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260318161010.2d7338b5@kernel.org \
    --to=kuba@kernel.org \
    --cc=almasrymina@google.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=bobbyeshleman@gmail.com \
    --cc=bobbyeshleman@meta.com \
    --cc=bpf@vger.kernel.org \
    --cc=davem@davemloft.net \
    --cc=dw@davidwei.uk \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sdf@fomichev.me \
    --cc=shuah@kernel.org \
    --cc=stfomichev@gmail.com \
    --cc=weibunny@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.