[PATCH net-next] dt-bindings: net: Remove redundant ethernet-phy-ieee802.3-c22 fallback

[PATCH net-next] dt-bindings: net: Remove redundant ethernet-phy-ieee802.3-c22 fallback

[Biju]

From: Biju Das <biju.das.jz@bp.renesas.com>

Drop the ethernet-phy-ieee802.3-c22 compatible string from ethernet PHY
bindings and their examples. The c22 fallback is implicitly assumed for
PHY ID-based compatible strings and does not need to be stated explicitly,
unlike c45 which requires opt-in.

Remove the c22 pattern from the ethernet-phy.yaml schema and update
examples in amlogic,g12a-mdio-mux, mscc-phy-vsc8531, renesas,ether,
and renesas,etheravb bindings accordingly.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
 .../devicetree/bindings/net/amlogic,g12a-mdio-mux.yaml         | 3 +--
 Documentation/devicetree/bindings/net/ethernet-phy.yaml        | 3 ---
 Documentation/devicetree/bindings/net/mscc-phy-vsc8531.yaml    | 3 +--
 Documentation/devicetree/bindings/net/renesas,ether.yaml       | 3 +--
 Documentation/devicetree/bindings/net/renesas,etheravb.yaml    | 3 +--
 5 files changed, 4 insertions(+), 11 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/amlogic,g12a-mdio-mux.yaml b/Documentation/devicetree/bindings/net/amlogic,g12a-mdio-mux.yaml
index ec5c038ce6a0..e9e575fab62c 100644
--- a/Documentation/devicetree/bindings/net/amlogic,g12a-mdio-mux.yaml
+++ b/Documentation/devicetree/bindings/net/amlogic,g12a-mdio-mux.yaml
@@ -69,8 +69,7 @@ examples:
             #size-cells = <0>;
 
             ethernet-phy@8 {
-                compatible = "ethernet-phy-id0180.3301",
-                             "ethernet-phy-ieee802.3-c22";
+                compatible = "ethernet-phy-id0180.3301";
                 interrupts = <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>;
                 reg = <8>;
                 max-speed = <100>;
diff --git a/Documentation/devicetree/bindings/net/ethernet-phy.yaml b/Documentation/devicetree/bindings/net/ethernet-phy.yaml
index 58634fee9fc4..d622e73a89ff 100644
--- a/Documentation/devicetree/bindings/net/ethernet-phy.yaml
+++ b/Documentation/devicetree/bindings/net/ethernet-phy.yaml
@@ -47,9 +47,6 @@ properties:
           second group of digits is the Phy Identifier 2 register,
           this is the chip vendor OUI bits 19:24, followed by 10
           bits of a vendor specific ID.
-      - items:
-          - pattern: "^ethernet-phy-id[a-f0-9]{4}\\.[a-f0-9]{4}$"
-          - const: ethernet-phy-ieee802.3-c22
       - items:
           - pattern: "^ethernet-phy-id[a-f0-9]{4}\\.[a-f0-9]{4}$"
           - const: ethernet-phy-ieee802.3-c45
diff --git a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.yaml b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.yaml
index 0afbd0ff126f..5e5dea7987e7 100644
--- a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.yaml
+++ b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.yaml
@@ -32,7 +32,6 @@ properties:
       - enum:
           - ethernet-phy-id0007.0570 # VSC8531
           - ethernet-phy-id0007.0772 # VSC8541
-      - const: ethernet-phy-ieee802.3-c22
 
   vsc8531,vddmac:
     $ref: /schemas/types.yaml#/definitions/uint32
@@ -120,7 +119,7 @@ examples:
         #size-cells = <0>;
 
         ethernet-phy@0 {
-            compatible = "ethernet-phy-id0007.0772", "ethernet-phy-ieee802.3-c22";
+            compatible = "ethernet-phy-id0007.0772";
             reg = <0>;
             vsc8531,vddmac = <3300>;
             vsc8531,edge-slowdown = <7>;
diff --git a/Documentation/devicetree/bindings/net/renesas,ether.yaml b/Documentation/devicetree/bindings/net/renesas,ether.yaml
index f0a52f47f95a..dd7187f12a67 100644
--- a/Documentation/devicetree/bindings/net/renesas,ether.yaml
+++ b/Documentation/devicetree/bindings/net/renesas,ether.yaml
@@ -121,8 +121,7 @@ examples:
         #size-cells = <0>;
 
         phy1: ethernet-phy@1 {
-            compatible = "ethernet-phy-id0022.1537",
-                         "ethernet-phy-ieee802.3-c22";
+            compatible = "ethernet-phy-id0022.1537";
             reg = <1>;
             interrupt-parent = <&irqc0>;
             interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
diff --git a/Documentation/devicetree/bindings/net/renesas,etheravb.yaml b/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
index 1e00ef5b3acd..6aea1acaaa59 100644
--- a/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
+++ b/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
@@ -364,8 +364,7 @@ examples:
             #size-cells = <0>;
 
             phy0: ethernet-phy@0 {
-                    compatible = "ethernet-phy-id0022.1622",
-                                 "ethernet-phy-ieee802.3-c22";
+                    compatible = "ethernet-phy-id0022.1622";
                     rxc-skew-ps = <1500>;
                     reg = <0>;
                     interrupt-parent = <&gpio2>;
-- 
2.43.0

Re: [PATCH net-next] dt-bindings: net: Remove redundant ethernet-phy-ieee802.3-c22 fallback

[Jakub Kicinski]

On Fri, 13 Mar 2026 13:06:21 +0000 Biju wrote:
> From: Biju Das <biju.das.jz@bp.renesas.com>
> 
> Drop the ethernet-phy-ieee802.3-c22 compatible string from ethernet PHY
> bindings and their examples. The c22 fallback is implicitly assumed for
> PHY ID-based compatible strings and does not need to be stated explicitly,
> unlike c45 which requires opt-in.
> 
> Remove the c22 pattern from the ethernet-phy.yaml schema and update
> examples in amlogic,g12a-mdio-mux, mscc-phy-vsc8531, renesas,ether,
> and renesas,etheravb bindings accordingly.

Maybe a noob question but why are you not updating all the other ones?

$ git grep --files-with-matches 'ethernet-phy-ieee802.3-c22' -- \
	Documentation/devicetree/bindings/net/ | \
	wc -l
16

RE: [PATCH net-next] dt-bindings: net: Remove redundant ethernet-phy-ieee802.3-c22 fallback

[Biju Das]

Hi Jakub Kicinski,

Thanks for the feedback.

> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: 19 March 2026 00:05
> Subject: Re: [PATCH net-next] dt-bindings: net: Remove redundant ethernet-phy-ieee802.3-c22 fallback
> 
> On Fri, 13 Mar 2026 13:06:21 +0000 Biju wrote:
> > From: Biju Das <biju.das.jz@bp.renesas.com>
> >
> > Drop the ethernet-phy-ieee802.3-c22 compatible string from ethernet
> > PHY bindings and their examples. The c22 fallback is implicitly
> > assumed for PHY ID-based compatible strings and does not need to be
> > stated explicitly, unlike c45 which requires opt-in.
> >
> > Remove the c22 pattern from the ethernet-phy.yaml schema and update
> > examples in amlogic,g12a-mdio-mux, mscc-phy-vsc8531, renesas,ether,
> > and renesas,etheravb bindings accordingly.
> 
> Maybe a noob question but why are you not updating all the other ones?
> 
> $ git grep --files-with-matches 'ethernet-phy-ieee802.3-c22' -- \
> 	Documentation/devicetree/bindings/net/ | \
> 	wc -l
> 16

The other files have only 'compatible = "ethernet-phy-ieee802.3-c22"'

Whereas this patch removes the fallback pattern based on
Rob's suggestion [1]

compatible = "ethernet-phy-id0022.1622",                     
		 "ethernet-phy-ieee802.3-c22"; 


Please let me know, should I drop all 'ethernet-phy-ieee802.3-c22' compatibles? 

[1] https://lore.kernel.org/all/CAL_JsqJK3brXxSeD-U42PBCeHoxUhWJYho3ZWj__t5C1LL-n-Q@mail.gmail.com/

Cheers,
Biju

Re: [PATCH net-next] dt-bindings: net: Remove redundant ethernet-phy-ieee802.3-c22 fallback

[Jakub Kicinski]

On Thu, 19 Mar 2026 14:38:37 +0000 Biju Das wrote:
> > Maybe a noob question but why are you not updating all the other ones?
> > 
> > $ git grep --files-with-matches 'ethernet-phy-ieee802.3-c22' -- \
> > 	Documentation/devicetree/bindings/net/ | \
> > 	wc -l
> > 16  
> 
> The other files have only 'compatible = "ethernet-phy-ieee802.3-c22"'
> 
> Whereas this patch removes the fallback pattern based on
> Rob's suggestion [1]
> 
> compatible = "ethernet-phy-id0022.1622",                     
> 		 "ethernet-phy-ieee802.3-c22"; 

Got it

> Please let me know, should I drop all 'ethernet-phy-ieee802.3-c22' compatibles? 

No, let's wait for DT maintainers' review.

Re: [PATCH net-next] dt-bindings: net: Remove redundant ethernet-phy-ieee802.3-c22 fallback

[Rob Herring]

On Fri, Mar 13, 2026 at 01:06:21PM +0000, Biju wrote:
> From: Biju Das <biju.das.jz@bp.renesas.com>
> 
> Drop the ethernet-phy-ieee802.3-c22 compatible string from ethernet PHY
> bindings and their examples. The c22 fallback is implicitly assumed for
> PHY ID-based compatible strings and does not need to be stated explicitly,
> unlike c45 which requires opt-in.
> 
> Remove the c22 pattern from the ethernet-phy.yaml schema and update
> examples in amlogic,g12a-mdio-mux, mscc-phy-vsc8531, renesas,ether,
> and renesas,etheravb bindings accordingly.

This will introduce a ton of warnings in .dts files which I don't think 
anyone wants to go fix.

While I think it's redundant to have the c22 (or c45) fallback as it 
isn't really useful on its own, I think we are too far down that path.

You need a custom 'select' in all the schemas that have a c22 
compatible to exclude it from matching.

Rob

Re: [PATCH net-next] dt-bindings: net: Remove redundant ethernet-phy-ieee802.3-c22 fallback

[kernel test robot]

:::::: 
:::::: Manual check reason: "dtcheck: binding changes may go via different trees"
:::::: 

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20260313130623.297712-1-biju.das.jz@bp.renesas.com>
References: <20260313130623.297712-1-biju.das.jz@bp.renesas.com>
TO: Biju <biju.das.au@gmail.com>
TO: Andrew Lunn <andrew+netdev@lunn.ch>
TO: "David S. Miller" <davem@davemloft.net>
CC: netdev@vger.kernel.org
TO: Eric Dumazet <edumazet@google.com>
TO: Jakub Kicinski <kuba@kernel.org>
TO: Paolo Abeni <pabeni@redhat.com>
TO: Rob Herring <robh@kernel.org>
TO: Krzysztof Kozlowski <krzk@kernel.org>
TO: Conor Dooley <conor+dt@kernel.org>
TO: Heiner Kallweit <hkallweit1@gmail.com>
TO: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
TO: Geert Uytterhoeven <geert+renesas@glider.be>
TO: Magnus Damm <magnus.damm@gmail.com>
CC: Biju Das <biju.das.jz@bp.renesas.com>
CC: Russell King <linux@armlinux.org.uk>
CC: Paul Barker <paul@pbarker.dev>
CC: Neil Armstrong <neil.armstrong@linaro.org>
CC: Florian Fainelli <f.fainelli@gmail.com>
CC: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
CC: Sergei Shtylyov <sergei.shtylyov@gmail.com>
CC: devicetree@vger.kernel.org
CC: linux-kernel@vger.kernel.org
CC: linux-renesas-soc@vger.kernel.org

Hi Biju,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Biju/dt-bindings-net-Remove-redundant-ethernet-phy-ieee802-3-c22-fallback/20260315-110627
base:   net-next/main
patch link:    https://lore.kernel.org/r/20260313130623.297712-1-biju.das.jz%40bp.renesas.com
patch subject: [PATCH net-next] dt-bindings: net: Remove redundant ethernet-phy-ieee802.3-c22 fallback
:::::: branch date: 13 hours ago
:::::: commit date: 13 hours ago
config: riscv-randconfig-2051-20260315 (https://download.01.org/0day-ci/archive/20260315/202603151613.OgnQNFgJ-lkp@intel.com/config)
compiler: riscv32-linux-gcc (GCC) 10.5.0
dtschema: 2025.13.dev8+g0515abdd9
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260315/202603151613.OgnQNFgJ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202603151613.OgnQNFgJ-lkp@intel.com/

dtcheck warnings: (new ones prefixed by >>)
>> arch/riscv/boot/dts/renesas/r9a07g043f01-smarc.dtb: ethernet-phy@7 (ethernet-phy-id0022.1640): compatible: 'oneOf' conditional failed, one must be fixed:
   	['ethernet-phy-id0022.1640', 'ethernet-phy-ieee802.3-c22'] is too long
   	'ethernet-phy-ieee802.3-c22' was expected
   	'ethernet-phy-ieee802.3-c45' was expected
   	from schema $id: http://devicetree.org/schemas/net/micrel,gigabit.yaml
   arch/riscv/boot/dts/renesas/r9a07g043f01-smarc.dtb: ethernet-phy@7 (ethernet-phy-id0022.1640): compatible: ['ethernet-phy-id0022.1640', 'ethernet-phy-ieee802.3-c22'] is too long
   	from schema $id: http://devicetree.org/schemas/net/micrel,gigabit.yaml
>> arch/riscv/boot/dts/renesas/r9a07g043f01-smarc.dtb: ethernet-phy@7 (ethernet-phy-id0022.1640): Unevaluated properties are not allowed ('interrupts-extended', 'reg' were unexpected)
   	from schema $id: http://devicetree.org/schemas/net/micrel,gigabit.yaml
>> arch/riscv/boot/dts/renesas/r9a07g043f01-smarc.dtb: ethernet-phy@7 (ethernet-phy-id0022.1640): compatible: 'oneOf' conditional failed, one must be fixed:
   	['ethernet-phy-id0022.1640', 'ethernet-phy-ieee802.3-c22'] is too long
   	'ethernet-phy-ieee802.3-c22' was expected
   	'ethernet-phy-ieee802.3-c45' was expected
   	from schema $id: http://devicetree.org/schemas/net/ethernet-phy.yaml

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki