From: Eric Biggers via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Cen Zhang <zzzccc427@gmail.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, baijiaju1990@gmail.com,
jaegeuk@kernel.org
Subject: Re: [f2fs-dev] [PATCH] f2fs: annotate data races around fi->i_flags
Date: Wed, 18 Mar 2026 19:57:10 -0700 [thread overview]
Message-ID: <20260319025710.GA357817@sol> (raw)
In-Reply-To: <20260319022335.3213311-1-zzzccc427@gmail.com>
On Thu, Mar 19, 2026 at 10:23:35AM +0800, Cen Zhang wrote:
> fi->i_flags can be read by f2fs_update_inode() in the writeback path,
> f2fs_getattr(), and f2fs_fileattr_get() without holding inode_lock or
> fi->i_sem, while it can be concurrently written by
> f2fs_setflags_common(), set_compress_context(), and
> f2fs_disable_compressed_file() under inode_lock and/or fi->i_sem.
>
> This is a data race as defined by the LKMM. Use READ_ONCE() on the
> read side and WRITE_ONCE() on the write side to ensure proper marking
> of the concurrent accesses.
>
> Fixes: 360985573b55 ("f2fs: separate f2fs i_flags from fs_flags and ext4 i_flags")
> Cc: stable@vger.kernel.org
> Signed-off-by: Cen Zhang <zzzccc427@gmail.com>
Is that really the correct Fixes commit? I don't see what it has to do
with this issue.
- Eric
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: Cen Zhang <zzzccc427@gmail.com>
Cc: jaegeuk@kernel.org, chao@kernel.org, baijiaju1990@gmail.com,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: annotate data races around fi->i_flags
Date: Wed, 18 Mar 2026 19:57:10 -0700 [thread overview]
Message-ID: <20260319025710.GA357817@sol> (raw)
In-Reply-To: <20260319022335.3213311-1-zzzccc427@gmail.com>
On Thu, Mar 19, 2026 at 10:23:35AM +0800, Cen Zhang wrote:
> fi->i_flags can be read by f2fs_update_inode() in the writeback path,
> f2fs_getattr(), and f2fs_fileattr_get() without holding inode_lock or
> fi->i_sem, while it can be concurrently written by
> f2fs_setflags_common(), set_compress_context(), and
> f2fs_disable_compressed_file() under inode_lock and/or fi->i_sem.
>
> This is a data race as defined by the LKMM. Use READ_ONCE() on the
> read side and WRITE_ONCE() on the write side to ensure proper marking
> of the concurrent accesses.
>
> Fixes: 360985573b55 ("f2fs: separate f2fs i_flags from fs_flags and ext4 i_flags")
> Cc: stable@vger.kernel.org
> Signed-off-by: Cen Zhang <zzzccc427@gmail.com>
Is that really the correct Fixes commit? I don't see what it has to do
with this issue.
- Eric
next prev parent reply other threads:[~2026-03-19 2:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 2:23 [f2fs-dev] [PATCH] f2fs: annotate data races around fi->i_flags Cen Zhang
2026-03-19 2:23 ` Cen Zhang
2026-03-19 2:57 ` Eric Biggers via Linux-f2fs-devel [this message]
2026-03-19 2:57 ` [f2fs-dev] " Eric Biggers
2026-03-19 3:24 ` Cen Zhang
2026-03-19 3:24 ` Cen Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260319025710.GA357817@sol \
--to=linux-f2fs-devel@lists.sourceforge.net \
--cc=baijiaju1990@gmail.com \
--cc=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=zzzccc427@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.