Re: [PATCH] iio: adc: qcom-spmi-adc5-gen3: remove redundant OR with zero

[Jonathan Cameron <jic23@kernel.org>]

On Thu, 19 Mar 2026 11:16:11 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Thu, Mar 19, 2026 at 12:57:42PM +0400, Giorgi Tchankvetadze wrote:
> > The expression 'ADC5_GEN3_CHAN_CONV_REQ | 0' is redundant because
> > OR-ing any value with zero does nothing. Remove the pointless '| 0'
> > to simplify the code.  
> 
> Have you read the comment above?
> 
> ...
> 
> >  	 * Use channel 0 by default for immediate conversion and to indicate  
> 
> ^^^
> 
> >  	 * there is an actual conversion request
> >  	 */  
> 
> I believe this is done for clarity. No need to have this patch, but I won't
> object going it in, since the comment still stays. I leave it to Jonathan,
> but I'm not going to give any tag here.
> 
Without the 0 it might appear that the comment was talking about what was
explicitly set in what was left. So ADC5_GEN3_CHAN_CONV_REQ hich would be
misleading.  So short of saying in the comment that the 0 is another field
in the same register I don't see this being conveyed as well by comments as
the code is doing.

Thanks,

Jonathan