Re: [PATCH] iio: adc: qcom-spmi-adc5-gen3: remove redundant OR with zero

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Thu, Mar 19, 2026 at 11:16:15AM +0200, Andy Shevchenko wrote:
> On Thu, Mar 19, 2026 at 12:57:42PM +0400, Giorgi Tchankvetadze wrote:
> > The expression 'ADC5_GEN3_CHAN_CONV_REQ | 0' is redundant because
> > OR-ing any value with zero does nothing. Remove the pointless '| 0'
> > to simplify the code.
> 
> Have you read the comment above?

...

> >  	 * Use channel 0 by default for immediate conversion and to indicate
> 
> ^^^
> 
> >  	 * there is an actual conversion request
> >  	 */
> 
> I believe this is done for clarity. No need to have this patch, but I won't
> object going it in, since the comment still stays. I leave it to Jonathan,
> but I'm not going to give any tag here.

FWIW to add is that I personally do stuff like this (*) from time to time
and see nothing wrong with the code that gets optimised just at compile-time
even by some dumb and old compilers.

*)
IIRC I have done something like 'foo = BAR | (0 << 20) | BAZ;' for the clarity
of the value that gets into bit 20 of the register.

-- 
With Best Regards,
Andy Shevchenko