From: Simon Horman <horms@kernel.org>
To: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,
netdev@vger.kernel.org, Marcin Szycik <marcin.szycik@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next] ice: fix allocating excessive memory in ice_create_lag_recipe()
Date: Fri, 20 Mar 2026 19:28:06 +0000 [thread overview]
Message-ID: <20260320192806.GA167844@horms.kernel.org> (raw)
In-Reply-To: <20260320050529.422444-1-aleksandr.loktionov@intel.com>
On Fri, Mar 20, 2026 at 06:05:29AM +0100, Aleksandr Loktionov wrote:
> From: Marcin Szycik <marcin.szycik@intel.com>
>
> For some reason ice_create_lag_recipe() allocates an array of 64
> struct ice_aqc_recipe_data_elem elements, while it only needs one (1).
> Fix it, while also using kzalloc_obj().
>
> Fixes: 1e0f9881ef79 ("ice: Flesh out implementation of support for SRIOV on bonded interface")
> Signed-off-by: Marcin Szycik <marcin.szycik@intel.com>
> Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
This doesn't seem to be a bug.
So think we can drop the fixes tag. And, it might be best to drop the
"fix" language from the subject and commit message.
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,
netdev@vger.kernel.org, Marcin Szycik <marcin.szycik@intel.com>
Subject: Re: [PATCH iwl-next] ice: fix allocating excessive memory in ice_create_lag_recipe()
Date: Fri, 20 Mar 2026 19:28:06 +0000 [thread overview]
Message-ID: <20260320192806.GA167844@horms.kernel.org> (raw)
In-Reply-To: <20260320050529.422444-1-aleksandr.loktionov@intel.com>
On Fri, Mar 20, 2026 at 06:05:29AM +0100, Aleksandr Loktionov wrote:
> From: Marcin Szycik <marcin.szycik@intel.com>
>
> For some reason ice_create_lag_recipe() allocates an array of 64
> struct ice_aqc_recipe_data_elem elements, while it only needs one (1).
> Fix it, while also using kzalloc_obj().
>
> Fixes: 1e0f9881ef79 ("ice: Flesh out implementation of support for SRIOV on bonded interface")
> Signed-off-by: Marcin Szycik <marcin.szycik@intel.com>
> Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
This doesn't seem to be a bug.
So think we can drop the fixes tag. And, it might be best to drop the
"fix" language from the subject and commit message.
next prev parent reply other threads:[~2026-03-20 19:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 5:05 [Intel-wired-lan] [PATCH iwl-next] ice: fix allocating excessive memory in ice_create_lag_recipe() Aleksandr Loktionov
2026-03-20 5:05 ` Aleksandr Loktionov
2026-03-20 13:20 ` [Intel-wired-lan] " Marcin Szycik
2026-03-20 19:28 ` Simon Horman [this message]
2026-03-20 19:28 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260320192806.GA167844@horms.kernel.org \
--to=horms@kernel.org \
--cc=aleksandr.loktionov@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=marcin.szycik@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.