[linux-next:master 6465/7971] drivers/block/drbd/drbd_debugfs.c:336 drbd_get_peer_request_state() warn: bitwise AND condition is false here

[linux-next:master 6465/7971] drivers/block/drbd/drbd_debugfs.c:336 drbd_get_peer_request_state() warn: bitwise AND condition is false here

[kernel test robot]

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: "Christoph Böhmwalder" <christoph.boehmwalder@linbit.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   785f0eb2f85decbe7c1ef9ae922931f0194ffc2e
commit: 945807e66a140e5ee0f919d04e15eadd4cc294be [6465/7971] drbd: remove BROKEN for DRBD
:::::: branch date: 6 hours ago
:::::: commit date: 2 days ago
config: nios2-randconfig-r073-20260321 (https://download.01.org/0day-ci/archive/20260321/202603210529.IutAxKNP-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 10.5.0
smatch: v0.5.0-9004-gb810ac53

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202603210529.IutAxKNP-lkp@intel.com/

smatch warnings:
drivers/block/drbd/drbd_debugfs.c:336 drbd_get_peer_request_state() warn: bitwise AND condition is false here

vim +336 drivers/block/drbd/drbd_debugfs.c

0c897516a4856d Christoph Böhmwalder 2025-12-16  328  
0c897516a4856d Christoph Böhmwalder 2025-12-16  329  static enum drbd_peer_request_state drbd_get_peer_request_state(struct drbd_peer_request *peer_req)
f418815f7adad4 Lars Ellenberg       2014-05-05  330  {
0c897516a4856d Christoph Böhmwalder 2025-12-16  331  	unsigned long interval_flags = peer_req->i.flags;
0c897516a4856d Christoph Böhmwalder 2025-12-16  332  
0c897516a4856d Christoph Böhmwalder 2025-12-16  333  	if (interval_flags & INTERVAL_SUBMITTED)
0c897516a4856d Christoph Böhmwalder 2025-12-16  334  		return PRS_SUBMITTED;
0c897516a4856d Christoph Böhmwalder 2025-12-16  335  
0c897516a4856d Christoph Böhmwalder 2025-12-16 @336  	if (interval_flags & INTERVAL_SENT)
0c897516a4856d Christoph Böhmwalder 2025-12-16  337  		return PRS_SENT;
0c897516a4856d Christoph Böhmwalder 2025-12-16  338  
0c897516a4856d Christoph Böhmwalder 2025-12-16  339  	return PRS_NEW;
0c897516a4856d Christoph Böhmwalder 2025-12-16  340  }
0c897516a4856d Christoph Böhmwalder 2025-12-16  341  

:::::: The code at line 336 was first introduced by commit
:::::: 0c897516a4856d55c75cfdb2b02489b0fc50bdf8 drbd: rework support modules for DRBD 9 multi-peer monitoring

:::::: TO: Christoph Böhmwalder <christoph.boehmwalder@linbit.com>
:::::: CC: Christoph Böhmwalder <christoph.boehmwalder@linbit.com>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

[linux-next:master 6465/7971] drivers/block/drbd/drbd_debugfs.c:336 drbd_get_peer_request_state() warn: bitwise AND condition is false here

[Dan Carpenter]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   785f0eb2f85decbe7c1ef9ae922931f0194ffc2e
commit: 945807e66a140e5ee0f919d04e15eadd4cc294be [6465/7971] drbd: remove BROKEN for DRBD
config: nios2-randconfig-r073-20260321 (https://download.01.org/0day-ci/archive/20260321/202603210529.IutAxKNP-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 10.5.0
smatch: v0.5.0-9004-gb810ac53

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202603210529.IutAxKNP-lkp@intel.com/

smatch warnings:
drivers/block/drbd/drbd_debugfs.c:336 drbd_get_peer_request_state() warn: bitwise AND condition is false here

vim +336 drivers/block/drbd/drbd_debugfs.c

0c897516a4856d Christoph Böhmwalder 2025-12-16  329  static enum drbd_peer_request_state drbd_get_peer_request_state(struct drbd_peer_request *peer_req)
f418815f7adad4 Lars Ellenberg       2014-05-05  330  {
0c897516a4856d Christoph Böhmwalder 2025-12-16  331  	unsigned long interval_flags = peer_req->i.flags;
0c897516a4856d Christoph Böhmwalder 2025-12-16  332  
0c897516a4856d Christoph Böhmwalder 2025-12-16  333  	if (interval_flags & INTERVAL_SUBMITTED)
0c897516a4856d Christoph Böhmwalder 2025-12-16  334  		return PRS_SUBMITTED;
0c897516a4856d Christoph Böhmwalder 2025-12-16  335  
0c897516a4856d Christoph Böhmwalder 2025-12-16 @336  	if (interval_flags & INTERVAL_SENT)

This should be if (interval_flags & BIT(INTERVAL_SENT)) or
test_bit(INTERVAL_SENT, &interval_flags).

0c897516a4856d Christoph Böhmwalder 2025-12-16  337  		return PRS_SENT;
0c897516a4856d Christoph Böhmwalder 2025-12-16  338  
0c897516a4856d Christoph Böhmwalder 2025-12-16  339  	return PRS_NEW;
0c897516a4856d Christoph Böhmwalder 2025-12-16  340  }

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki