diff for duplicates of <202603230618.haJICSqp-lkp@intel.com> diff --git a/a/1.txt b/N1/1.txt index 52ace79..5cc3ee6 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,16 +1,9 @@ -BCC: lkp@intel.com -CC: oe-kbuild-all@lists.linux.dev -CC: linux-kernel@vger.kernel.org -TO: Anna Schumaker <anna.schumaker@oracle.com> -CC: Trond Myklebust <trond.myklebust@hammerspace.com> -CC: Benjamin Coddington <bcodding@redhat.com> +[ Zero day bot is going through old warnings and resending. It looks like + a valid issue to me? -dan ] tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: ec69c9e88315c4be70c283f18c2ff130da6320b5 commit: df210d9b0951d714c1668c511ca5c8ff38cf6916 sunrpc: Add a sysfs file for adding a new xprt -date: 1 year ago -:::::: branch date: 4 hours ago -:::::: commit date: 1 year ago config: x86_64-randconfig-161-20260322 (https://download.01.org/0day-ci/archive/20260323/202603230618.haJICSqp-lkp@intel.com/config) compiler: gcc-12 (Debian 12.4.0-5) 12.4.0 smatch: v0.5.0-9004-gb810ac53 @@ -18,22 +11,14 @@ smatch: v0.5.0-9004-gb810ac53 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> -| Reported-by: Dan Carpenter <error27@gmail.com> +| Reported-by: Dan Carpenter <dan.carpenter@linaro.org> | Closes: https://lore.kernel.org/r/202603230618.haJICSqp-lkp@intel.com/ New smatch warnings: net/sunrpc/sysfs.c:343 rpc_sysfs_xprt_switch_add_xprt_store() warn: passing zero to 'PTR_ERR' -Old smatch warnings: -net/sunrpc/sysfs.c:57 rpc_sysfs_object_alloc() warn: Calling kobject_put|get with state->initialized unset from line: 51 -net/sunrpc/sysfs.c:482 rpc_sysfs_init() warn: Calling kobject_put|get with state->initialized unset from line: 473 -net/sunrpc/sysfs.c:627 rpc_sysfs_client_alloc() warn: Calling kobject_put|get with state->initialized unset from line: 620 -net/sunrpc/sysfs.c:649 rpc_sysfs_xprt_switch_alloc() warn: Calling kobject_put|get with state->initialized unset from line: 640 -net/sunrpc/sysfs.c:668 rpc_sysfs_xprt_alloc() warn: Calling kobject_put|get with state->initialized unset from line: 660 - vim +/PTR_ERR +343 net/sunrpc/sysfs.c -df210d9b0951d7 Anna Schumaker 2025-02-07 314 df210d9b0951d7 Anna Schumaker 2025-02-07 315 static ssize_t rpc_sysfs_xprt_switch_add_xprt_store(struct kobject *kobj, df210d9b0951d7 Anna Schumaker 2025-02-07 316 struct kobj_attribute *attr, df210d9b0951d7 Anna Schumaker 2025-02-07 317 const char *buf, size_t count) @@ -49,6 +34,9 @@ df210d9b0951d7 Anna Schumaker 2025-02-07 326 df210d9b0951d7 Anna Schumaker 2025-02-07 327 xprt = rpc_xprt_switch_get_main_xprt(xprt_switch); df210d9b0951d7 Anna Schumaker 2025-02-07 328 if (!xprt) df210d9b0951d7 Anna Schumaker 2025-02-07 329 goto out; + +Shouldn't we set "count = -EINVAL;" or something here? + df210d9b0951d7 Anna Schumaker 2025-02-07 330 df210d9b0951d7 Anna Schumaker 2025-02-07 331 xprt_create_args.ident = xprt->xprt_class->ident; df210d9b0951d7 Anna Schumaker 2025-02-07 332 xprt_create_args.net = xprt->xprt_net; @@ -62,6 +50,13 @@ df210d9b0951d7 Anna Schumaker 2025-02-07 339 xprt_create_args.reconnect_timeo df210d9b0951d7 Anna Schumaker 2025-02-07 340 df210d9b0951d7 Anna Schumaker 2025-02-07 341 new = xprt_create_transport(&xprt_create_args); df210d9b0951d7 Anna Schumaker 2025-02-07 342 if (IS_ERR_OR_NULL(new)) { + +This should just be if (IS_ERR(new)) { since xprt_create_transport() +can't return NULL. Returning count = 0 indicates EOF which would +be strange. + +https://staticthinking.wordpress.com/2022/08/01/mixing-error-pointers-and-null/ + df210d9b0951d7 Anna Schumaker 2025-02-07 @343 count = PTR_ERR(new); df210d9b0951d7 Anna Schumaker 2025-02-07 344 goto out_put_xprt; df210d9b0951d7 Anna Schumaker 2025-02-07 345 } @@ -75,7 +70,6 @@ df210d9b0951d7 Anna Schumaker 2025-02-07 352 out: df210d9b0951d7 Anna Schumaker 2025-02-07 353 xprt_switch_put(xprt_switch); df210d9b0951d7 Anna Schumaker 2025-02-07 354 return count; df210d9b0951d7 Anna Schumaker 2025-02-07 355 } -df210d9b0951d7 Anna Schumaker 2025-02-07 356 -- 0-DAY CI Kernel Test Service diff --git a/a/content_digest b/N1/content_digest index 23a7644..57ec4fa 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,24 +1,21 @@ - "From\0kernel test robot <lkp@intel.com>\0" + "From\0Dan Carpenter <dan.carpenter@linaro.org>\0" "Subject\0net/sunrpc/sysfs.c:343 rpc_sysfs_xprt_switch_add_xprt_store() warn: passing zero to 'PTR_ERR'\0" - "Date\0Mon, 23 Mar 2026 07:05:00 +0800\0" - "To\0oe-kbuild@lists.linux.dev\0" + "Date\0Mon, 23 Mar 2026 11:21:09 +0300\0" + "To\0oe-kbuild@lists.linux.dev" + " Anna Schumaker <anna.schumaker@oracle.com>\0" "Cc\0lkp@intel.com" - " Dan Carpenter <error27@gmail.com>\0" + oe-kbuild-all@lists.linux.dev + linux-kernel@vger.kernel.org + Trond Myklebust <trond.myklebust@hammerspace.com> + " Benjamin Coddington <bcodding@redhat.com>\0" "\00:1\0" "b\0" - "BCC: lkp@intel.com\n" - "CC: oe-kbuild-all@lists.linux.dev\n" - "CC: linux-kernel@vger.kernel.org\n" - "TO: Anna Schumaker <anna.schumaker@oracle.com>\n" - "CC: Trond Myklebust <trond.myklebust@hammerspace.com>\n" - "CC: Benjamin Coddington <bcodding@redhat.com>\n" + "[ Zero day bot is going through old warnings and resending. It looks like\n" + " a valid issue to me? -dan ]\n" "\n" "tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master\n" "head: ec69c9e88315c4be70c283f18c2ff130da6320b5\n" "commit: df210d9b0951d714c1668c511ca5c8ff38cf6916 sunrpc: Add a sysfs file for adding a new xprt\n" - "date: 1 year ago\n" - ":::::: branch date: 4 hours ago\n" - ":::::: commit date: 1 year ago\n" "config: x86_64-randconfig-161-20260322 (https://download.01.org/0day-ci/archive/20260323/202603230618.haJICSqp-lkp@intel.com/config)\n" "compiler: gcc-12 (Debian 12.4.0-5) 12.4.0\n" "smatch: v0.5.0-9004-gb810ac53\n" @@ -26,22 +23,14 @@ "If you fix the issue in a separate patch/commit (i.e. not just a new version of\n" "the same patch/commit), kindly add following tags\n" "| Reported-by: kernel test robot <lkp@intel.com>\n" - "| Reported-by: Dan Carpenter <error27@gmail.com>\n" + "| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>\n" "| Closes: https://lore.kernel.org/r/202603230618.haJICSqp-lkp@intel.com/\n" "\n" "New smatch warnings:\n" "net/sunrpc/sysfs.c:343 rpc_sysfs_xprt_switch_add_xprt_store() warn: passing zero to 'PTR_ERR'\n" "\n" - "Old smatch warnings:\n" - "net/sunrpc/sysfs.c:57 rpc_sysfs_object_alloc() warn: Calling kobject_put|get with state->initialized unset from line: 51\n" - "net/sunrpc/sysfs.c:482 rpc_sysfs_init() warn: Calling kobject_put|get with state->initialized unset from line: 473\n" - "net/sunrpc/sysfs.c:627 rpc_sysfs_client_alloc() warn: Calling kobject_put|get with state->initialized unset from line: 620\n" - "net/sunrpc/sysfs.c:649 rpc_sysfs_xprt_switch_alloc() warn: Calling kobject_put|get with state->initialized unset from line: 640\n" - "net/sunrpc/sysfs.c:668 rpc_sysfs_xprt_alloc() warn: Calling kobject_put|get with state->initialized unset from line: 660\n" - "\n" "vim +/PTR_ERR +343 net/sunrpc/sysfs.c\n" "\n" - "df210d9b0951d7 Anna Schumaker 2025-02-07 314 \n" "df210d9b0951d7 Anna Schumaker 2025-02-07 315 static ssize_t rpc_sysfs_xprt_switch_add_xprt_store(struct kobject *kobj,\n" "df210d9b0951d7 Anna Schumaker 2025-02-07 316 \t\t\t\t\t\t struct kobj_attribute *attr,\n" "df210d9b0951d7 Anna Schumaker 2025-02-07 317 \t\t\t\t\t\t const char *buf, size_t count)\n" @@ -57,6 +46,9 @@ "df210d9b0951d7 Anna Schumaker 2025-02-07 327 \txprt = rpc_xprt_switch_get_main_xprt(xprt_switch);\n" "df210d9b0951d7 Anna Schumaker 2025-02-07 328 \tif (!xprt)\n" "df210d9b0951d7 Anna Schumaker 2025-02-07 329 \t\tgoto out;\n" + "\n" + "Shouldn't we set \"count = -EINVAL;\" or something here?\n" + "\n" "df210d9b0951d7 Anna Schumaker 2025-02-07 330 \n" "df210d9b0951d7 Anna Schumaker 2025-02-07 331 \txprt_create_args.ident = xprt->xprt_class->ident;\n" "df210d9b0951d7 Anna Schumaker 2025-02-07 332 \txprt_create_args.net = xprt->xprt_net;\n" @@ -70,6 +62,13 @@ "df210d9b0951d7 Anna Schumaker 2025-02-07 340 \n" "df210d9b0951d7 Anna Schumaker 2025-02-07 341 \tnew = xprt_create_transport(&xprt_create_args);\n" "df210d9b0951d7 Anna Schumaker 2025-02-07 342 \tif (IS_ERR_OR_NULL(new)) {\n" + "\n" + "This should just be if (IS_ERR(new)) { since xprt_create_transport()\n" + "can't return NULL. Returning count = 0 indicates EOF which would\n" + "be strange.\n" + "\n" + "https://staticthinking.wordpress.com/2022/08/01/mixing-error-pointers-and-null/\n" + "\n" "df210d9b0951d7 Anna Schumaker 2025-02-07 @343 \t\tcount = PTR_ERR(new);\n" "df210d9b0951d7 Anna Schumaker 2025-02-07 344 \t\tgoto out_put_xprt;\n" "df210d9b0951d7 Anna Schumaker 2025-02-07 345 \t}\n" @@ -83,10 +82,9 @@ "df210d9b0951d7 Anna Schumaker 2025-02-07 353 \txprt_switch_put(xprt_switch);\n" "df210d9b0951d7 Anna Schumaker 2025-02-07 354 \treturn count;\n" "df210d9b0951d7 Anna Schumaker 2025-02-07 355 }\n" - "df210d9b0951d7 Anna Schumaker 2025-02-07 356 \n" "\n" "-- \n" "0-DAY CI Kernel Test Service\n" https://github.com/intel/lkp-tests/wiki -c72b61a765c0ea181369cf47e9a768243572e3ac0f605949906b2227dace8851 +92279da8f6f52fe29bc933405c2f5065ffc2187291b3b880113eb90ce23df180
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.