From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: net/sunrpc/sysfs.c:343 rpc_sysfs_xprt_switch_add_xprt_store() warn: passing zero to 'PTR_ERR'
Date: Mon, 23 Mar 2026 07:05:00 +0800 [thread overview]
Message-ID: <202603230618.haJICSqp-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Anna Schumaker <anna.schumaker@oracle.com>
CC: Trond Myklebust <trond.myklebust@hammerspace.com>
CC: Benjamin Coddington <bcodding@redhat.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: ec69c9e88315c4be70c283f18c2ff130da6320b5
commit: df210d9b0951d714c1668c511ca5c8ff38cf6916 sunrpc: Add a sysfs file for adding a new xprt
date: 1 year ago
:::::: branch date: 4 hours ago
:::::: commit date: 1 year ago
config: x86_64-randconfig-161-20260322 (https://download.01.org/0day-ci/archive/20260323/202603230618.haJICSqp-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.4.0-5) 12.4.0
smatch: v0.5.0-9004-gb810ac53
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202603230618.haJICSqp-lkp@intel.com/
New smatch warnings:
net/sunrpc/sysfs.c:343 rpc_sysfs_xprt_switch_add_xprt_store() warn: passing zero to 'PTR_ERR'
Old smatch warnings:
net/sunrpc/sysfs.c:57 rpc_sysfs_object_alloc() warn: Calling kobject_put|get with state->initialized unset from line: 51
net/sunrpc/sysfs.c:482 rpc_sysfs_init() warn: Calling kobject_put|get with state->initialized unset from line: 473
net/sunrpc/sysfs.c:627 rpc_sysfs_client_alloc() warn: Calling kobject_put|get with state->initialized unset from line: 620
net/sunrpc/sysfs.c:649 rpc_sysfs_xprt_switch_alloc() warn: Calling kobject_put|get with state->initialized unset from line: 640
net/sunrpc/sysfs.c:668 rpc_sysfs_xprt_alloc() warn: Calling kobject_put|get with state->initialized unset from line: 660
vim +/PTR_ERR +343 net/sunrpc/sysfs.c
df210d9b0951d7 Anna Schumaker 2025-02-07 314
df210d9b0951d7 Anna Schumaker 2025-02-07 315 static ssize_t rpc_sysfs_xprt_switch_add_xprt_store(struct kobject *kobj,
df210d9b0951d7 Anna Schumaker 2025-02-07 316 struct kobj_attribute *attr,
df210d9b0951d7 Anna Schumaker 2025-02-07 317 const char *buf, size_t count)
df210d9b0951d7 Anna Schumaker 2025-02-07 318 {
df210d9b0951d7 Anna Schumaker 2025-02-07 319 struct rpc_xprt_switch *xprt_switch =
df210d9b0951d7 Anna Schumaker 2025-02-07 320 rpc_sysfs_xprt_switch_kobj_get_xprt(kobj);
df210d9b0951d7 Anna Schumaker 2025-02-07 321 struct xprt_create xprt_create_args;
df210d9b0951d7 Anna Schumaker 2025-02-07 322 struct rpc_xprt *xprt, *new;
df210d9b0951d7 Anna Schumaker 2025-02-07 323
df210d9b0951d7 Anna Schumaker 2025-02-07 324 if (!xprt_switch)
df210d9b0951d7 Anna Schumaker 2025-02-07 325 return 0;
df210d9b0951d7 Anna Schumaker 2025-02-07 326
df210d9b0951d7 Anna Schumaker 2025-02-07 327 xprt = rpc_xprt_switch_get_main_xprt(xprt_switch);
df210d9b0951d7 Anna Schumaker 2025-02-07 328 if (!xprt)
df210d9b0951d7 Anna Schumaker 2025-02-07 329 goto out;
df210d9b0951d7 Anna Schumaker 2025-02-07 330
df210d9b0951d7 Anna Schumaker 2025-02-07 331 xprt_create_args.ident = xprt->xprt_class->ident;
df210d9b0951d7 Anna Schumaker 2025-02-07 332 xprt_create_args.net = xprt->xprt_net;
df210d9b0951d7 Anna Schumaker 2025-02-07 333 xprt_create_args.dstaddr = (struct sockaddr *)&xprt->addr;
df210d9b0951d7 Anna Schumaker 2025-02-07 334 xprt_create_args.addrlen = xprt->addrlen;
df210d9b0951d7 Anna Schumaker 2025-02-07 335 xprt_create_args.servername = xprt->servername;
df210d9b0951d7 Anna Schumaker 2025-02-07 336 xprt_create_args.bc_xprt = xprt->bc_xprt;
df210d9b0951d7 Anna Schumaker 2025-02-07 337 xprt_create_args.xprtsec = xprt->xprtsec;
df210d9b0951d7 Anna Schumaker 2025-02-07 338 xprt_create_args.connect_timeout = xprt->connect_timeout;
df210d9b0951d7 Anna Schumaker 2025-02-07 339 xprt_create_args.reconnect_timeout = xprt->max_reconnect_timeout;
df210d9b0951d7 Anna Schumaker 2025-02-07 340
df210d9b0951d7 Anna Schumaker 2025-02-07 341 new = xprt_create_transport(&xprt_create_args);
df210d9b0951d7 Anna Schumaker 2025-02-07 342 if (IS_ERR_OR_NULL(new)) {
df210d9b0951d7 Anna Schumaker 2025-02-07 @343 count = PTR_ERR(new);
df210d9b0951d7 Anna Schumaker 2025-02-07 344 goto out_put_xprt;
df210d9b0951d7 Anna Schumaker 2025-02-07 345 }
df210d9b0951d7 Anna Schumaker 2025-02-07 346
df210d9b0951d7 Anna Schumaker 2025-02-07 347 rpc_xprt_switch_add_xprt(xprt_switch, new);
df210d9b0951d7 Anna Schumaker 2025-02-07 348 xprt_put(new);
df210d9b0951d7 Anna Schumaker 2025-02-07 349
df210d9b0951d7 Anna Schumaker 2025-02-07 350 out_put_xprt:
df210d9b0951d7 Anna Schumaker 2025-02-07 351 xprt_put(xprt);
df210d9b0951d7 Anna Schumaker 2025-02-07 352 out:
df210d9b0951d7 Anna Schumaker 2025-02-07 353 xprt_switch_put(xprt_switch);
df210d9b0951d7 Anna Schumaker 2025-02-07 354 return count;
df210d9b0951d7 Anna Schumaker 2025-02-07 355 }
df210d9b0951d7 Anna Schumaker 2025-02-07 356
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev, Anna Schumaker <anna.schumaker@oracle.com>
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
linux-kernel@vger.kernel.org,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Benjamin Coddington <bcodding@redhat.com>
Subject: net/sunrpc/sysfs.c:343 rpc_sysfs_xprt_switch_add_xprt_store() warn: passing zero to 'PTR_ERR'
Date: Mon, 23 Mar 2026 11:21:09 +0300 [thread overview]
Message-ID: <202603230618.haJICSqp-lkp@intel.com> (raw)
Message-ID: <20260323082109.kiedqPb1L-KbyTNAXC9QZf_CGHKRs7iAET65DOI98YA@z> (raw)
[ Zero day bot is going through old warnings and resending. It looks like
a valid issue to me? -dan ]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: ec69c9e88315c4be70c283f18c2ff130da6320b5
commit: df210d9b0951d714c1668c511ca5c8ff38cf6916 sunrpc: Add a sysfs file for adding a new xprt
config: x86_64-randconfig-161-20260322 (https://download.01.org/0day-ci/archive/20260323/202603230618.haJICSqp-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.4.0-5) 12.4.0
smatch: v0.5.0-9004-gb810ac53
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202603230618.haJICSqp-lkp@intel.com/
New smatch warnings:
net/sunrpc/sysfs.c:343 rpc_sysfs_xprt_switch_add_xprt_store() warn: passing zero to 'PTR_ERR'
vim +/PTR_ERR +343 net/sunrpc/sysfs.c
df210d9b0951d7 Anna Schumaker 2025-02-07 315 static ssize_t rpc_sysfs_xprt_switch_add_xprt_store(struct kobject *kobj,
df210d9b0951d7 Anna Schumaker 2025-02-07 316 struct kobj_attribute *attr,
df210d9b0951d7 Anna Schumaker 2025-02-07 317 const char *buf, size_t count)
df210d9b0951d7 Anna Schumaker 2025-02-07 318 {
df210d9b0951d7 Anna Schumaker 2025-02-07 319 struct rpc_xprt_switch *xprt_switch =
df210d9b0951d7 Anna Schumaker 2025-02-07 320 rpc_sysfs_xprt_switch_kobj_get_xprt(kobj);
df210d9b0951d7 Anna Schumaker 2025-02-07 321 struct xprt_create xprt_create_args;
df210d9b0951d7 Anna Schumaker 2025-02-07 322 struct rpc_xprt *xprt, *new;
df210d9b0951d7 Anna Schumaker 2025-02-07 323
df210d9b0951d7 Anna Schumaker 2025-02-07 324 if (!xprt_switch)
df210d9b0951d7 Anna Schumaker 2025-02-07 325 return 0;
df210d9b0951d7 Anna Schumaker 2025-02-07 326
df210d9b0951d7 Anna Schumaker 2025-02-07 327 xprt = rpc_xprt_switch_get_main_xprt(xprt_switch);
df210d9b0951d7 Anna Schumaker 2025-02-07 328 if (!xprt)
df210d9b0951d7 Anna Schumaker 2025-02-07 329 goto out;
Shouldn't we set "count = -EINVAL;" or something here?
df210d9b0951d7 Anna Schumaker 2025-02-07 330
df210d9b0951d7 Anna Schumaker 2025-02-07 331 xprt_create_args.ident = xprt->xprt_class->ident;
df210d9b0951d7 Anna Schumaker 2025-02-07 332 xprt_create_args.net = xprt->xprt_net;
df210d9b0951d7 Anna Schumaker 2025-02-07 333 xprt_create_args.dstaddr = (struct sockaddr *)&xprt->addr;
df210d9b0951d7 Anna Schumaker 2025-02-07 334 xprt_create_args.addrlen = xprt->addrlen;
df210d9b0951d7 Anna Schumaker 2025-02-07 335 xprt_create_args.servername = xprt->servername;
df210d9b0951d7 Anna Schumaker 2025-02-07 336 xprt_create_args.bc_xprt = xprt->bc_xprt;
df210d9b0951d7 Anna Schumaker 2025-02-07 337 xprt_create_args.xprtsec = xprt->xprtsec;
df210d9b0951d7 Anna Schumaker 2025-02-07 338 xprt_create_args.connect_timeout = xprt->connect_timeout;
df210d9b0951d7 Anna Schumaker 2025-02-07 339 xprt_create_args.reconnect_timeout = xprt->max_reconnect_timeout;
df210d9b0951d7 Anna Schumaker 2025-02-07 340
df210d9b0951d7 Anna Schumaker 2025-02-07 341 new = xprt_create_transport(&xprt_create_args);
df210d9b0951d7 Anna Schumaker 2025-02-07 342 if (IS_ERR_OR_NULL(new)) {
This should just be if (IS_ERR(new)) { since xprt_create_transport()
can't return NULL. Returning count = 0 indicates EOF which would
be strange.
https://staticthinking.wordpress.com/2022/08/01/mixing-error-pointers-and-null/
df210d9b0951d7 Anna Schumaker 2025-02-07 @343 count = PTR_ERR(new);
df210d9b0951d7 Anna Schumaker 2025-02-07 344 goto out_put_xprt;
df210d9b0951d7 Anna Schumaker 2025-02-07 345 }
df210d9b0951d7 Anna Schumaker 2025-02-07 346
df210d9b0951d7 Anna Schumaker 2025-02-07 347 rpc_xprt_switch_add_xprt(xprt_switch, new);
df210d9b0951d7 Anna Schumaker 2025-02-07 348 xprt_put(new);
df210d9b0951d7 Anna Schumaker 2025-02-07 349
df210d9b0951d7 Anna Schumaker 2025-02-07 350 out_put_xprt:
df210d9b0951d7 Anna Schumaker 2025-02-07 351 xprt_put(xprt);
df210d9b0951d7 Anna Schumaker 2025-02-07 352 out:
df210d9b0951d7 Anna Schumaker 2025-02-07 353 xprt_switch_put(xprt_switch);
df210d9b0951d7 Anna Schumaker 2025-02-07 354 return count;
df210d9b0951d7 Anna Schumaker 2025-02-07 355 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2026-03-22 23:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-22 23:05 kernel test robot [this message]
2026-03-23 8:21 ` net/sunrpc/sysfs.c:343 rpc_sysfs_xprt_switch_add_xprt_store() warn: passing zero to 'PTR_ERR' Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2025-12-11 14:34 kernel test robot
2025-12-11 14:56 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202603230618.haJICSqp-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.