From: Greg KH <gregkh@linuxfoundation.org>
To: AyushMukkanwar <ayushmukkanwar@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] staging: octeon: ethernet: add pr_fmt macro
Date: Tue, 24 Mar 2026 15:28:24 +0100 [thread overview]
Message-ID: <2026032445-squad-breeching-23ed@gregkh> (raw)
In-Reply-To: <20260324133029.82764-4-ayushmukkanwar@gmail.com>
On Tue, Mar 24, 2026 at 07:00:29PM +0530, AyushMukkanwar wrote:
> Add pr_fmt macro to prefix log messages with the module
> name for easier debugging.
>
> Signed-off-by: AyushMukkanwar <ayushmukkanwar@gmail.com>
> ---
> drivers/staging/octeon/ethernet.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c
> index eadb74fc14c8..5bb8c303f88b 100644
> --- a/drivers/staging/octeon/ethernet.c
> +++ b/drivers/staging/octeon/ethernet.c
> @@ -5,6 +5,7 @@
> * Copyright (c) 2003-2007 Cavium Networks
> */
>
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> #include <linux/platform_device.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> --
> 2.53.0
>
How about working to remove the existing pr_*() calls with the proper
dev_*() and netdev_*() calls instead, so that pr_fmt() is not needed at
all? That is the more "correct" solution here.
thanks,
greg k-h
next prev parent reply other threads:[~2026-03-24 14:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 13:30 [PATCH 0/3] staging: octeon: add pr_fmt macro to ethernet drivers AyushMukkanwar
2026-03-24 13:30 ` [PATCH 1/3] staging: octeon: ethernet-mem: add pr_fmt macro AyushMukkanwar
2026-03-24 13:30 ` [PATCH 2/3] staging: octeon: ethernet-spi: " AyushMukkanwar
2026-03-24 13:30 ` [PATCH 3/3] staging: octeon: ethernet: " AyushMukkanwar
2026-03-24 14:28 ` Greg KH [this message]
2026-03-25 9:03 ` Ayush Mukkanwar
2026-03-25 9:11 ` Greg KH
2026-03-25 19:12 ` Ayush Mukkanwar
2026-03-30 15:56 ` Greg KH
2026-03-31 7:16 ` Ayush Mukkanwar
2026-03-31 8:28 ` Greg KH
2026-03-31 11:17 ` [PATCH v2 0/2] staging: octeon: replace pr_*() calls with dev_*() and netdev_*() AyushMukkanwar
2026-03-31 11:17 ` [PATCH v2 1/2] staging: octeon: ethernet-spi: replace pr_err with dev_err AyushMukkanwar
2026-04-01 10:09 ` Greg KH
2026-04-04 9:17 ` Ayush Mukkanwar
2026-04-04 9:20 ` Ayush Mukkanwar
2026-04-05 8:02 ` Greg KH
2026-03-31 11:17 ` [PATCH v2 2/2] staging: octeon: ethernet: replace pr_* with dev_* and netdev_* AyushMukkanwar
2026-04-01 1:10 ` kernel test robot
2026-04-01 9:32 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026032445-squad-breeching-23ed@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=ayushmukkanwar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.