From: Dan Carpenter <error27@gmail.com>
To: AyushMukkanwar <ayushmukkanwar@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] staging: octeon: ethernet: replace pr_* with dev_* and netdev_*
Date: Wed, 1 Apr 2026 12:32:50 +0300 [thread overview]
Message-ID: <aczmQgWONTe464um@stanley.mountain> (raw)
In-Reply-To: <20260331111757.110703-3-ayushmukkanwar@gmail.com>
On Tue, Mar 31, 2026 at 04:47:57PM +0530, AyushMukkanwar wrote:
> @@ -783,16 +797,15 @@ static int cvm_oct_probe(struct platform_device *pdev)
> dev->max_mtu = OCTEON_MAX_MTU - mtu_overhead;
>
> if (register_netdev(dev) < 0) {
> - pr_err("Failed to register ethernet device for POW\n");
> + netdev_err(dev, "Failed to register ethernet device for POW\n");
> free_netdev(dev);
> } else {
> cvm_oct_device[CVMX_PIP_NUM_INPUT_PORTS] = dev;
> - pr_info("%s: POW send group %d, receive group %d\n",
> - dev->name, pow_send_group,
> - pow_receive_group);
> + netdev_info(dev, "POW send group %d, receive group %d\n",
> + pow_send_group, pow_receive_group);
> }
Please run your patches through checkpatch.pl.
regards,
dan carpenter
prev parent reply other threads:[~2026-04-01 9:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 13:30 [PATCH 0/3] staging: octeon: add pr_fmt macro to ethernet drivers AyushMukkanwar
2026-03-24 13:30 ` [PATCH 1/3] staging: octeon: ethernet-mem: add pr_fmt macro AyushMukkanwar
2026-03-24 13:30 ` [PATCH 2/3] staging: octeon: ethernet-spi: " AyushMukkanwar
2026-03-24 13:30 ` [PATCH 3/3] staging: octeon: ethernet: " AyushMukkanwar
2026-03-24 14:28 ` Greg KH
2026-03-25 9:03 ` Ayush Mukkanwar
2026-03-25 9:11 ` Greg KH
2026-03-25 19:12 ` Ayush Mukkanwar
2026-03-30 15:56 ` Greg KH
2026-03-31 7:16 ` Ayush Mukkanwar
2026-03-31 8:28 ` Greg KH
2026-03-31 11:17 ` [PATCH v2 0/2] staging: octeon: replace pr_*() calls with dev_*() and netdev_*() AyushMukkanwar
2026-03-31 11:17 ` [PATCH v2 1/2] staging: octeon: ethernet-spi: replace pr_err with dev_err AyushMukkanwar
2026-04-01 10:09 ` Greg KH
2026-04-04 9:17 ` Ayush Mukkanwar
2026-04-04 9:20 ` Ayush Mukkanwar
2026-04-05 8:02 ` Greg KH
2026-03-31 11:17 ` [PATCH v2 2/2] staging: octeon: ethernet: replace pr_* with dev_* and netdev_* AyushMukkanwar
2026-04-01 1:10 ` kernel test robot
2026-04-01 9:32 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aczmQgWONTe464um@stanley.mountain \
--to=error27@gmail.com \
--cc=ayushmukkanwar@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.