From: Rob Herring <robh@kernel.org>
To: Michael Riesch <michael.riesch@collabora.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Frank Li <Frank.li@nxp.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Kever Yang <kever.yang@rock-chips.com>,
Collabora Kernel Team <kernel@collabora.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] media: dt-bindings: rockchip,rk3568-mipi-csi2: add rk3588 compatible
Date: Wed, 25 Mar 2026 16:06:34 -0500 [thread overview]
Message-ID: <20260325210634.GA3963190-robh@kernel.org> (raw)
In-Reply-To: <20260305-rk3588-csi2rx-v3-1-754473981f39@collabora.com>
On Wed, Mar 25, 2026 at 11:25:34AM +0100, Michael Riesch wrote:
> The RK3588 MIPI CSI-2 receivers are compatible to the ones found in
> the RK3568.
> Introduce a list of compatible variants and add the RK3588 variant to
> it.
>
> Acked-by: Rob Herring (Arm) <robh@kernel.org>
> Signed-off-by: Michael Riesch <michael.riesch@collabora.com>
> ---
> .../devicetree/bindings/media/rockchip,rk3568-mipi-csi2.yaml | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/rockchip,rk3568-mipi-csi2.yaml b/Documentation/devicetree/bindings/media/rockchip,rk3568-mipi-csi2.yaml
> index 4ac4a3b6f406..3d3b3cd78884 100644
> --- a/Documentation/devicetree/bindings/media/rockchip,rk3568-mipi-csi2.yaml
> +++ b/Documentation/devicetree/bindings/media/rockchip,rk3568-mipi-csi2.yaml
> @@ -16,9 +16,13 @@ description:
>
> properties:
> compatible:
> - enum:
> - - fsl,imx93-mipi-csi2
> - - rockchip,rk3568-mipi-csi2
> + oneOf:
> + - const: fsl,imx93-mipi-csi2
> + - const: rockchip,rk3568-mipi-csi2
These 2 should be a single enum as they were before.
> + - items:
> + - enum:
> + - rockchip,rk3588-mipi-csi2
> + - const: rockchip,rk3568-mipi-csi2
>
> reg:
> maxItems: 1
>
> --
> 2.39.5
>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Michael Riesch <michael.riesch@collabora.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Frank Li <Frank.li@nxp.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Kever Yang <kever.yang@rock-chips.com>,
Collabora Kernel Team <kernel@collabora.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] media: dt-bindings: rockchip,rk3568-mipi-csi2: add rk3588 compatible
Date: Wed, 25 Mar 2026 16:06:34 -0500 [thread overview]
Message-ID: <20260325210634.GA3963190-robh@kernel.org> (raw)
In-Reply-To: <20260305-rk3588-csi2rx-v3-1-754473981f39@collabora.com>
On Wed, Mar 25, 2026 at 11:25:34AM +0100, Michael Riesch wrote:
> The RK3588 MIPI CSI-2 receivers are compatible to the ones found in
> the RK3568.
> Introduce a list of compatible variants and add the RK3588 variant to
> it.
>
> Acked-by: Rob Herring (Arm) <robh@kernel.org>
> Signed-off-by: Michael Riesch <michael.riesch@collabora.com>
> ---
> .../devicetree/bindings/media/rockchip,rk3568-mipi-csi2.yaml | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/rockchip,rk3568-mipi-csi2.yaml b/Documentation/devicetree/bindings/media/rockchip,rk3568-mipi-csi2.yaml
> index 4ac4a3b6f406..3d3b3cd78884 100644
> --- a/Documentation/devicetree/bindings/media/rockchip,rk3568-mipi-csi2.yaml
> +++ b/Documentation/devicetree/bindings/media/rockchip,rk3568-mipi-csi2.yaml
> @@ -16,9 +16,13 @@ description:
>
> properties:
> compatible:
> - enum:
> - - fsl,imx93-mipi-csi2
> - - rockchip,rk3568-mipi-csi2
> + oneOf:
> + - const: fsl,imx93-mipi-csi2
> + - const: rockchip,rk3568-mipi-csi2
These 2 should be a single enum as they were before.
> + - items:
> + - enum:
> + - rockchip,rk3588-mipi-csi2
> + - const: rockchip,rk3568-mipi-csi2
>
> reg:
> maxItems: 1
>
> --
> 2.39.5
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2026-03-25 21:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 10:25 [PATCH v3 0/2] media: synopsys: csi2rx: add support for rk3588 variant Michael Riesch
2026-03-25 10:25 ` Michael Riesch via B4 Relay
2026-03-25 10:25 ` Michael Riesch via B4 Relay
2026-03-25 10:25 ` [PATCH v3 1/2] media: dt-bindings: rockchip,rk3568-mipi-csi2: add rk3588 compatible Michael Riesch
2026-03-25 10:25 ` Michael Riesch via B4 Relay
2026-03-25 10:25 ` Michael Riesch via B4 Relay
2026-03-25 21:06 ` Rob Herring [this message]
2026-03-25 21:06 ` Rob Herring
2026-03-25 21:34 ` Michael Riesch
2026-03-25 21:34 ` Michael Riesch
2026-03-26 19:42 ` Rob Herring
2026-03-26 19:42 ` Rob Herring
2026-03-26 22:49 ` Michael Riesch
2026-03-26 22:49 ` Michael Riesch
2026-03-25 10:25 ` [PATCH v3 2/2] arm64: dts: rockchip: add mipi csi-2 receiver nodes to rk3588 Michael Riesch
2026-03-25 10:25 ` Michael Riesch via B4 Relay
2026-03-25 10:25 ` Michael Riesch via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260325210634.GA3963190-robh@kernel.org \
--to=robh@kernel.org \
--cc=Frank.li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=kernel@collabora.com \
--cc=kever.yang@rock-chips.com \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=michael.riesch@collabora.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.