From: Greg KH <gregkh@linuxfoundation.org>
To: Carlos Llamas <cmllamas@google.com>
Cc: pedro.montes.alcalde@gmail.com, aliceryhl@google.com,
arve@android.com, christian@brauner.io,
linux-kernel@vger.kernel.org, tkjos@android.com,
kernel-team@android.com
Subject: Re: [PATCH v2] rust_binder: Downgrade startup warning to info
Date: Fri, 27 Mar 2026 07:24:35 +0100 [thread overview]
Message-ID: <2026032712-dimple-myself-24a7@gregkh> (raw)
In-Reply-To: <20260326230713.3633842-1-cmllamas@google.com>
On Thu, Mar 26, 2026 at 11:07:12PM +0000, Carlos Llamas wrote:
> From: Pedro Montes Alcalde <pedro.montes.alcalde@gmail.com>
>
> The "Loaded Rust Binder." message is logged during normal
> initialization and does not indicate an error/warning condition.
>
> Logging it as a warning creates unnecessary noise and may
> mislead developers when inspecting logs. Log it as info instead
>
> Signed-off-by: Pedro Montes Alcalde <pedro.montes.alcalde@gmail.com>
> Acked-by: Carlos Llamas <cmllamas@google.com>
> Signed-off-by: Carlos Llamas <cmllamas@google.com>
> ---
> v2: fixed patch formatting, added tags.
>
> drivers/android/binder/rust_binder_main.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/android/binder/rust_binder_main.rs b/drivers/android/binder/rust_binder_main.rs
> index aa5f2a75adb4..3907291a33c9 100644
> --- a/drivers/android/binder/rust_binder_main.rs
> +++ b/drivers/android/binder/rust_binder_main.rs
> @@ -292,7 +292,7 @@ fn init(_module: &'static kernel::ThisModule) -> Result<Self> {
> // SAFETY: The module initializer never runs twice, so we only call this once.
> unsafe { crate::context::CONTEXTS.init() };
>
> - pr_warn!("Loaded Rust Binder.");
> + pr_info!("Loaded Rust Binder.");
When drivers work properly, they are quiet, so why print anything out at
all here?
thanks,
greg k-h
next prev parent reply other threads:[~2026-03-27 6:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 22:06 [PATCH] rust_binder: Downgrade startup warning to info Pedro Montes Alcalde
2026-03-26 22:52 ` Carlos Llamas
2026-03-26 23:07 ` [PATCH v2] " Carlos Llamas
2026-03-27 6:24 ` Greg KH [this message]
2026-03-27 9:34 ` Alice Ryhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026032712-dimple-myself-24a7@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=aliceryhl@google.com \
--cc=arve@android.com \
--cc=christian@brauner.io \
--cc=cmllamas@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pedro.montes.alcalde@gmail.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.