All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mohammadfaiz Bawa <mbawa@redhat.com>
To: qemu-devel@nongnu.org
Cc: stefanb@linux.vnet.ibm.com, pierrick.bouvier@linaro.org,
	"Michael S . Tsirkin" <mst@redhat.com>,
	imammedo@redhat.com, anisinha@redhat.com,
	peter.maydell@linaro.org, shannon.zhaosl@gmail.com,
	qemu-arm@nongnu.org, mohamed@unpredictable.fr, philmd@linaro.org,
	Mohammadfaiz Bawa <mbawa@redhat.com>
Subject: [PATCH v3 0/3] hw/tpm: add PPI support to tpm-tis-device on ARM64 virt
Date: Fri, 27 Mar 2026 23:02:06 +0530	[thread overview]
Message-ID: <20260327173209.148180-1-mbawa@redhat.com> (raw)

The ARM virt machine's tpm-tis-device lacks Physical Presence Interface
(PPI) support - no _DSM, _STA, or PPI operation regions in the ACPI
namespace. This causes Windows 11 ARM64 guests to log Event ID 15
(tpm.sys) errors per boot.

This series documents the change, refactors tpm_build_ppi_acpi() to
accept a dynamic PPI base address, then wires up PPI MMIO and ACPI
on tpm-tis-sysbus via the platform bus.

Tested: aarch64 KVM, upstream QEMU, Win11 ARM64 25H2, swtpm.
Event ID 15 eliminated.

Changes in v3:
- Rebased on top of Philippe's ppi_enabled refactoring series
- Updated sysbus to set ppi_enabled on TPMIfClass instead of
  instance property
- Updated x86 CRB caller in hw/i386/acpi-build.c to pass
  ppi_base (Stefan)

Changes in v2:
- Moved tpm.rst documentation hunk from patch 3 into patch 1 (Stefan)
- Added Reviewed-by tags

Based-on: 20260317120241.16320-1-philmd@linaro.org
Signed-off-by: Mohammadfaiz Bawa <mbawa@redhat.com>

Mohammadfaiz Bawa (3):
  docs/specs/tpm: document PPI support on ARM64 virt
  hw/acpi/tpm: parameterize PPI base address in tpm_build_ppi_acpi
  hw/tpm: add PPI support to tpm-tis-device for ARM64 virt

 docs/specs/tpm.rst       | 24 ++++++++++++++++++++++++
 hw/acpi/tpm.c            |  8 ++++----
 hw/arm/virt-acpi-build.c |  9 ++++++++-
 hw/i386/acpi-build.c     |  2 +-
 hw/tpm/tpm_tis_isa.c     |  2 +-
 hw/tpm/tpm_tis_sysbus.c  | 11 +++++++++++
 include/hw/acpi/tpm.h    |  3 ++-
 7 files changed, 51 insertions(+), 8 deletions(-)


base-commit: 9eadbfc48dc892339273890709539e45d7d14219
-- 
2.53.0



             reply	other threads:[~2026-03-27 17:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-27 17:32 Mohammadfaiz Bawa [this message]
2026-03-27 17:32 ` [PATCH v3 1/3] docs/specs/tpm: document PPI support on ARM64 virt Mohammadfaiz Bawa
2026-03-27 17:32 ` [PATCH v3 2/3] hw/acpi/tpm: parameterize PPI base address in tpm_build_ppi_acpi Mohammadfaiz Bawa
2026-03-27 23:38   ` Philippe Mathieu-Daudé
2026-03-27 17:32 ` [PATCH v3 3/3] hw/tpm: add PPI support to tpm-tis-device for ARM64 virt Mohammadfaiz Bawa
2026-03-27 23:47   ` Philippe Mathieu-Daudé
2026-03-28 13:24     ` Mohammadfaiz Bawa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260327173209.148180-1-mbawa@redhat.com \
    --to=mbawa@redhat.com \
    --cc=anisinha@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=mohamed@unpredictable.fr \
    --cc=mst@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=pierrick.bouvier@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=shannon.zhaosl@gmail.com \
    --cc=stefanb@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.