All of lore.kernel.org
 help / color / mirror / Atom feed
* [merged mm-nonmm-stable] lib-inflate-fix-memory-leak-in-inflate_dynamic-on-inflate_codes-failure.patch removed from -mm tree
@ 2026-03-28  4:25 Andrew Morton
  0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2026-03-28  4:25 UTC (permalink / raw)
  To: mm-commits, akpm, objecting, akpm


The quilt patch titled
     Subject: lib/inflate: fix memory leak in inflate_dynamic() on inflate_codes() failure
has been removed from the -mm tree.  Its filename was
     lib-inflate-fix-memory-leak-in-inflate_dynamic-on-inflate_codes-failure.patch

This patch was dropped because it was merged into the mm-nonmm-stable branch
of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Josh Law <objecting@objecting.org>
Subject: lib/inflate: fix memory leak in inflate_dynamic() on inflate_codes() failure
Date: Fri, 6 Mar 2026 16:16:47 +0000

When inflate_codes() fails in inflate_dynamic(), the code jumps to the
'out' label which only frees 'll', leaking the Huffman tables 'tl' and
'td'.  Restructure the code so that the decoding tables are always freed
before reaching the 'out' label.

Link: https://lkml.kernel.org/r/20260306161647.2811874-1-objecting@objecting.org
Signed-off-by: Josh Law <objecting@objecting.org>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 lib/inflate.c |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

--- a/lib/inflate.c~lib-inflate-fix-memory-leak-in-inflate_dynamic-on-inflate_codes-failure
+++ a/lib/inflate.c
@@ -1009,10 +1009,10 @@ DEBG("dyn5d ");
 DEBG("dyn6 ");
 
   /* decompress until an end-of-block code */
-  if (inflate_codes(tl, td, bl, bd)) {
+  if (inflate_codes(tl, td, bl, bd))
     ret = 1;
-    goto out;
-  }
+  else
+    ret = 0;
 
 DEBG("dyn7 ");
 
@@ -1021,7 +1021,6 @@ DEBG("dyn7 ");
   huft_free(td);
 
   DEBG(">");
-  ret = 0;
 out:
   free(ll);
   return ret;
_

Patches currently in -mm which might be from objecting@objecting.org are

mm-damon-core-document-damos_commit_dests-failure-semantics.patch
lib-maple_tree-fix-swapped-arguments-in-mas_safe_pivot-call.patch
lib-idr-fix-ida_find_first_range-missing-ids-across-chunk-boundaries.patch


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2026-03-28  4:25 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-28  4:25 [merged mm-nonmm-stable] lib-inflate-fix-memory-leak-in-inflate_dynamic-on-inflate_codes-failure.patch removed from -mm tree Andrew Morton

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.