From: Dan Carpenter <error27@gmail.com>
To: oe-kbuild@lists.linux.dev,
Sanjay Chitroda <sanjayembeddedse@gmail.com>,
jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, kees@kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
sanjayembeddedse@gmail.com
Subject: Re: [PATCH v4 4/4] iio: ssp_sensors: reuse preallocated RX buffer for SPI transfers
Date: Sat, 28 Mar 2026 11:08:48 +0300 [thread overview]
Message-ID: <202603281105.UIsb0ZYk-lkp@intel.com> (raw)
In-Reply-To: <20260326081815.925373-5-sanjayembedded@gmail.com>
Hi Sanjay,
kernel test robot noticed the following build warnings:
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Sanjay-Chitroda/iio-ssp_sensors-cleanup-codestyle-warning/20260327-131514
base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
patch link: https://lore.kernel.org/r/20260326081815.925373-5-sanjayembedded%40gmail.com
patch subject: [PATCH v4 4/4] iio: ssp_sensors: reuse preallocated RX buffer for SPI transfers
config: x86_64-randconfig-161-20260328 (https://download.01.org/0day-ci/archive/20260328/202603281105.UIsb0ZYk-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
smatch: v0.5.0-9004-gb810ac53
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202603281105.UIsb0ZYk-lkp@intel.com/
smatch warnings:
drivers/iio/common/ssp_sensors/ssp_dev.c:523 ssp_probe() warn: missing unwind goto?
vim +523 drivers/iio/common/ssp_sensors/ssp_dev.c
50dd64d57eee8ae Karol Wrona 2015-01-28 483 static int ssp_probe(struct spi_device *spi)
50dd64d57eee8ae Karol Wrona 2015-01-28 484 {
50dd64d57eee8ae Karol Wrona 2015-01-28 485 int ret, i;
50dd64d57eee8ae Karol Wrona 2015-01-28 486 struct ssp_data *data;
50dd64d57eee8ae Karol Wrona 2015-01-28 487
50dd64d57eee8ae Karol Wrona 2015-01-28 488 data = ssp_parse_dt(&spi->dev);
50dd64d57eee8ae Karol Wrona 2015-01-28 489 if (!data) {
50dd64d57eee8ae Karol Wrona 2015-01-28 490 dev_err(&spi->dev, "Failed to find platform data\n");
50dd64d57eee8ae Karol Wrona 2015-01-28 491 return -ENODEV;
50dd64d57eee8ae Karol Wrona 2015-01-28 492 }
50dd64d57eee8ae Karol Wrona 2015-01-28 493
4c6e3dbc6b4877c Krzysztof Kozlowski 2020-09-21 494 ret = mfd_add_devices(&spi->dev, PLATFORM_DEVID_NONE,
4c6e3dbc6b4877c Krzysztof Kozlowski 2020-09-21 495 sensorhub_sensor_devs,
50dd64d57eee8ae Karol Wrona 2015-01-28 496 ARRAY_SIZE(sensorhub_sensor_devs), NULL, 0, NULL);
50dd64d57eee8ae Karol Wrona 2015-01-28 497 if (ret < 0) {
50dd64d57eee8ae Karol Wrona 2015-01-28 498 dev_err(&spi->dev, "mfd add devices fail\n");
50dd64d57eee8ae Karol Wrona 2015-01-28 499 return ret;
50dd64d57eee8ae Karol Wrona 2015-01-28 500 }
50dd64d57eee8ae Karol Wrona 2015-01-28 501
50dd64d57eee8ae Karol Wrona 2015-01-28 502 spi->mode = SPI_MODE_1;
50dd64d57eee8ae Karol Wrona 2015-01-28 503 ret = spi_setup(spi);
50dd64d57eee8ae Karol Wrona 2015-01-28 504 if (ret < 0) {
50dd64d57eee8ae Karol Wrona 2015-01-28 505 dev_err(&spi->dev, "Failed to setup spi\n");
21553258b94861a Christophe JAILLET 2025-10-10 506 goto err_setup_spi;
50dd64d57eee8ae Karol Wrona 2015-01-28 507 }
50dd64d57eee8ae Karol Wrona 2015-01-28 508
50dd64d57eee8ae Karol Wrona 2015-01-28 509 data->fw_dl_state = SSP_FW_DL_STATE_NONE;
50dd64d57eee8ae Karol Wrona 2015-01-28 510 data->spi = spi;
50dd64d57eee8ae Karol Wrona 2015-01-28 511 spi_set_drvdata(spi, data);
50dd64d57eee8ae Karol Wrona 2015-01-28 512
50dd64d57eee8ae Karol Wrona 2015-01-28 513 mutex_init(&data->comm_lock);
50dd64d57eee8ae Karol Wrona 2015-01-28 514
5981e993e348918 Sanjay Chitroda 2026-03-26 515 data->rx_buf_size = SSP_DATA_PACKET_SIZE;
5981e993e348918 Sanjay Chitroda 2026-03-26 516 data->rx_buf = devm_kzalloc(&spi->dev,
5981e993e348918 Sanjay Chitroda 2026-03-26 517 data->rx_buf_size,
5981e993e348918 Sanjay Chitroda 2026-03-26 518 GFP_KERNEL | GFP_DMA);
5981e993e348918 Sanjay Chitroda 2026-03-26 519
5981e993e348918 Sanjay Chitroda 2026-03-26 520 if (!data->rx_buf) {
5981e993e348918 Sanjay Chitroda 2026-03-26 521 dev_err(&spi->dev,
5981e993e348918 Sanjay Chitroda 2026-03-26 522 "Failed to allocate memory for rx_buf\n");
5981e993e348918 Sanjay Chitroda 2026-03-26 @523 return -ENOMEM;
Need to goto destroy_comm_lock before returning.
5981e993e348918 Sanjay Chitroda 2026-03-26 524 }
5981e993e348918 Sanjay Chitroda 2026-03-26 525
50dd64d57eee8ae Karol Wrona 2015-01-28 526 for (i = 0; i < SSP_SENSOR_MAX; ++i) {
50dd64d57eee8ae Karol Wrona 2015-01-28 527 data->delay_buf[i] = SSP_DEFAULT_POLLING_DELAY;
50dd64d57eee8ae Karol Wrona 2015-01-28 528 data->batch_latency_buf[i] = 0;
50dd64d57eee8ae Karol Wrona 2015-01-28 529 data->batch_opt_buf[i] = 0;
50dd64d57eee8ae Karol Wrona 2015-01-28 530 data->check_status[i] = SSP_INITIALIZATION_STATE;
50dd64d57eee8ae Karol Wrona 2015-01-28 531 }
50dd64d57eee8ae Karol Wrona 2015-01-28 532
50dd64d57eee8ae Karol Wrona 2015-01-28 533 data->delay_buf[SSP_BIO_HRM_LIB] = 100;
50dd64d57eee8ae Karol Wrona 2015-01-28 534
50dd64d57eee8ae Karol Wrona 2015-01-28 535 data->time_syncing = true;
50dd64d57eee8ae Karol Wrona 2015-01-28 536
50dd64d57eee8ae Karol Wrona 2015-01-28 537 mutex_init(&data->pending_lock);
50dd64d57eee8ae Karol Wrona 2015-01-28 538 INIT_LIST_HEAD(&data->pending_list);
50dd64d57eee8ae Karol Wrona 2015-01-28 539
50dd64d57eee8ae Karol Wrona 2015-01-28 540 atomic_set(&data->enable_refcount, 0);
50dd64d57eee8ae Karol Wrona 2015-01-28 541
50dd64d57eee8ae Karol Wrona 2015-01-28 542 INIT_WORK(&data->work_wdt, ssp_wdt_work_func);
50dd64d57eee8ae Karol Wrona 2015-01-28 543 INIT_DELAYED_WORK(&data->work_refresh, ssp_refresh_task);
50dd64d57eee8ae Karol Wrona 2015-01-28 544
e99e88a9d2b0674 Kees Cook 2017-10-16 545 timer_setup(&data->wdt_timer, ssp_wdt_timer_func, 0);
50dd64d57eee8ae Karol Wrona 2015-01-28 546
50dd64d57eee8ae Karol Wrona 2015-01-28 547 ret = request_threaded_irq(data->spi->irq, NULL,
50dd64d57eee8ae Karol Wrona 2015-01-28 548 ssp_irq_thread_fn,
50dd64d57eee8ae Karol Wrona 2015-01-28 549 IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
50dd64d57eee8ae Karol Wrona 2015-01-28 550 "SSP_Int", data);
50dd64d57eee8ae Karol Wrona 2015-01-28 551 if (ret < 0) {
50dd64d57eee8ae Karol Wrona 2015-01-28 552 dev_err(&spi->dev, "Irq request fail\n");
50dd64d57eee8ae Karol Wrona 2015-01-28 553 goto err_setup_irq;
50dd64d57eee8ae Karol Wrona 2015-01-28 554 }
50dd64d57eee8ae Karol Wrona 2015-01-28 555
50dd64d57eee8ae Karol Wrona 2015-01-28 556 /* Let's start with enabled one so irq balance could be ok */
50dd64d57eee8ae Karol Wrona 2015-01-28 557 data->shut_down = false;
50dd64d57eee8ae Karol Wrona 2015-01-28 558
50dd64d57eee8ae Karol Wrona 2015-01-28 559 /* just to avoid unbalanced irq set wake up */
50dd64d57eee8ae Karol Wrona 2015-01-28 560 enable_irq_wake(data->spi->irq);
50dd64d57eee8ae Karol Wrona 2015-01-28 561
50dd64d57eee8ae Karol Wrona 2015-01-28 562 data->fw_dl_state = ssp_check_fwbl(data);
50dd64d57eee8ae Karol Wrona 2015-01-28 563 if (data->fw_dl_state == SSP_FW_DL_STATE_NONE) {
50dd64d57eee8ae Karol Wrona 2015-01-28 564 ret = ssp_initialize_mcu(data);
50dd64d57eee8ae Karol Wrona 2015-01-28 565 if (ret < 0) {
50dd64d57eee8ae Karol Wrona 2015-01-28 566 dev_err(&spi->dev, "Initialize_mcu failed\n");
50dd64d57eee8ae Karol Wrona 2015-01-28 567 goto err_read_reg;
50dd64d57eee8ae Karol Wrona 2015-01-28 568 }
50dd64d57eee8ae Karol Wrona 2015-01-28 569 } else {
50dd64d57eee8ae Karol Wrona 2015-01-28 570 dev_err(&spi->dev, "Firmware version not supported\n");
50dd64d57eee8ae Karol Wrona 2015-01-28 571 ret = -EPERM;
50dd64d57eee8ae Karol Wrona 2015-01-28 572 goto err_read_reg;
50dd64d57eee8ae Karol Wrona 2015-01-28 573 }
50dd64d57eee8ae Karol Wrona 2015-01-28 574
50dd64d57eee8ae Karol Wrona 2015-01-28 575 return 0;
50dd64d57eee8ae Karol Wrona 2015-01-28 576
50dd64d57eee8ae Karol Wrona 2015-01-28 577 err_read_reg:
50dd64d57eee8ae Karol Wrona 2015-01-28 578 free_irq(data->spi->irq, data);
50dd64d57eee8ae Karol Wrona 2015-01-28 579 err_setup_irq:
50dd64d57eee8ae Karol Wrona 2015-01-28 580 mutex_destroy(&data->pending_lock);
Add a destroy_comm_lock: label here.
50dd64d57eee8ae Karol Wrona 2015-01-28 581 mutex_destroy(&data->comm_lock);
21553258b94861a Christophe JAILLET 2025-10-10 582 err_setup_spi:
21553258b94861a Christophe JAILLET 2025-10-10 583 mfd_remove_devices(&spi->dev);
50dd64d57eee8ae Karol Wrona 2015-01-28 584
50dd64d57eee8ae Karol Wrona 2015-01-28 585 dev_err(&spi->dev, "Probe failed!\n");
50dd64d57eee8ae Karol Wrona 2015-01-28 586
50dd64d57eee8ae Karol Wrona 2015-01-28 587 return ret;
50dd64d57eee8ae Karol Wrona 2015-01-28 588 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH v4 4/4] iio: ssp_sensors: reuse preallocated RX buffer for SPI transfers
Date: Sat, 28 Mar 2026 08:58:09 +0800 [thread overview]
Message-ID: <202603281105.UIsb0ZYk-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20260326081815.925373-5-sanjayembedded@gmail.com>
References: <20260326081815.925373-5-sanjayembedded@gmail.com>
TO: Sanjay Chitroda <sanjayembeddedse@gmail.com>
TO: jic23@kernel.org
TO: dlechner@baylibre.com
TO: nuno.sa@analog.com
TO: andy@kernel.org
CC: kees@kernel.org
CC: linux-iio@vger.kernel.org
CC: linux-kernel@vger.kernel.org
CC: sanjayembeddedse@gmail.com
Hi Sanjay,
kernel test robot noticed the following build warnings:
[auto build test WARNING on jic23-iio/togreg]
[also build test WARNING on linus/master v7.0-rc5 next-20260327]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Sanjay-Chitroda/iio-ssp_sensors-cleanup-codestyle-warning/20260327-131514
base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
patch link: https://lore.kernel.org/r/20260326081815.925373-5-sanjayembedded%40gmail.com
patch subject: [PATCH v4 4/4] iio: ssp_sensors: reuse preallocated RX buffer for SPI transfers
:::::: branch date: 22 hours ago
:::::: commit date: 22 hours ago
config: x86_64-randconfig-161-20260328 (https://download.01.org/0day-ci/archive/20260328/202603281105.UIsb0ZYk-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
smatch: v0.5.0-9004-gb810ac53
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202603281105.UIsb0ZYk-lkp@intel.com/
smatch warnings:
drivers/iio/common/ssp_sensors/ssp_dev.c:523 ssp_probe() warn: missing unwind goto?
vim +523 drivers/iio/common/ssp_sensors/ssp_dev.c
50dd64d57eee8ae Karol Wrona 2015-01-28 482
50dd64d57eee8ae Karol Wrona 2015-01-28 483 static int ssp_probe(struct spi_device *spi)
50dd64d57eee8ae Karol Wrona 2015-01-28 484 {
50dd64d57eee8ae Karol Wrona 2015-01-28 485 int ret, i;
50dd64d57eee8ae Karol Wrona 2015-01-28 486 struct ssp_data *data;
50dd64d57eee8ae Karol Wrona 2015-01-28 487
50dd64d57eee8ae Karol Wrona 2015-01-28 488 data = ssp_parse_dt(&spi->dev);
50dd64d57eee8ae Karol Wrona 2015-01-28 489 if (!data) {
50dd64d57eee8ae Karol Wrona 2015-01-28 490 dev_err(&spi->dev, "Failed to find platform data\n");
50dd64d57eee8ae Karol Wrona 2015-01-28 491 return -ENODEV;
50dd64d57eee8ae Karol Wrona 2015-01-28 492 }
50dd64d57eee8ae Karol Wrona 2015-01-28 493
4c6e3dbc6b4877c Krzysztof Kozlowski 2020-09-21 494 ret = mfd_add_devices(&spi->dev, PLATFORM_DEVID_NONE,
4c6e3dbc6b4877c Krzysztof Kozlowski 2020-09-21 495 sensorhub_sensor_devs,
50dd64d57eee8ae Karol Wrona 2015-01-28 496 ARRAY_SIZE(sensorhub_sensor_devs), NULL, 0, NULL);
50dd64d57eee8ae Karol Wrona 2015-01-28 497 if (ret < 0) {
50dd64d57eee8ae Karol Wrona 2015-01-28 498 dev_err(&spi->dev, "mfd add devices fail\n");
50dd64d57eee8ae Karol Wrona 2015-01-28 499 return ret;
50dd64d57eee8ae Karol Wrona 2015-01-28 500 }
50dd64d57eee8ae Karol Wrona 2015-01-28 501
50dd64d57eee8ae Karol Wrona 2015-01-28 502 spi->mode = SPI_MODE_1;
50dd64d57eee8ae Karol Wrona 2015-01-28 503 ret = spi_setup(spi);
50dd64d57eee8ae Karol Wrona 2015-01-28 504 if (ret < 0) {
50dd64d57eee8ae Karol Wrona 2015-01-28 505 dev_err(&spi->dev, "Failed to setup spi\n");
21553258b94861a Christophe JAILLET 2025-10-10 506 goto err_setup_spi;
50dd64d57eee8ae Karol Wrona 2015-01-28 507 }
50dd64d57eee8ae Karol Wrona 2015-01-28 508
50dd64d57eee8ae Karol Wrona 2015-01-28 509 data->fw_dl_state = SSP_FW_DL_STATE_NONE;
50dd64d57eee8ae Karol Wrona 2015-01-28 510 data->spi = spi;
50dd64d57eee8ae Karol Wrona 2015-01-28 511 spi_set_drvdata(spi, data);
50dd64d57eee8ae Karol Wrona 2015-01-28 512
50dd64d57eee8ae Karol Wrona 2015-01-28 513 mutex_init(&data->comm_lock);
50dd64d57eee8ae Karol Wrona 2015-01-28 514
5981e993e348918 Sanjay Chitroda 2026-03-26 515 data->rx_buf_size = SSP_DATA_PACKET_SIZE;
5981e993e348918 Sanjay Chitroda 2026-03-26 516 data->rx_buf = devm_kzalloc(&spi->dev,
5981e993e348918 Sanjay Chitroda 2026-03-26 517 data->rx_buf_size,
5981e993e348918 Sanjay Chitroda 2026-03-26 518 GFP_KERNEL | GFP_DMA);
5981e993e348918 Sanjay Chitroda 2026-03-26 519
5981e993e348918 Sanjay Chitroda 2026-03-26 520 if (!data->rx_buf) {
5981e993e348918 Sanjay Chitroda 2026-03-26 521 dev_err(&spi->dev,
5981e993e348918 Sanjay Chitroda 2026-03-26 522 "Failed to allocate memory for rx_buf\n");
5981e993e348918 Sanjay Chitroda 2026-03-26 @523 return -ENOMEM;
5981e993e348918 Sanjay Chitroda 2026-03-26 524 }
5981e993e348918 Sanjay Chitroda 2026-03-26 525
50dd64d57eee8ae Karol Wrona 2015-01-28 526 for (i = 0; i < SSP_SENSOR_MAX; ++i) {
50dd64d57eee8ae Karol Wrona 2015-01-28 527 data->delay_buf[i] = SSP_DEFAULT_POLLING_DELAY;
50dd64d57eee8ae Karol Wrona 2015-01-28 528 data->batch_latency_buf[i] = 0;
50dd64d57eee8ae Karol Wrona 2015-01-28 529 data->batch_opt_buf[i] = 0;
50dd64d57eee8ae Karol Wrona 2015-01-28 530 data->check_status[i] = SSP_INITIALIZATION_STATE;
50dd64d57eee8ae Karol Wrona 2015-01-28 531 }
50dd64d57eee8ae Karol Wrona 2015-01-28 532
50dd64d57eee8ae Karol Wrona 2015-01-28 533 data->delay_buf[SSP_BIO_HRM_LIB] = 100;
50dd64d57eee8ae Karol Wrona 2015-01-28 534
50dd64d57eee8ae Karol Wrona 2015-01-28 535 data->time_syncing = true;
50dd64d57eee8ae Karol Wrona 2015-01-28 536
50dd64d57eee8ae Karol Wrona 2015-01-28 537 mutex_init(&data->pending_lock);
50dd64d57eee8ae Karol Wrona 2015-01-28 538 INIT_LIST_HEAD(&data->pending_list);
50dd64d57eee8ae Karol Wrona 2015-01-28 539
50dd64d57eee8ae Karol Wrona 2015-01-28 540 atomic_set(&data->enable_refcount, 0);
50dd64d57eee8ae Karol Wrona 2015-01-28 541
50dd64d57eee8ae Karol Wrona 2015-01-28 542 INIT_WORK(&data->work_wdt, ssp_wdt_work_func);
50dd64d57eee8ae Karol Wrona 2015-01-28 543 INIT_DELAYED_WORK(&data->work_refresh, ssp_refresh_task);
50dd64d57eee8ae Karol Wrona 2015-01-28 544
e99e88a9d2b0674 Kees Cook 2017-10-16 545 timer_setup(&data->wdt_timer, ssp_wdt_timer_func, 0);
50dd64d57eee8ae Karol Wrona 2015-01-28 546
50dd64d57eee8ae Karol Wrona 2015-01-28 547 ret = request_threaded_irq(data->spi->irq, NULL,
50dd64d57eee8ae Karol Wrona 2015-01-28 548 ssp_irq_thread_fn,
50dd64d57eee8ae Karol Wrona 2015-01-28 549 IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
50dd64d57eee8ae Karol Wrona 2015-01-28 550 "SSP_Int", data);
50dd64d57eee8ae Karol Wrona 2015-01-28 551 if (ret < 0) {
50dd64d57eee8ae Karol Wrona 2015-01-28 552 dev_err(&spi->dev, "Irq request fail\n");
50dd64d57eee8ae Karol Wrona 2015-01-28 553 goto err_setup_irq;
50dd64d57eee8ae Karol Wrona 2015-01-28 554 }
50dd64d57eee8ae Karol Wrona 2015-01-28 555
50dd64d57eee8ae Karol Wrona 2015-01-28 556 /* Let's start with enabled one so irq balance could be ok */
50dd64d57eee8ae Karol Wrona 2015-01-28 557 data->shut_down = false;
50dd64d57eee8ae Karol Wrona 2015-01-28 558
50dd64d57eee8ae Karol Wrona 2015-01-28 559 /* just to avoid unbalanced irq set wake up */
50dd64d57eee8ae Karol Wrona 2015-01-28 560 enable_irq_wake(data->spi->irq);
50dd64d57eee8ae Karol Wrona 2015-01-28 561
50dd64d57eee8ae Karol Wrona 2015-01-28 562 data->fw_dl_state = ssp_check_fwbl(data);
50dd64d57eee8ae Karol Wrona 2015-01-28 563 if (data->fw_dl_state == SSP_FW_DL_STATE_NONE) {
50dd64d57eee8ae Karol Wrona 2015-01-28 564 ret = ssp_initialize_mcu(data);
50dd64d57eee8ae Karol Wrona 2015-01-28 565 if (ret < 0) {
50dd64d57eee8ae Karol Wrona 2015-01-28 566 dev_err(&spi->dev, "Initialize_mcu failed\n");
50dd64d57eee8ae Karol Wrona 2015-01-28 567 goto err_read_reg;
50dd64d57eee8ae Karol Wrona 2015-01-28 568 }
50dd64d57eee8ae Karol Wrona 2015-01-28 569 } else {
50dd64d57eee8ae Karol Wrona 2015-01-28 570 dev_err(&spi->dev, "Firmware version not supported\n");
50dd64d57eee8ae Karol Wrona 2015-01-28 571 ret = -EPERM;
50dd64d57eee8ae Karol Wrona 2015-01-28 572 goto err_read_reg;
50dd64d57eee8ae Karol Wrona 2015-01-28 573 }
50dd64d57eee8ae Karol Wrona 2015-01-28 574
50dd64d57eee8ae Karol Wrona 2015-01-28 575 return 0;
50dd64d57eee8ae Karol Wrona 2015-01-28 576
50dd64d57eee8ae Karol Wrona 2015-01-28 577 err_read_reg:
50dd64d57eee8ae Karol Wrona 2015-01-28 578 free_irq(data->spi->irq, data);
50dd64d57eee8ae Karol Wrona 2015-01-28 579 err_setup_irq:
50dd64d57eee8ae Karol Wrona 2015-01-28 580 mutex_destroy(&data->pending_lock);
50dd64d57eee8ae Karol Wrona 2015-01-28 581 mutex_destroy(&data->comm_lock);
21553258b94861a Christophe JAILLET 2025-10-10 582 err_setup_spi:
21553258b94861a Christophe JAILLET 2025-10-10 583 mfd_remove_devices(&spi->dev);
50dd64d57eee8ae Karol Wrona 2015-01-28 584
50dd64d57eee8ae Karol Wrona 2015-01-28 585 dev_err(&spi->dev, "Probe failed!\n");
50dd64d57eee8ae Karol Wrona 2015-01-28 586
50dd64d57eee8ae Karol Wrona 2015-01-28 587 return ret;
50dd64d57eee8ae Karol Wrona 2015-01-28 588 }
50dd64d57eee8ae Karol Wrona 2015-01-28 589
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next parent reply other threads:[~2026-03-28 8:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-28 0:58 kernel test robot [this message]
2026-03-28 8:08 ` [PATCH v4 4/4] iio: ssp_sensors: reuse preallocated RX buffer for SPI transfers Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2026-03-26 8:18 [PATCH v4 0/4] iio: ssp_sensors: improve resource cleanup with cleanup.h Sanjay Chitroda
2026-03-26 8:18 ` [PATCH v4 1/4] iio: ssp_sensors: cleanup codestyle warning Sanjay Chitroda
2026-03-26 8:18 ` [PATCH v4 2/4] iio: ssp_sensors: cleanup codestyle check Sanjay Chitroda
2026-03-26 8:18 ` [PATCH v4 3/4] iio: ssp_sensors: ssp_spi: use guard() to release mutexes Sanjay Chitroda
2026-03-26 9:22 ` Andy Shevchenko
2026-03-28 6:54 ` Sanjay Chitroda
2026-03-29 11:44 ` Andy Shevchenko
2026-03-30 16:17 ` Sanjay Chitroda
2026-04-01 3:19 ` Sanjay Chitroda
2026-03-26 8:18 ` [PATCH v4 4/4] iio: ssp_sensors: reuse preallocated RX buffer for SPI transfers Sanjay Chitroda
2026-03-26 9:25 ` Andy Shevchenko
2026-03-28 5:02 ` Sanjay Chitroda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202603281105.UIsb0ZYk-lkp@intel.com \
--to=error27@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=kees@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=nuno.sa@analog.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=sanjayembeddedse@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.