Re: [PATCH] mm/damon: validate addr_unit to be power of 2

[SeongJae Park <sj@kernel.org>]

On Sun, 29 Mar 2026 15:51:07 +0800 Liew Rui Yan <aethernet65535@gmail.com> wrote:
[...]
> Thank you for the clarification! I may understand your point now.
> 
> So, you prefer to keep the fix local to the modules that have the issue
> (addr_unit_store()), rather than changing the CORE damon_commit_ctx()?
> 
> To confirm, are you suggesting something like the first approach [1]?
> 
>     if (input_addr_unit < PAGE_SIZE && !is_power_of_2(input_addr_unit))
>         return -EINVAL;

Yes.  But the real constraint is min_region_sz, so testing it would be more
simple and effective.  E.g.,

	if (!is_power_of_2(param_ctx->min_region_sz))
		return -EINVAL;
> 
> [1] https://lore.kernel.org/20260325071709.9699-1-aethernet65535@gmail.com


Thanks,
SJ

[...]