Re: [PATCH] mm/damon: validate addr_unit to be power of 2

[SeongJae Park <sj@kernel.org>]

On Mon, 30 Mar 2026 15:17:36 +0800 Liew Rui Yan <aethernet65535@gmail.com> wrote:

> On Mon, 30 Mar 2026 14:08:51 +0800 Liew Rui Yan <aethernet65535@gmail.com> wrote:
> > [...]
> >
> >     min_region_sz = max(PAGE_SIZE / input_addr_unit, 1);
> >     if (!is_power_of_2(min_region_sz))
> >         return -EINVAL;
> 
> Apologies, I just realized I made a silly typo in the code above.

No worry.

> 
> I used PAGE_SIZE where I should have used DAMON_MIN_REGION_SZ. While
> they happen to share the same value in many cases, DAMON_MIN_REGION_SZ
> is the correct semantic constant for this context.
> 
> The code should be:
>     min_region_sz = max(DAMON_MIN_REGION_SZ / addr_unit, 1);

Yes, I agree.

> 
> Sorry for the confusion.

Again, no worry!


Thanks,
SJ

[...]