From: Christoph Hellwig <hch@lst.de>
To: Carlos Maiolino <cem@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
Damien Le Moal <dlemoal@kernel.org>,
Hans Holmberg <hans.holmberg@wdc.com>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/7] xfs: delay opening the GC zone
Date: Mon, 30 Mar 2026 15:12:57 +0200 [thread overview]
Message-ID: <20260330131257.GA546@lst.de> (raw)
In-Reply-To: <acpnEIzoiBuAJ9E9@nidhogg.toxiclabs.cc>
On Mon, Mar 30, 2026 at 02:16:53PM +0200, Carlos Maiolino wrote:
> On Mon, Mar 30, 2026 at 07:44:11AM +0200, Christoph Hellwig wrote:
> > The code that selects a new GC zone when the previous one is full also
> > handles a zone not being set at all. Make use of that to simplify the
> > logic in xfs_zone_gc_mount.
> >
>
> I might be wrong, but the subject looks misleading to me, wouldn't be
> better to just set it to something like "simplify xfs_zone_gc_mount"?
>
> Not a big deal for me, just kind of confused me while reading the patch.
> But changing subject or not, feel free to add:
Well, both would be correct, but I think the current subject is more
useful as simplify could mean anything.
next prev parent reply other threads:[~2026-03-30 13:13 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 5:44 cleanup open GC zone handling Christoph Hellwig
2026-03-30 5:44 ` [PATCH 1/7] xfs: delay opening the GC zone Christoph Hellwig
2026-03-30 12:16 ` Carlos Maiolino
2026-03-30 13:12 ` Christoph Hellwig [this message]
2026-03-30 13:20 ` Carlos Maiolino
2026-03-31 8:03 ` Hans Holmberg
2026-03-31 9:39 ` Damien Le Moal
2026-03-30 5:44 ` [PATCH 2/7] xfs: add a separate tracepoint for stealing an open zone for GC Christoph Hellwig
2026-03-30 12:19 ` Carlos Maiolino
2026-03-31 8:03 ` Hans Holmberg
2026-03-31 9:40 ` Damien Le Moal
2026-03-30 5:44 ` [PATCH 3/7] xfs: put the open zone later xfs_open_zone_put Christoph Hellwig
2026-03-30 12:24 ` Carlos Maiolino
2026-03-31 8:04 ` Hans Holmberg
2026-03-31 9:41 ` Damien Le Moal
2026-03-30 5:44 ` [PATCH 4/7] xfs: rename xfs_zone_gc_iter_next to xfs_zone_gc_iter_irec Christoph Hellwig
2026-03-30 12:26 ` Carlos Maiolino
2026-03-31 8:05 ` Hans Holmberg
2026-03-31 9:42 ` Damien Le Moal
2026-03-30 5:44 ` [PATCH 5/7] xfs: refactor GC zone selection helpers Christoph Hellwig
2026-03-30 12:28 ` Carlos Maiolino
2026-03-31 8:07 ` Hans Holmberg
2026-03-31 9:43 ` Damien Le Moal
2026-03-30 5:44 ` [PATCH 6/7] xfs: streamline GC zone selection Christoph Hellwig
2026-03-30 12:45 ` Carlos Maiolino
2026-03-31 8:22 ` Hans Holmberg
2026-03-31 9:48 ` Damien Le Moal
2026-03-30 5:44 ` [PATCH 7/7] xfs: reduce special casing for the open GC zone Christoph Hellwig
2026-03-30 13:00 ` Carlos Maiolino
2026-03-31 8:37 ` Hans Holmberg
2026-03-31 9:53 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260330131257.GA546@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=dlemoal@kernel.org \
--cc=hans.holmberg@wdc.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.