All of lore.kernel.org
 help / color / mirror / Atom feed
From: Damien Le Moal <dlemoal@kernel.org>
To: Christoph Hellwig <hch@lst.de>, Carlos Maiolino <cem@kernel.org>
Cc: Hans Holmberg <hans.holmberg@wdc.com>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 7/7] xfs: reduce special casing for the open GC zone
Date: Tue, 31 Mar 2026 18:53:26 +0900	[thread overview]
Message-ID: <ef07ed36-c2c8-4711-bbe2-c01afd6dabc6@kernel.org> (raw)
In-Reply-To: <20260330054533.3856339-8-hch@lst.de>

On 3/30/26 14:44, Christoph Hellwig wrote:
> Currently the open zone used for garbage collection is a special snow
> flake, and it that has been a bit annoying for some further zoned XFS

s/it that has/it has

> work I've been doing.
> 
> Remove the zi_open_gc_field and instead track the open GC zone in the
> zi_open_zones list together with the normal open zones, and keep an extra
> pointer and a reference of in the GC thread's data structure.  This means
> anything iterating over open zones just has to look at zi_open_zones, and
> the life time rules are consistent.  It also helps to add support for
> multiple open GC zones if we ever need them, and removes a bit of code.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>

-- 
Damien Le Moal
Western Digital Research

      parent reply	other threads:[~2026-03-31  9:53 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-30  5:44 cleanup open GC zone handling Christoph Hellwig
2026-03-30  5:44 ` [PATCH 1/7] xfs: delay opening the GC zone Christoph Hellwig
2026-03-30 12:16   ` Carlos Maiolino
2026-03-30 13:12     ` Christoph Hellwig
2026-03-30 13:20       ` Carlos Maiolino
2026-03-31  8:03   ` Hans Holmberg
2026-03-31  9:39   ` Damien Le Moal
2026-03-30  5:44 ` [PATCH 2/7] xfs: add a separate tracepoint for stealing an open zone for GC Christoph Hellwig
2026-03-30 12:19   ` Carlos Maiolino
2026-03-31  8:03   ` Hans Holmberg
2026-03-31  9:40   ` Damien Le Moal
2026-03-30  5:44 ` [PATCH 3/7] xfs: put the open zone later xfs_open_zone_put Christoph Hellwig
2026-03-30 12:24   ` Carlos Maiolino
2026-03-31  8:04   ` Hans Holmberg
2026-03-31  9:41   ` Damien Le Moal
2026-03-30  5:44 ` [PATCH 4/7] xfs: rename xfs_zone_gc_iter_next to xfs_zone_gc_iter_irec Christoph Hellwig
2026-03-30 12:26   ` Carlos Maiolino
2026-03-31  8:05   ` Hans Holmberg
2026-03-31  9:42   ` Damien Le Moal
2026-03-30  5:44 ` [PATCH 5/7] xfs: refactor GC zone selection helpers Christoph Hellwig
2026-03-30 12:28   ` Carlos Maiolino
2026-03-31  8:07   ` Hans Holmberg
2026-03-31  9:43   ` Damien Le Moal
2026-03-30  5:44 ` [PATCH 6/7] xfs: streamline GC zone selection Christoph Hellwig
2026-03-30 12:45   ` Carlos Maiolino
2026-03-31  8:22   ` Hans Holmberg
2026-03-31  9:48   ` Damien Le Moal
2026-03-30  5:44 ` [PATCH 7/7] xfs: reduce special casing for the open GC zone Christoph Hellwig
2026-03-30 13:00   ` Carlos Maiolino
2026-03-31  8:37   ` Hans Holmberg
2026-03-31  9:53   ` Damien Le Moal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ef07ed36-c2c8-4711-bbe2-c01afd6dabc6@kernel.org \
    --to=dlemoal@kernel.org \
    --cc=cem@kernel.org \
    --cc=hans.holmberg@wdc.com \
    --cc=hch@lst.de \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.