From: Jakub Kicinski <kuba@kernel.org>
To: Conor Dooley <conor@kernel.org>
Cc: netdev@vger.kernel.org, Conor Dooley <conor.dooley@microchip.com>,
kernel test robot <lkp@intel.com>,
Jiawen Wu <jiawenwu@trustnetic.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH net-next v1] net: macb: fix use of at91_default_usrio without CONFIG_OF
Date: Mon, 30 Mar 2026 15:43:13 -0700 [thread overview]
Message-ID: <20260330154313.58edbf52@kernel.org> (raw)
In-Reply-To: <20260330-overture-cactus-c8eb7b9cbecc@spud>
On Mon, 30 Mar 2026 10:02:00 +0100 Conor Dooley wrote:
> @@ -5778,7 +5778,7 @@ static int macb_probe(struct platform_device *pdev)
>
> macb_config = of_device_get_match_data(&pdev->dev);
> if (!macb_config)
> - macb_config = &default_gem_config;
> + return -EINVAL;
>
AI reviewer says this will break macb_pci.c which registers a platform
device and will never have match data?
Feel free to post the v2 without the full 24h netdev wait if needed.
--
pw-bot: cr
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Conor Dooley <conor@kernel.org>
Cc: netdev@vger.kernel.org, Conor Dooley <conor.dooley@microchip.com>,
kernel test robot <lkp@intel.com>,
Jiawen Wu <jiawenwu@trustnetic.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH net-next v1] net: macb: fix use of at91_default_usrio without CONFIG_OF
Date: Mon, 30 Mar 2026 15:43:13 -0700 [thread overview]
Message-ID: <20260330154313.58edbf52@kernel.org> (raw)
In-Reply-To: <20260330-overture-cactus-c8eb7b9cbecc@spud>
On Mon, 30 Mar 2026 10:02:00 +0100 Conor Dooley wrote:
> @@ -5778,7 +5778,7 @@ static int macb_probe(struct platform_device *pdev)
>
> macb_config = of_device_get_match_data(&pdev->dev);
> if (!macb_config)
> - macb_config = &default_gem_config;
> + return -EINVAL;
>
AI reviewer says this will break macb_pci.c which registers a platform
device and will never have match data?
Feel free to post the v2 without the full 24h netdev wait if needed.
--
pw-bot: cr
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2026-03-30 22:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 9:02 [PATCH net-next v1] net: macb: fix use of at91_default_usrio without CONFIG_OF Conor Dooley
2026-03-30 9:02 ` Conor Dooley
2026-03-30 22:43 ` Jakub Kicinski [this message]
2026-03-30 22:43 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260330154313.58edbf52@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor.dooley@microchip.com \
--cc=conor@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=jiawenwu@trustnetic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.