From: Byungchul Park <byungchul@sk.com>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: netdev@vger.kernel.org, kuba@kernel.org,
linux-kernel@vger.kernel.org, kernel_team@skhynix.com,
harry.yoo@oracle.com, david@redhat.com, willy@infradead.org,
toke@redhat.com, asml.silence@gmail.com, almasrymina@google.com,
przemyslaw.kitszel@intel.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
intel-wired-lan@lists.osuosl.org
Subject: Re: [Intel-wired-lan] [RESEND PATCH] ice: access @pp through netmem_desc instead of page
Date: Tue, 31 Mar 2026 17:11:45 +0900 [thread overview]
Message-ID: <20260331081145.GA54972@system.software.com> (raw)
In-Reply-To: <af90b7e6-de47-485d-9e1b-31612456ef9c@intel.com>
On Thu, Feb 26, 2026 at 10:13:14AM -0800, Tony Nguyen wrote:
> On 2/25/2026 5:08 PM, Byungchul Park wrote:
> > On Tue, Feb 24, 2026 at 02:35:46PM +0900, Byungchul Park wrote:
> > > To eliminate the use of struct page in page pool, the page pool users
> > > should use netmem descriptor and APIs instead.
> > >
> > > Make ice driver access @pp through netmem_desc instead of page.
> >
> > Hi Tony and Przemek,
> >
> > Is there something that I'm missing or something wrong with this? Your
> > feedback would be appreciated. Thanks!
>
> Hi Byungchul,
>
> Nothing wrong. I plan to apply it today.
Hi Tony,
Sorry bothering you but could you tell me where I can see the patch
ready in a tree, maybe yours? I failed to locate it.
This patch is very important for the project removing pp fields from
struct page to go ahead. Thanks in advance.
Byungchul
> Thanks,
> Tony
>
> > Byungchul
> >
> > > Signed-off-by: Byungchul Park <byungchul@sk.com>
> > > ---
> > > drivers/net/ethernet/intel/ice/ice_ethtool.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c
> > > index c6bc29cfb8e6..c16e54dbe75b 100644
> > > --- a/drivers/net/ethernet/intel/ice/ice_ethtool.c
> > > +++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c
> > > @@ -1251,7 +1251,7 @@ static int ice_lbtest_receive_frames(struct ice_rx_ring *rx_ring)
> > > rx_buf = &rx_ring->rx_fqes[i];
> > > page = __netmem_to_page(rx_buf->netmem);
> > > received_buf = page_address(page) + rx_buf->offset +
> > > - page->pp->p.offset;
> > > + pp_page_to_nmdesc(page)->pp->p.offset;
> > >
> > > if (ice_lbtest_check_frame(received_buf))
> > > valid_frames++;
> > > --
> > > 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Byungchul Park <byungchul@sk.com>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: netdev@vger.kernel.org, kuba@kernel.org,
linux-kernel@vger.kernel.org, kernel_team@skhynix.com,
harry.yoo@oracle.com, david@redhat.com, willy@infradead.org,
toke@redhat.com, asml.silence@gmail.com, almasrymina@google.com,
przemyslaw.kitszel@intel.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
intel-wired-lan@lists.osuosl.org
Subject: Re: [RESEND PATCH] ice: access @pp through netmem_desc instead of page
Date: Tue, 31 Mar 2026 17:11:45 +0900 [thread overview]
Message-ID: <20260331081145.GA54972@system.software.com> (raw)
In-Reply-To: <af90b7e6-de47-485d-9e1b-31612456ef9c@intel.com>
On Thu, Feb 26, 2026 at 10:13:14AM -0800, Tony Nguyen wrote:
> On 2/25/2026 5:08 PM, Byungchul Park wrote:
> > On Tue, Feb 24, 2026 at 02:35:46PM +0900, Byungchul Park wrote:
> > > To eliminate the use of struct page in page pool, the page pool users
> > > should use netmem descriptor and APIs instead.
> > >
> > > Make ice driver access @pp through netmem_desc instead of page.
> >
> > Hi Tony and Przemek,
> >
> > Is there something that I'm missing or something wrong with this? Your
> > feedback would be appreciated. Thanks!
>
> Hi Byungchul,
>
> Nothing wrong. I plan to apply it today.
Hi Tony,
Sorry bothering you but could you tell me where I can see the patch
ready in a tree, maybe yours? I failed to locate it.
This patch is very important for the project removing pp fields from
struct page to go ahead. Thanks in advance.
Byungchul
> Thanks,
> Tony
>
> > Byungchul
> >
> > > Signed-off-by: Byungchul Park <byungchul@sk.com>
> > > ---
> > > drivers/net/ethernet/intel/ice/ice_ethtool.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c
> > > index c6bc29cfb8e6..c16e54dbe75b 100644
> > > --- a/drivers/net/ethernet/intel/ice/ice_ethtool.c
> > > +++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c
> > > @@ -1251,7 +1251,7 @@ static int ice_lbtest_receive_frames(struct ice_rx_ring *rx_ring)
> > > rx_buf = &rx_ring->rx_fqes[i];
> > > page = __netmem_to_page(rx_buf->netmem);
> > > received_buf = page_address(page) + rx_buf->offset +
> > > - page->pp->p.offset;
> > > + pp_page_to_nmdesc(page)->pp->p.offset;
> > >
> > > if (ice_lbtest_check_frame(received_buf))
> > > valid_frames++;
> > > --
> > > 2.17.1
next prev parent reply other threads:[~2026-03-31 8:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 5:35 [Intel-wired-lan] [RESEND PATCH] ice: access @pp through netmem_desc instead of page Byungchul Park
2026-02-24 5:35 ` Byungchul Park
2026-02-26 1:08 ` [Intel-wired-lan] " Byungchul Park
2026-02-26 1:08 ` Byungchul Park
2026-02-26 18:13 ` [Intel-wired-lan] " Tony Nguyen
2026-02-26 18:13 ` Tony Nguyen
2026-03-31 8:11 ` Byungchul Park [this message]
2026-03-31 8:11 ` Byungchul Park
2026-03-31 17:08 ` [Intel-wired-lan] " Tony Nguyen
2026-03-31 17:08 ` Tony Nguyen
2026-04-01 3:53 ` [Intel-wired-lan] " Nowlin, Alexander
2026-04-01 3:53 ` Nowlin, Alexander
2026-04-01 4:44 ` Rinitha, SX
2026-04-01 4:44 ` Rinitha, SX
2026-04-01 7:24 ` David Hildenbrand (Arm)
2026-04-01 7:24 ` David Hildenbrand (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260331081145.GA54972@system.software.com \
--to=byungchul@sk.com \
--cc=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=asml.silence@gmail.com \
--cc=davem@davemloft.net \
--cc=david@redhat.com \
--cc=edumazet@google.com \
--cc=harry.yoo@oracle.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kernel_team@skhynix.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=toke@redhat.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.