* Re: [PATCH v1 12/16] drm/i915/buf_trans: compute LT's VS/PE Override index
@ 2026-04-01 2:50 kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2026-04-01 2:50 UTC (permalink / raw)
To: oe-kbuild
::::::
:::::: Manual check reason: "high confidence checkpatch report"
::::::
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20260331183332.1773886-13-michal.grzelak@intel.com>
References: <20260331183332.1773886-13-michal.grzelak@intel.com>
TO: "Michał Grzelak" <michal.grzelak@intel.com>
TO: intel-gfx@lists.freedesktop.org
TO: intel-xe@lists.freedesktop.org
Hi Michał,
kernel test robot noticed the following build warnings:
[auto build test WARNING on drm-i915/for-linux-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Micha-Grzelak/drm-i915-lt-align-xe3plpd-with-VS-PE-Override-layout/20260401-092928
base: https://gitlab.freedesktop.org/drm/i915/kernel.git for-linux-next
patch link: https://lore.kernel.org/r/20260331183332.1773886-13-michal.grzelak%40intel.com
patch subject: [PATCH v1 12/16] drm/i915/buf_trans: compute LT's VS/PE Override index
:::::: branch date: 80 minutes ago
:::::: commit date: 80 minutes ago
reproduce: (https://download.01.org/0day-ci/archive/20260401/202604010401.ywwXdvN6-lkp@intel.com/reproduce)
# many are suggestions rather than must-fix
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#34: FILE: drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c:1796:
+ /* FIXME need to check correct parsing & table index should
+ * this ever trigger.
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v1 00/16] VS/PE Override support
@ 2026-03-31 18:33 Michał Grzelak
2026-03-31 18:33 ` [PATCH v1 12/16] drm/i915/buf_trans: compute LT's VS/PE Override index Michał Grzelak
0 siblings, 1 reply; 3+ messages in thread
From: Michał Grzelak @ 2026-03-31 18:33 UTC (permalink / raw)
To: intel-gfx, intel-xe; +Cc: Jani Nikula, Michał Grzelak
First version the series with RFC tag being removed [1]. No changelog at
commit-level since the series transformed vastly.
Already pointed out issue with the series is that I still haven't came
up yet with better platform-depedent checks than just doing a never-
ending if-ladder. It seems especially unnecessary in case of
intel_ddi_buf_trans.c where it repeats the work that has already been
done.
Thanks for all the feedback regarding the RFC.
Booted & successfully loaded i915/xe on MTL+ and EHL.
[1] https://lore.kernel.org/intel-gfx/20260308132446.3320848-1-michal.grzelak@intel.com
BR,
Michał
Michał Grzelak (16):
drm/i915/lt: align xe3plpd with VS/PE Override layout
drm/i915/buf_trans: switch from u8 to u32
drm/i915/buf_trans: describe VS/PE Override layout
drm/i915/bios: prepare for parsing VBT #57
drm/i915/bios: parse LT's VS/PE Override Block #57
drm/i915/bios: parse Snps's VS/PE Override Block #57
drm/i915/bios: parse EHL's VS/PE Override Block #57
drm/i915/bios: support VS/PE Override per each ddi port
drm/i915/bios: print VS/PE Override port info
drm/i915/ddi: cache VS/PE struct pointer into intel_encoder
drm/i915/buf_trans: override encoder->get_buf_trans when asked
drm/i915/buf_trans: compute LT's VS/PE Override index
drm/i915/buf_trans: compute Snps's VS/PE Override index
drm/i915/buf_trans: compute EHL's VS/PE Override index
drm/i915/bios: search for VBT #57 by default
drm/i915/bios: remove VS/PE Override warning
drivers/gpu/drm/i915/display/intel_bios.c | 197 ++++++++++++++++-
drivers/gpu/drm/i915/display/intel_bios.h | 3 +
drivers/gpu/drm/i915/display/intel_ddi.c | 1 +
.../drm/i915/display/intel_ddi_buf_trans.c | 201 ++++++++++++++----
.../drm/i915/display/intel_ddi_buf_trans.h | 51 ++++-
.../gpu/drm/i915/display/intel_display_core.h | 9 +
.../drm/i915/display/intel_display_types.h | 1 +
7 files changed, 410 insertions(+), 53 deletions(-)
--
2.45.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v1 12/16] drm/i915/buf_trans: compute LT's VS/PE Override index
2026-03-31 18:33 [PATCH v1 00/16] VS/PE Override support Michał Grzelak
@ 2026-03-31 18:33 ` Michał Grzelak
2026-04-01 7:16 ` kernel test robot
0 siblings, 1 reply; 3+ messages in thread
From: Michał Grzelak @ 2026-03-31 18:33 UTC (permalink / raw)
To: intel-gfx, intel-xe; +Cc: Jani Nikula, Michał Grzelak
Add support for VS/PE Override on LT. Basing on the mode & CRTC type
found, compute the most appropriate index. Assume default index as 0.
Add FIXME & warning when EDP is requested to be overridden.
Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>
---
.../drm/i915/display/intel_ddi_buf_trans.c | 31 +++++++++++++++++--
1 file changed, 29 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c b/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c
index 06c2869d3e7a..e94b1eb84e58 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c
@@ -1786,6 +1786,25 @@ xe3plpd_get_lt_buf_trans(struct intel_encoder *encoder,
return intel_get_buf_trans(&xe3plpd_lt_trans_dp14, n_entries);
}
+static enum lt_vswing_preemph_index
+_compute_index_lt(const struct intel_crtc_state *crtc_state)
+{
+ if (intel_crtc_has_dp_encoder(crtc_state) && intel_dp_is_uhbr(crtc_state)) {
+ return XE3P_VS_PE_DP21;
+ } else if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_EDP)) {
+ /* FIXME need to check correct parsing & table index should
+ * this ever trigger.
+ */
+ drm_WARN(to_intel_display(crtc_state)->drm, 1,
+ "Ask to override EDP's vswing/preemph tables\n");
+ return XE3P_VS_PE_EDP;
+ } else {
+ return XE3P_VS_PE_DP14;
+ }
+
+ return (enum lt_vswing_preemph_index) 0;
+}
+
static union ddi_vswing_preemph_index
vswing_preemph_compute_index(struct intel_encoder *encoder,
const struct intel_crtc_state *crtc_state)
@@ -1793,8 +1812,12 @@ vswing_preemph_compute_index(struct intel_encoder *encoder,
struct intel_display *display = to_intel_display(encoder);
union ddi_vswing_preemph_index index;
- drm_dbg_kms(display->drm, "using default VS/PE Override index");
- index = (union ddi_vswing_preemph_index) 0;
+ if (HAS_LT_PHY(display)) {
+ index.lt = _compute_index_lt(crtc_state);
+ } else {
+ drm_dbg_kms(display->drm, "using default VS/PE Override index");
+ index = (union ddi_vswing_preemph_index) 0;
+ }
return index;
}
@@ -1803,6 +1826,10 @@ static int
vswing_preemph_cast_index(struct intel_display *display,
union ddi_vswing_preemph_index index)
{
+ if (HAS_LT_PHY(display)) {
+ return index.lt;
+ }
+
return 0;
}
--
2.45.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-04-01 7:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-01 2:50 [PATCH v1 12/16] drm/i915/buf_trans: compute LT's VS/PE Override index kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2026-03-31 18:33 [PATCH v1 00/16] VS/PE Override support Michał Grzelak
2026-03-31 18:33 ` [PATCH v1 12/16] drm/i915/buf_trans: compute LT's VS/PE Override index Michał Grzelak
2026-04-01 7:16 ` kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.