From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sheng Kun Chang <nothingchang@mirrorstack.ai>
Cc: jic23@kernel.org, lars@metafoo.de, Michael.Hennerich@analog.com,
dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
gregkh@linuxfoundation.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, linux-iio@vger.kernel.org,
linux-staging@lists.linux.dev, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: iio: accel: add binding for adi,adis16203
Date: Thu, 2 Apr 2026 10:45:37 +0200 [thread overview]
Message-ID: <20260402-fair-wakeful-okapi-3c6dba@quoll> (raw)
In-Reply-To: <20260401162458.88110-2-nothingchang@mirrorstack.ai>
On Wed, Apr 01, 2026 at 04:24:55PM +0000, Sheng Kun Chang wrote:
> Add devicetree binding documentation for the Analog Devices
> ADIS16203 Programmable 360 Degrees Inclinometer, in preparation
> for moving the driver out of staging.
A nit, subject: drop second/last, redundant "binding for". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
>
> Signed-off-by: Sheng Kun Chang <nothingchang@mirrorstack.ai>
> ---
> .../bindings/iio/accel/adi,adis16203.yaml | 52 +++++++++++++++++++
> 1 file changed, 52 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/accel/adi,adis16203.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adis16203.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adis16203.yaml
> new file mode 100644
> index 000000000..6c5e2833c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/accel/adi,adis16203.yaml
> @@ -0,0 +1,52 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/accel/adi,adis16203.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ADIS16203 Programmable 360 Degrees Inclinometer
> +
> +maintainers:
> + - Jonathan Cameron <jic23@kernel.org>
> +
> +description: |
> + Programmable 360 degrees inclinometer with SPI interface.
> + https://www.analog.com/en/products/adis16203.html
> +
> +properties:
> + compatible:
> + const: adi,adis16203
So everything looks exactly the same as adi,adis16201. Put it there. You
probably copied it already, because you made exactly same
issues/mistakes.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-04-02 8:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-01 16:24 [PATCH 0/3] Move adis16203 inclinometer driver out of staging Sheng Kun Chang
2026-04-01 16:24 ` [PATCH 1/3] dt-bindings: iio: accel: add binding for adi,adis16203 Sheng Kun Chang
2026-04-02 8:45 ` Krzysztof Kozlowski [this message]
2026-04-01 16:24 ` [PATCH 2/3] staging: iio: adis16203: align MODULE_LICENSE with SPDX identifier Sheng Kun Chang
2026-04-02 8:41 ` Andy Shevchenko
2026-04-02 11:27 ` Greg KH
2026-04-01 16:24 ` [PATCH 3/3] iio: accel: move adis16203 out of staging Sheng Kun Chang
2026-04-01 17:14 ` [PATCH 0/3] Move adis16203 inclinometer driver " Sheng Kun Chang
2026-04-20 17:48 ` Jonathan Cameron
2026-04-02 8:43 ` Andy Shevchenko
2026-04-04 16:29 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260402-fair-wakeful-okapi-3c6dba@quoll \
--to=krzk@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nothingchang@mirrorstack.ai \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.