All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Sheng Kun Chang <nothingchang@mirrorstack.ai>
Cc: lars@metafoo.de, Michael.Hennerich@analog.com,
	dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
	gregkh@linuxfoundation.org, linux-iio@vger.kernel.org,
	linux-staging@lists.linux.dev
Subject: Re: [PATCH 0/3] Move adis16203 inclinometer driver out of staging
Date: Mon, 20 Apr 2026 18:48:39 +0100	[thread overview]
Message-ID: <20260420184839.4ab3d9a2@jic23-huawei> (raw)
In-Reply-To: <20260401171425.89186-1-nothingchang@mirrorstack.ai>

On Wed,  1 Apr 2026 17:14:25 +0000
Sheng Kun Chang <nothingchang@mirrorstack.ai> wrote:

> Hi Jonathan,
> 
> I noticed the existing Fixme comment on the Y-axis channel and
> Gabriel's earlier attempt to fix the single-axis representation
> (v2, April 2025). That patch was not merged.
> 
> Should I address the Fixme as an additional patch in this series
> before the move, or is it fine to fix separately after moving out
> of staging?
> 
> Also, if I should fix it, would it be appropriate to pick up
> Gabriel's patch with credit, or should I write a fresh fix?

If Gabriel's patch does the job pick that up and add your SoB to
indicate you handled the patch. Looking at what I think is latest
version of that I had some feedback.  
https://lore.kernel.org/all/20250421125357.571c429e@jic23-huawei/

If you make substantial changes whilst integrating this feel
free to add a Co-developed-by tag.

Thanks,

Jonathan



> 
> Thanks,
> Sheng Kun


  reply	other threads:[~2026-04-20 17:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-01 16:24 [PATCH 0/3] Move adis16203 inclinometer driver out of staging Sheng Kun Chang
2026-04-01 16:24 ` [PATCH 1/3] dt-bindings: iio: accel: add binding for adi,adis16203 Sheng Kun Chang
2026-04-02  8:45   ` Krzysztof Kozlowski
2026-04-01 16:24 ` [PATCH 2/3] staging: iio: adis16203: align MODULE_LICENSE with SPDX identifier Sheng Kun Chang
2026-04-02  8:41   ` Andy Shevchenko
2026-04-02 11:27     ` Greg KH
2026-04-01 16:24 ` [PATCH 3/3] iio: accel: move adis16203 out of staging Sheng Kun Chang
2026-04-01 17:14 ` [PATCH 0/3] Move adis16203 inclinometer driver " Sheng Kun Chang
2026-04-20 17:48   ` Jonathan Cameron [this message]
2026-04-02  8:43 ` Andy Shevchenko
2026-04-04 16:29 ` David Lechner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260420184839.4ab3d9a2@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=nothingchang@mirrorstack.ai \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.