From: Thomas Richter <tmricht@linux.ibm.com>
To: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
linux-perf-users@vger.kernel.org, acme@kernel.org,
namhyung@kernel.org, irogers@google.com
Cc: agordeev@linux.ibm.com, gor@linux.ibm.com,
sumanthk@linux.ibm.com, hca@linux.ibm.com, japo@linux.ibm.com,
Thomas Richter <tmricht@linux.ibm.com>
Subject: [PATCH v2 1/3] perf config: Rename symbol_conf::disable_add2line_warn
Date: Thu, 2 Apr 2026 10:01:57 +0200 [thread overview]
Message-ID: <20260402080159.2028733-2-tmricht@linux.ibm.com> (raw)
In-Reply-To: <20260402080159.2028733-1-tmricht@linux.ibm.com>
Rename member symbol_conf::disable_add2line_warn to
symbol_conf::addr2line_disable_warn to make it consistent with other
addr2line_xxx constants.
No functional change.
Fixes: 257046a36750a ("perf srcline: Fallback between addr2line implementations")
Cc: Ian Rogers <irogers@google.com>
Signed-off-by: Thomas Richter <tmricht@linux.ibm.com>
Reviewed-by: Ian Rogers <irogers@google.com>
---
tools/perf/builtin-diff.c | 4 ++--
tools/perf/util/addr2line.c | 12 ++++++------
tools/perf/util/block-info.c | 2 +-
tools/perf/util/libbfd.c | 2 +-
tools/perf/util/symbol_conf.h | 2 +-
5 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
index 69069926dd0b..35d599d5c9fa 100644
--- a/tools/perf/builtin-diff.c
+++ b/tools/perf/builtin-diff.c
@@ -1352,7 +1352,7 @@ static int cycles_printf(struct hist_entry *he, struct hist_entry *pair,
/*
* Avoid printing the warning "addr2line_init failed for ..."
*/
- symbol_conf.disable_add2line_warn = true;
+ symbol_conf.addr2line_disable_warn = true;
bi = block_he->block_info;
@@ -1986,7 +1986,7 @@ int cmd_diff(int argc, const char **argv)
if (compute == COMPUTE_STREAM) {
symbol_conf.show_branchflag_count = true;
- symbol_conf.disable_add2line_warn = true;
+ symbol_conf.addr2line_disable_warn = true;
callchain_param.mode = CHAIN_FLAT;
callchain_param.key = CCKEY_SRCLINE;
callchain_param.branch_callstack = 1;
diff --git a/tools/perf/util/addr2line.c b/tools/perf/util/addr2line.c
index 31c0391fffa3..e9f084db0802 100644
--- a/tools/perf/util/addr2line.c
+++ b/tools/perf/util/addr2line.c
@@ -123,7 +123,7 @@ static enum cmd_a2l_style cmd_addr2line_configure(struct child_process *a2l, con
lines = 3;
pr_debug3("Detected binutils addr2line style\n");
} else {
- if (!symbol_conf.disable_add2line_warn) {
+ if (!symbol_conf.addr2line_disable_warn) {
char *output = NULL;
size_t output_len;
@@ -310,7 +310,7 @@ int cmd__addr2line(const char *dso_name, u64 addr,
}
if (a2l == NULL) {
- if (!symbol_conf.disable_add2line_warn)
+ if (!symbol_conf.addr2line_disable_warn)
pr_warning("%s %s: addr2line_subprocess_init failed\n", __func__, dso_name);
goto out;
}
@@ -330,7 +330,7 @@ int cmd__addr2line(const char *dso_name, u64 addr,
len = snprintf(buf, sizeof(buf), "%016"PRIx64"\n,\n", addr);
written = len > 0 ? write(a2l->in, buf, len) : -1;
if (written != len) {
- if (!symbol_conf.disable_add2line_warn)
+ if (!symbol_conf.addr2line_disable_warn)
pr_warning("%s %s: could not send request\n", __func__, dso_name);
goto out;
}
@@ -339,7 +339,7 @@ int cmd__addr2line(const char *dso_name, u64 addr,
switch (read_addr2line_record(&io, cmd_a2l_style, dso_name, addr, /*first=*/true,
&record_function, &record_filename, &record_line_nr)) {
case -1:
- if (!symbol_conf.disable_add2line_warn)
+ if (!symbol_conf.addr2line_disable_warn)
pr_warning("%s %s: could not read first record\n", __func__, dso_name);
goto out;
case 0:
@@ -355,7 +355,7 @@ int cmd__addr2line(const char *dso_name, u64 addr,
/*addr=*/1, /*first=*/true,
NULL, NULL, NULL)) {
case -1:
- if (!symbol_conf.disable_add2line_warn)
+ if (!symbol_conf.addr2line_disable_warn)
pr_warning("%s %s: could not read sentinel record\n",
__func__, dso_name);
break;
@@ -363,7 +363,7 @@ int cmd__addr2line(const char *dso_name, u64 addr,
/* The sentinel as expected. */
break;
default:
- if (!symbol_conf.disable_add2line_warn)
+ if (!symbol_conf.addr2line_disable_warn)
pr_warning("%s %s: unexpected record instead of sentinel",
__func__, dso_name);
break;
diff --git a/tools/perf/util/block-info.c b/tools/perf/util/block-info.c
index 649392bee7ed..8d3a9a661f26 100644
--- a/tools/perf/util/block-info.c
+++ b/tools/perf/util/block-info.c
@@ -303,7 +303,7 @@ static int block_range_entry(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp,
char buf[128];
char *start_line, *end_line;
- symbol_conf.disable_add2line_warn = true;
+ symbol_conf.addr2line_disable_warn = true;
start_line = map__srcline(he->ms.map, bi->sym->start + bi->start,
he->ms.sym);
diff --git a/tools/perf/util/libbfd.c b/tools/perf/util/libbfd.c
index 63ea3fb53e77..c1c12308cc12 100644
--- a/tools/perf/util/libbfd.c
+++ b/tools/perf/util/libbfd.c
@@ -233,7 +233,7 @@ int libbfd__addr2line(const char *dso_name, u64 addr,
}
if (a2l == NULL) {
- if (!symbol_conf.disable_add2line_warn)
+ if (!symbol_conf.addr2line_disable_warn)
pr_warning("addr2line_init failed for %s\n", dso_name);
return 0;
}
diff --git a/tools/perf/util/symbol_conf.h b/tools/perf/util/symbol_conf.h
index ac1b444a8fd8..21a1f096d4f0 100644
--- a/tools/perf/util/symbol_conf.h
+++ b/tools/perf/util/symbol_conf.h
@@ -51,7 +51,7 @@ struct symbol_conf {
report_block,
report_individual_block,
inline_name,
- disable_add2line_warn,
+ addr2line_disable_warn,
no_buildid_mmap2,
guest_code,
lazy_load_kernel_maps,
--
2.53.0
next prev parent reply other threads:[~2026-04-02 8:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 8:01 [PATCH v2 0/3] perf addr2line: Rework disable_add2line_warn Thomas Richter
2026-04-02 8:01 ` Thomas Richter [this message]
2026-04-03 2:08 ` [PATCH v2 1/3] perf config: Rename symbol_conf::disable_add2line_warn Namhyung Kim
2026-04-07 6:50 ` Thomas Richter
2026-04-07 7:29 ` Namhyung Kim
2026-04-02 8:01 ` [PATCH v2 2/3] perf config: Make symbol_conf::addr2line_disable_warn configurable Thomas Richter
2026-04-03 2:12 ` Namhyung Kim
2026-04-07 6:58 ` Thomas Richter
2026-04-07 7:31 ` Namhyung Kim
2026-04-02 8:01 ` [PATCH v2 3/3] perf addr2line: Remove global variable addr2line_timeout_ms Thomas Richter
2026-04-03 2:16 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260402080159.2028733-2-tmricht@linux.ibm.com \
--to=tmricht@linux.ibm.com \
--cc=acme@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=irogers@google.com \
--cc=japo@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=sumanthk@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.