All of lore.kernel.org
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Thomas Richter <tmricht@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
	linux-perf-users@vger.kernel.org, acme@kernel.org,
	irogers@google.com, agordeev@linux.ibm.com, gor@linux.ibm.com,
	sumanthk@linux.ibm.com, hca@linux.ibm.com, japo@linux.ibm.com
Subject: Re: [PATCH v2 1/3] perf config: Rename symbol_conf::disable_add2line_warn
Date: Tue, 7 Apr 2026 00:29:37 -0700	[thread overview]
Message-ID: <adSyYSyWdIl4Y3lJ@z2> (raw)
In-Reply-To: <2718d162-2c51-41ce-9830-81366a1034e2@linux.ibm.com>

On Tue, Apr 07, 2026 at 08:50:57AM +0200, Thomas Richter wrote:
> On 4/3/26 04:08, Namhyung Kim wrote:
> > On Thu, Apr 02, 2026 at 10:01:57AM +0200, Thomas Richter wrote:
> >> Rename member symbol_conf::disable_add2line_warn to
> >> symbol_conf::addr2line_disable_warn to make it consistent with other
> >> addr2line_xxx constants.
> >> No functional change.
> >>
> >> Fixes: 257046a36750a ("perf srcline: Fallback between addr2line implementations")
> > 
> > I'm not sure if we want it for typo fixes.
> > 
> > Thanks,
> > Namhyung
> > 
> > 
> 
> ...snip...
> 
> Do you want me to drop the Fixes: line or the complete rename patch?

Oh.. I meant the Fixes: line.

Thanks,
Namhyung


  reply	other threads:[~2026-04-07  7:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-02  8:01 [PATCH v2 0/3] perf addr2line: Rework disable_add2line_warn Thomas Richter
2026-04-02  8:01 ` [PATCH v2 1/3] perf config: Rename symbol_conf::disable_add2line_warn Thomas Richter
2026-04-03  2:08   ` Namhyung Kim
2026-04-07  6:50     ` Thomas Richter
2026-04-07  7:29       ` Namhyung Kim [this message]
2026-04-02  8:01 ` [PATCH v2 2/3] perf config: Make symbol_conf::addr2line_disable_warn configurable Thomas Richter
2026-04-03  2:12   ` Namhyung Kim
2026-04-07  6:58     ` Thomas Richter
2026-04-07  7:31       ` Namhyung Kim
2026-04-02  8:01 ` [PATCH v2 3/3] perf addr2line: Remove global variable addr2line_timeout_ms Thomas Richter
2026-04-03  2:16   ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adSyYSyWdIl4Y3lJ@z2 \
    --to=namhyung@kernel.org \
    --cc=acme@kernel.org \
    --cc=agordeev@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=irogers@google.com \
    --cc=japo@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=sumanthk@linux.ibm.com \
    --cc=tmricht@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.