All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,
	netdev@vger.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH iwl-next] ixgbe: clean up adaptive interrupt moderation algorithm
Date: Fri, 3 Apr 2026 14:31:52 +0100	[thread overview]
Message-ID: <20260403133152.GC113102@horms.kernel.org> (raw)
In-Reply-To: <20260327073046.134085-3-aleksandr.loktionov@intel.com>

On Fri, Mar 27, 2026 at 08:30:37AM +0100, Aleksandr Loktionov wrote:
> From: Alexander Duyck <alexander.h.duyck@intel.com>
> 
> Improve the adaptive interrupt throttle (ITR) algorithm in several ways:
> 
>  - Lower IXGBE_ITR_ADAPTIVE_MAX_USECS from 126 to 84 us (12K interrupts/s
>    minimum in bulk mode) to prevent RX starvation in full-blown bulk
>    scenarios.
> 
>  - Add ixgbe_container_is_rx() helper to split the Rx vs Tx logic in
>    ixgbe_update_itr(); Rx uses a latency-favouring path for small bursts
>    (< 24 packets and < 12112 bytes), targeting 8x throughput growth per
>    step.
> 
>  - Limit the ITR decrease in latency mode to at most 2 us per update so
>    ACK workloads do not overdrive the moderation and starve TCP senders.
> 
>  - Add IXGBE_ITR_ADAPTIVE_MASK_USECS (= IXGBE_ITR_ADAPTIVE_LATENCY - 1
>    = 0x7F) to mask out the mode flag bit 7 in ixgbe_set_itr(), replacing
>    the open-coded ~IXGBE_ITR_ADAPTIVE_LATENCY.
> 
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>

This patch is doing 4 things.
Please split it up.

...

WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,
	netdev@vger.kernel.org
Subject: Re: [PATCH iwl-next] ixgbe: clean up adaptive interrupt moderation algorithm
Date: Fri, 3 Apr 2026 14:31:52 +0100	[thread overview]
Message-ID: <20260403133152.GC113102@horms.kernel.org> (raw)
In-Reply-To: <20260327073046.134085-3-aleksandr.loktionov@intel.com>

On Fri, Mar 27, 2026 at 08:30:37AM +0100, Aleksandr Loktionov wrote:
> From: Alexander Duyck <alexander.h.duyck@intel.com>
> 
> Improve the adaptive interrupt throttle (ITR) algorithm in several ways:
> 
>  - Lower IXGBE_ITR_ADAPTIVE_MAX_USECS from 126 to 84 us (12K interrupts/s
>    minimum in bulk mode) to prevent RX starvation in full-blown bulk
>    scenarios.
> 
>  - Add ixgbe_container_is_rx() helper to split the Rx vs Tx logic in
>    ixgbe_update_itr(); Rx uses a latency-favouring path for small bursts
>    (< 24 packets and < 12112 bytes), targeting 8x throughput growth per
>    step.
> 
>  - Limit the ITR decrease in latency mode to at most 2 us per update so
>    ACK workloads do not overdrive the moderation and starve TCP senders.
> 
>  - Add IXGBE_ITR_ADAPTIVE_MASK_USECS (= IXGBE_ITR_ADAPTIVE_LATENCY - 1
>    = 0x7F) to mask out the mode flag bit 7 in ixgbe_set_itr(), replacing
>    the open-coded ~IXGBE_ITR_ADAPTIVE_LATENCY.
> 
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>

This patch is doing 4 things.
Please split it up.

...

  reply	other threads:[~2026-04-03 13:32 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-27  7:30 [Intel-wired-lan] [PATCH iwl-next] ixgbe: increase SWFW semaphore timeout for X550 FW updates Aleksandr Loktionov
2026-03-27  7:30 ` Aleksandr Loktionov
2026-03-27  7:30 ` [Intel-wired-lan] [PATCH iwl-next] ixgbe: add bounds check for debugfs register access Aleksandr Loktionov
2026-03-27  7:30   ` Aleksandr Loktionov
2026-04-03 13:36   ` [Intel-wired-lan] " Simon Horman
2026-04-03 13:36     ` Simon Horman
2026-03-27  7:30 ` [Intel-wired-lan] [PATCH iwl-next] ixgbe: clean up adaptive interrupt moderation algorithm Aleksandr Loktionov
2026-03-27  7:30   ` Aleksandr Loktionov
2026-04-03 13:31   ` Simon Horman [this message]
2026-04-03 13:31     ` Simon Horman
2026-03-27  7:30 ` [Intel-wired-lan] [PATCH iwl-next] ixgbe: remove ixgbe_ping_all_vfs() from watchdog link-up handler Aleksandr Loktionov
2026-03-27  7:30   ` Aleksandr Loktionov
2026-04-03 13:25   ` [Intel-wired-lan] " Simon Horman
2026-03-27  7:30 ` [Intel-wired-lan] [PATCH iwl-next] ixgbe: use ktime_get_real_ns() in ixgbe_ptp_reset() Aleksandr Loktionov
2026-03-27  7:30   ` Aleksandr Loktionov
2026-04-03 13:10   ` [Intel-wired-lan] " Simon Horman
2026-04-03 13:10     ` Simon Horman
2026-04-03 13:11     ` [Intel-wired-lan] " Simon Horman
2026-04-03 13:11       ` Simon Horman
2026-04-03 20:26       ` [Intel-wired-lan] " Keller, Jacob E
2026-04-03 20:26         ` Keller, Jacob E
2026-04-06 14:07         ` [Intel-wired-lan] " Simon Horman
2026-04-06 14:07           ` Simon Horman
2026-03-27  7:30 ` [Intel-wired-lan] [PATCH iwl-next] ixgbe: call ixgbe_setup_fc() before fc_enable() after NVM update Aleksandr Loktionov
2026-03-27  7:30   ` Aleksandr Loktionov
2026-04-03 13:38   ` [Intel-wired-lan] " Simon Horman
2026-04-03 13:38     ` Simon Horman
2026-04-03 13:39   ` [Intel-wired-lan] " Simon Horman
2026-03-27  7:30 ` [Intel-wired-lan] [PATCH iwl-next] ixgbe: replace GFP_ATOMIC with GFP_KERNEL in ixgbe_fcoe_ddp_setup() Aleksandr Loktionov
2026-03-27  7:30   ` Aleksandr Loktionov
2026-04-03 13:21   ` [Intel-wired-lan] " Simon Horman
2026-04-03 13:38   ` Kohei Enju
2026-03-27  7:30 ` [Intel-wired-lan] [PATCH iwl-next] ixgbe: fix cls_u32 nexthdr path returning success when no entry installed Aleksandr Loktionov
2026-03-27  7:30   ` Aleksandr Loktionov
2026-04-03 13:46   ` [Intel-wired-lan] " Simon Horman
2026-04-03 13:46     ` Simon Horman
2026-03-27  7:30 ` [Intel-wired-lan] [PATCH iwl-next] ixgbe: use int instead of u32 for error code variables Aleksandr Loktionov
2026-03-27  7:30   ` Aleksandr Loktionov
2026-04-03 13:41   ` [Intel-wired-lan] " Simon Horman
2026-04-03 13:41     ` Simon Horman
2026-03-27  7:30 ` [Intel-wired-lan] [PATCH iwl-next] ixgbe: fix integer overflow and wrong bit position in ixgbe_validate_rtr() Aleksandr Loktionov
2026-03-27  7:30   ` Aleksandr Loktionov
2026-04-03  8:41   ` [Intel-wired-lan] " Simon Horman
2026-04-03  8:41     ` Simon Horman
2026-04-03 10:00   ` [Intel-wired-lan] " David Laight
2026-04-03 10:00     ` David Laight
2026-03-27  7:30 ` [Intel-wired-lan] [PATCH iwl-next] ixgbe: fix ITR value overflow in adaptive interrupt throttling Aleksandr Loktionov
2026-03-27  7:30   ` Aleksandr Loktionov
2026-04-03 13:18   ` [Intel-wired-lan] " Simon Horman
2026-04-03 13:18     ` Simon Horman
2026-04-03 16:12     ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-04-03 16:12       ` Loktionov, Aleksandr
2026-04-06 14:06       ` [Intel-wired-lan] " Simon Horman
2026-04-06 14:06         ` Simon Horman
2026-03-27  7:30 ` [Intel-wired-lan] [PATCH iwl-next] ixgbe: extend 5 s SWFW semaphore timeout to all X550EM variants Aleksandr Loktionov
2026-03-27  7:30   ` Aleksandr Loktionov
2026-04-03 20:55   ` [Intel-wired-lan] " Tony Nguyen
2026-04-03 20:55     ` Tony Nguyen
2026-04-03 12:49 ` [Intel-wired-lan] [PATCH iwl-next] ixgbe: increase SWFW semaphore timeout for X550 FW updates Simon Horman
2026-04-03 12:49   ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260403133152.GC113102@horms.kernel.org \
    --to=horms@kernel.org \
    --cc=aleksandr.loktionov@intel.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.