From: Jakub Kicinski <kuba@kernel.org>
To: Yiqi Sun <sunyiqixm@gmail.com>
Cc: davem@davemloft.net, dsahern@kernel.org, edumazet@google.com,
pabeni@redhat.com, horms@kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net] ipv4: icmp: fix null-ptr-deref in icmp_build_probe()
Date: Fri, 3 Apr 2026 15:45:36 -0700 [thread overview]
Message-ID: <20260403154536.5decaedc@kernel.org> (raw)
In-Reply-To: <20260402070419.2291578-1-sunyiqixm@gmail.com>
On Thu, 2 Apr 2026 15:04:19 +0800 Yiqi Sun wrote:
> Instead, silently discard the request. RFC 8335 does not appear to
> define a specific response for the case where an IPv6 interface
> identifier is syntactically valid but the implementation cannot perform
> the lookup at runtime, and silently dropping the request may safer than
> misreporting "No Such Interface".
Well, my intuition would be to fall thru and make the check after the
switch handle error pointers. But I guess this version gives us the
opportunity to delete the just-added check on net->net-next merge so ok.
next prev parent reply other threads:[~2026-04-03 22:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 7:04 [PATCH net] ipv4: icmp: fix null-ptr-deref in icmp_build_probe() Yiqi Sun
2026-04-03 22:45 ` Jakub Kicinski [this message]
2026-04-03 23:10 ` patchwork-bot+netdevbpf
2026-04-06 10:48 ` [PATCH net] ipv4: icmp: fix null-ptr-deref in icmp_build_probe(): manual merge Matthieu Baerts
2026-04-06 15:36 ` Jakub Kicinski
2026-04-06 16:10 ` Matthieu Baerts
2026-04-06 16:46 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260403154536.5decaedc@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sunyiqixm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.