From: Jakub Kicinski <kuba@kernel.org>
To: Matthieu Baerts <matttbe@kernel.org>
Cc: Yiqi Sun <sunyiqixm@gmail.com>,
horms@kernel.org, netdev@vger.kernel.org, davem@davemloft.net,
dsahern@kernel.org, edumazet@google.com, pabeni@redhat.com,
Mark Brown <broonie@kernel.org>,
linux-next@vger.kernel.org
Subject: Re: [PATCH net] ipv4: icmp: fix null-ptr-deref in icmp_build_probe(): manual merge
Date: Mon, 6 Apr 2026 08:36:15 -0700 [thread overview]
Message-ID: <20260406083615.32f44e4f@kernel.org> (raw)
In-Reply-To: <c7df7e27-992e-4973-b6fb-63cdb7b40158@kernel.org>
On Mon, 6 Apr 2026 12:48:28 +0200 Matthieu Baerts wrote:
> - dev = ipv6_stub->ipv6_dev_find(net, &iio->ident.addr.ip_addr.ipv6_addr, dev);
> + dev = ipv6_dev_find(net, &iio->ident.addr.ip_addr.ipv6_addr, dev);
> + /*
> + * If IPv6 identifier lookup is unavailable, silently
> + * discard the request instead of misreporting NO_IF.
> + */
> + if (IS_ERR(dev))
> + return false;
> +
> dev_hold(dev);
> break;
See my reply, AFAIU we can just delete this new check in net-next.
next prev parent reply other threads:[~2026-04-06 15:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 7:04 [PATCH net] ipv4: icmp: fix null-ptr-deref in icmp_build_probe() Yiqi Sun
2026-04-03 22:45 ` Jakub Kicinski
2026-04-03 23:10 ` patchwork-bot+netdevbpf
2026-04-06 10:48 ` [PATCH net] ipv4: icmp: fix null-ptr-deref in icmp_build_probe(): manual merge Matthieu Baerts
2026-04-06 15:36 ` Jakub Kicinski [this message]
2026-04-06 16:10 ` Matthieu Baerts
2026-04-06 16:46 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260406083615.32f44e4f@kernel.org \
--to=kuba@kernel.org \
--cc=broonie@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=matttbe@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sunyiqixm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.