All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: "Joyful Lee" <joy@joyfullee.me>,
	platform-driver-x86@vger.kernel.org,
	"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>,
	"Hans de Goede" <hansg@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	linux-pci@vger.kernel.org, "Bjorn Helgaas" <bhelgaas@google.com>,
	linux-acpi@vger.kernel.org,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	linux-kernel@vger.kernel.org, "Lukas Wunner" <lukas@wunner.de>
Subject: Re: [BUG] ASUS ProArt PX13 HN7306WU: amd_pmc s2idle S0ix corrupts AMD 1022:150b root port, NVIDIA dGPU returns header type 7f
Date: Fri, 3 Apr 2026 14:10:20 -0500	[thread overview]
Message-ID: <20260403191020.GA348076@bhelgaas> (raw)
In-Reply-To: <a24fd871-2589-46eb-8117-ec8cfa5f720d@amd.com>

On Fri, Apr 03, 2026 at 01:41:04PM -0500, Mario Limonciello wrote:
> On 4/3/26 1:04 PM, Bjorn Helgaas wrote:
> ...

> > But as you point out, it doesn't close the issue.  Somebody else is
> > going to trip over the same issue.  Most likely they will not report
> > it and have no idea how to fix it.  Even if they do report it, we'll
> > have to go through this whole debug process again.
> > 
> > The kernel should work correctly (possibly with increased power
> > consumption or some other non-functional issue) regardless of whether
> > CONFIG_HOTPLUG_PCI_PCIE is enabled.
> 
> I do hope as part of this we can reconsider why CONFIG_HOTPLUG_PCI_PCIE
> isn't part of the defconfig in the first place.
> 
> defconfig doesn't work on any hardware of mine by default and it's too much
> work to figure out what to add to it.  So I always start at distro configs
> and peel back for my own use.
> 
> But, if we could actually make defconfig *usable* for general purpose kernel
> users maybe more people would use it.
> 
> > How can we make Linux smart enough that if we're lacking pciehp or
> > whatever is necessary, we automatically avoid s2idle or S0ix or
> > whatever causes this problem?
> 
> I suppose we /could/ have CONFIG_AMD_PMC depend on CONFIG_HOTPLUG_PCI_PCIE
> but it feels like using super glue on a wound until we know why this
> happens.

IMO making CONFIG_HOTPLUG_PCI_PCIE part of defconfig is definitely not
a solution.  It just makes it slightly less likely that people will
hit this.

Making CONFIG_AMD_PMC depend on CONFIG_HOTPLUG_PCI_PCIE might be a
little better, but I agree that it's pretty janky to do that without
understanding the mechanism.  Seems like we have a good chance to
understand this better, so I'm not ready to paper over it yet.

  reply	other threads:[~2026-04-03 19:10 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-02 18:49 [BUG] ASUS ProArt PX13 HN7306WU: amd_pmc s2idle S0ix corrupts AMD 1022:150b root port, NVIDIA dGPU returns header type 7f Joyful Lee
2026-04-02 19:58 ` Mario Limonciello
2026-04-02 20:59   ` Joyful Lee
2026-04-02 21:14     ` Mario Limonciello
2026-04-02 21:32       ` Joyful Lee
2026-04-03 13:23         ` Mario Limonciello
2026-04-03 14:11           ` Joyful Lee
2026-04-03 14:24             ` Mario Limonciello
2026-04-03 16:19               ` Joyful Lee
2026-04-03 16:48                 ` Mario Limonciello
2026-04-03 18:04                   ` Bjorn Helgaas
2026-04-03 18:41                     ` Mario Limonciello
2026-04-03 19:10                       ` Bjorn Helgaas [this message]
2026-04-03 19:11                         ` Mario Limonciello
2026-04-03 19:07                     ` Joyful Lee
2026-04-03 20:02                       ` Mario Limonciello
2026-04-03 20:47                         ` Joyful Lee
2026-04-03 21:05                           ` Mario Limonciello
2026-04-03 21:28                             ` Mario Limonciello
2026-04-05  7:16                               ` Lukas Wunner
2026-04-05  7:05                     ` Lukas Wunner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260403191020.GA348076@bhelgaas \
    --to=helgaas@kernel.org \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=bhelgaas@google.com \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=joy@joyfullee.me \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=mario.limonciello@amd.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.