All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: "Joyful Lee" <joy@joyfullee.me>,
	"Bjorn Helgaas" <helgaas@kernel.org>,
	platform-driver-x86@vger.kernel.org,
	"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>,
	"Hans de Goede" <hansg@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	linux-pci@vger.kernel.org, "Bjorn Helgaas" <bhelgaas@google.com>,
	linux-acpi@vger.kernel.org,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [BUG] ASUS ProArt PX13 HN7306WU: amd_pmc s2idle S0ix corrupts AMD 1022:150b root port, NVIDIA dGPU returns header type 7f
Date: Sun, 5 Apr 2026 09:16:59 +0200	[thread overview]
Message-ID: <adIMa_yVLMJZvdLq@wunner.de> (raw)
In-Reply-To: <adc13acd-4a2b-4b64-9dcc-c622d8b9f3cf@amd.com>

On Fri, Apr 03, 2026 at 04:28:23PM -0500, Mario Limonciello wrote:
> On 4/3/26 4:05 PM, Mario Limonciello wrote:
> > Thanks - the most obvious observation is what you already noted -
> > without hotplug support the root port skips PM all together.
> > 
> > [24.575705] pcieport 0000:00:01.2: PCI PM: Suspend power state: D0
> > [24.575707] pcieport 0000:00:01.2: PCI PM: Skipped
> > [24.575709] pcieport 0000:00:01.1: PCI PM: Suspend power state: D0
> > [24.575709] pcieport 0000:00:01.1: PCI PM: Skipped
> > 
> > vs
> > 
> > [29.279987] pcieport 0000:00:01.1: power state changed by ACPI to D3cold
> > [29.279991] pcieport 0000:00:01.1: PCI PM: Suspend power state: D3cold
> > [29.280214] pcieport 0000:00:01.2: power state changed by ACPI to D3cold
> > [29.280219] pcieport 0000:00:01.2: PCI PM: Suspend power state: D3cold

Those are different Root Ports than 0000:00:03.1.

> > The hotplug support seems to apply to 3 ports.
[...]
> >    0000:00:03.1 (Bus c4):
> >    - Slot Capabilities: 0x000425e0
> >    - Flags: HotPlug+ Surprise+ LLActRep+
[...]
> OK - so the issue comes from acpi_pci_bridge_d3() which is called from
> platform_pci_bridge_d3():
> 
> 	if (acpi_pci_disabled || !dev->is_pciehp)
> 		return false;

Also not relevant, the is_pciehp flag is true because of the
set HotPlug+ bit in the Slot Capabilities Register, so the check
doesn't evaluate to true and the function doesn't return here.

Thanks,

Lukas

  reply	other threads:[~2026-04-05  7:17 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-02 18:49 [BUG] ASUS ProArt PX13 HN7306WU: amd_pmc s2idle S0ix corrupts AMD 1022:150b root port, NVIDIA dGPU returns header type 7f Joyful Lee
2026-04-02 19:58 ` Mario Limonciello
2026-04-02 20:59   ` Joyful Lee
2026-04-02 21:14     ` Mario Limonciello
2026-04-02 21:32       ` Joyful Lee
2026-04-03 13:23         ` Mario Limonciello
2026-04-03 14:11           ` Joyful Lee
2026-04-03 14:24             ` Mario Limonciello
2026-04-03 16:19               ` Joyful Lee
2026-04-03 16:48                 ` Mario Limonciello
2026-04-03 18:04                   ` Bjorn Helgaas
2026-04-03 18:41                     ` Mario Limonciello
2026-04-03 19:10                       ` Bjorn Helgaas
2026-04-03 19:11                         ` Mario Limonciello
2026-04-03 19:07                     ` Joyful Lee
2026-04-03 20:02                       ` Mario Limonciello
2026-04-03 20:47                         ` Joyful Lee
2026-04-03 21:05                           ` Mario Limonciello
2026-04-03 21:28                             ` Mario Limonciello
2026-04-05  7:16                               ` Lukas Wunner [this message]
2026-04-05  7:05                     ` Lukas Wunner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adIMa_yVLMJZvdLq@wunner.de \
    --to=lukas@wunner.de \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=bhelgaas@google.com \
    --cc=hansg@kernel.org \
    --cc=helgaas@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=joy@joyfullee.me \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.