All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] scsi: iscsi_tcp: Remove unneeded selections of CRYPTO and CRYPTO_MD5
@ 2026-04-04 20:30 Eric Biggers
  2026-04-09  1:43 ` Martin K. Petersen
  2026-04-14  2:19 ` Martin K. Petersen
  0 siblings, 2 replies; 3+ messages in thread
From: Eric Biggers @ 2026-04-04 20:30 UTC (permalink / raw)
  To: linux-scsi, James E.J. Bottomley, Martin K. Petersen
  Cc: linux-kernel, Eric Biggers

As far as I can tell, CRYPTO_MD5 has been unnecessary here ever since it
was added by commit c899e4ef96f0 ("[SCSI] open-iscsi/linux-iscsi-5
Initiator: Kconfig update") in 2005.

CRYPTO was needed until commit 92186c1455a2 ("scsi: iscsi_tcp: Switch to
using the crc32c library"), but is no longer needed.

Remove these unnecessary kconfig selections.

Signed-off-by: Eric Biggers <ebiggers@kernel.org>
---

This patch is targeting the scsi tree

 drivers/scsi/Kconfig | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index f811ce473c2ab..fc8e8b0bfa391 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -302,12 +302,10 @@ if SCSI_LOWLEVEL && SCSI
 
 config ISCSI_TCP
 	tristate "iSCSI Initiator over TCP/IP"
 	depends on SCSI && INET
 	select CRC32
-	select CRYPTO
-	select CRYPTO_MD5
 	select SCSI_ISCSI_ATTRS
 	help
 	 The iSCSI Driver provides a host with the ability to access storage
 	 through an IP network. The driver uses the iSCSI protocol to transport
 	 SCSI requests and responses over a TCP/IP network between the host

base-commit: 2febe6e6ee6e34c7754eff3c4d81aa7b0dcb7979
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] scsi: iscsi_tcp: Remove unneeded selections of CRYPTO and CRYPTO_MD5
  2026-04-04 20:30 [PATCH] scsi: iscsi_tcp: Remove unneeded selections of CRYPTO and CRYPTO_MD5 Eric Biggers
@ 2026-04-09  1:43 ` Martin K. Petersen
  2026-04-14  2:19 ` Martin K. Petersen
  1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2026-04-09  1:43 UTC (permalink / raw)
  To: Eric Biggers
  Cc: linux-scsi, James E.J. Bottomley, Martin K. Petersen,
	linux-kernel


Eric,

> As far as I can tell, CRYPTO_MD5 has been unnecessary here ever since
> it was added by commit c899e4ef96f0 ("[SCSI] open-iscsi/linux-iscsi-5
> Initiator: Kconfig update") in 2005.

Applied to 7.1/scsi-staging, thanks!

-- 
Martin K. Petersen

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] scsi: iscsi_tcp: Remove unneeded selections of CRYPTO and CRYPTO_MD5
  2026-04-04 20:30 [PATCH] scsi: iscsi_tcp: Remove unneeded selections of CRYPTO and CRYPTO_MD5 Eric Biggers
  2026-04-09  1:43 ` Martin K. Petersen
@ 2026-04-14  2:19 ` Martin K. Petersen
  1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2026-04-14  2:19 UTC (permalink / raw)
  To: linux-scsi, James E.J. Bottomley, Eric Biggers
  Cc: Martin K . Petersen, linux-kernel

On Sat, 04 Apr 2026 13:30:03 -0700, Eric Biggers wrote:

> As far as I can tell, CRYPTO_MD5 has been unnecessary here ever since it
> was added by commit c899e4ef96f0 ("[SCSI] open-iscsi/linux-iscsi-5
> Initiator: Kconfig update") in 2005.
> 
> CRYPTO was needed until commit 92186c1455a2 ("scsi: iscsi_tcp: Switch to
> using the crc32c library"), but is no longer needed.
> 
> [...]

Applied to 7.1/scsi-queue, thanks!

[1/1] scsi: iscsi_tcp: Remove unneeded selections of CRYPTO and CRYPTO_MD5
      https://git.kernel.org/mkp/scsi/c/7aa0f56d4b48

-- 
Martin K. Petersen

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-04-14  2:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-04 20:30 [PATCH] scsi: iscsi_tcp: Remove unneeded selections of CRYPTO and CRYPTO_MD5 Eric Biggers
2026-04-09  1:43 ` Martin K. Petersen
2026-04-14  2:19 ` Martin K. Petersen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.