Re: [PATCH v4 0/9] driver core: Fix some race conditions - Greg Kroah-Hartman

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Douglas Anderson <dianders@chromium.org>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
	Danilo Krummrich <dakr@kernel.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	Saravana Kannan <saravanak@kernel.org>,
	Christoph Hellwig <hch@lst.de>,
	Eric Dumazet <edumazet@google.com>,
	Johan Hovold <johan@kernel.org>,
	Leon Romanovsky <leon@kernel.org>,
	Alexander Lobakin <aleksander.lobakin@intel.com>,
	Alexey Kardashevskiy <aik@ozlabs.ru>,
	Robin Murphy <robin.murphy@arm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Frank.Li@kernel.org, Jason Gunthorpe <jgg@ziepe.ca>,
	alex@ghiti.fr, alexander.stein@ew.tq-group.com,
	andre.przywara@arm.com, andrew@codeconstruct.com.au,
	andrew@lunn.ch, andriy.shevchenko@linux.intel.com,
	aou@eecs.berkeley.edu, ardb@kernel.org, bhelgaas@google.com,
	brgl@kernel.org, broonie@kernel.org, catalin.marinas@arm.com,
	chleroy@kernel.org, davem@davemloft.net, david@kernel.org,
	devicetree@vger.kernel.org, dmaengine@vger.kernel.org,
	driver-core@lists.linux.dev, gbatra@linux.ibm.com,
	gregory.clement@bootlin.com, hkallweit1@gmail.com,
	iommu@lists.linux.dev, jirislaby@kernel.org, joel@jms.id.au,
	joro@8bytes.org, kees@kernel.org, kevin.brodsky@arm.com,
	kuba@kernel.org, lenb@kernel.org, lgirdwood@gmail.com,
	linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-aspeed@lists.ozlabs.org, linux-cxl@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
	linux-mm@kvack.org, linux-pci@vger.kernel.org,
	linux-riscv@lists.infradead.org, linux-serial@vger.kernel.org,
	linux-snps-arc@lists.infradead.org, linux-usb@vger.kernel.org,
	linux@armlinux.org.uk, linuxppc-dev@lists.ozlabs.org,
	m.szyprowski@samsung.com, maddy@linux.ibm.com, mani@kernel.org,
	maz@kernel.org, miko.lenczewski@arm.com, mpe@ellerman.id.au,
	netdev@vger.kernel.org, npiggin@gmail.com, osalvador@suse.de,
	oupton@kernel.org, pabeni@redhat.com, palmer@dabbelt.com,
	peter.ujfalusi@gmail.com, peterz@infradead.org, pjw@kernel.org,
	robh@kernel.org, sebastian.hesselbarth@gmail.com,
	tglx@kernel.org, tsbogend@alpha.franken.de, vgupta@kernel.org,
	vkoul@kernel.org, will@kernel.org, willy@infradead.org,
	yangyicong@hisilicon.com, yeoreum.yun@arm.com
Subject: Re: [PATCH v4 0/9] driver core: Fix some race conditions
Date: Sun, 5 Apr 2026 07:27:46 +0200	[thread overview]
Message-ID: <2026040539-sponge-publisher-2b42@gregkh> (raw)
In-Reply-To: <20260404000644.522677-1-dianders@chromium.org>

On Fri, Apr 03, 2026 at 05:04:54PM -0700, Douglas Anderson wrote:
> NOTE: one potentially "controversial" choice I made in some patches
> was to always reserve a flag ID even if a flag is only used under
> certain CONFIG_ settings. This is a change from how things were
> before. Keeping the numbering consistent and allowing easy
> compile-testing of both CONFIG settings seemed worth it, especially
> since it won't take up any extra space until we've added a lot more
> flags.

Nah, this is fine, I don't see any problems with this as the original
code kind of was doing the same thing with the "hole" in the structure
if those options were not enabled.

> I only marked the first patch as a "Fix" since it is the only one
> fixing observed problems. Other patches could be considered fixes too
> if folks want.
> 
> I tested the first patch in the series backported to kernel 6.6 on the
> Pixel phone that was experiencing the race. I added extra printouts to
> make sure that the problem was hitting / addressed. The rest of the
> patches are tested with allmodconfig with arm32, arm64, ppc, and
> x86. I boot tested on an arm64 Chromebook running mainline.

I'm guessing your tests passed?  :)

Anyway, this looks great, unless there are any objections, other than
the "needs to be undefined", which a follow-on patch can handle, I'll
queue them up next week for 7.1-rc1.

thanks,

greg k-h