[gerg-m68knommu:dt 1/14] drivers/tty/serial/mcf.c:586:5-14: WARNING: Unsigned expression compared with zero: port -> irq < 0

[gerg-m68knommu:dt 1/14] drivers/tty/serial/mcf.c:586:5-14: WARNING: Unsigned expression compared with zero: port -> irq < 0

[kernel test robot]

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-m68k@lists.linux-m68k.org
CC: uclinux-dev@uclinux.org
TO: Greg Ungerer <gerg@linux-m68k.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gerg/m68knommu.git dt
head:   96bd1f7e74e2461c1e906031ed49b9dcf3c28296
commit: ee23fc34d94a7395f99cffd2c9d92a7a502b408c [1/14] serial: mcf: convert to use proper platform resources
:::::: branch date: 18 hours ago
:::::: commit date: 18 hours ago
config: m68k-randconfig-r052-20260406 (https://download.01.org/0day-ci/archive/20260407/202604070002.C3GJzAXO-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 14.3.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Julia Lawall <julia.lawall@inria.fr>
| Closes: https://lore.kernel.org/r/202604070002.C3GJzAXO-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> drivers/tty/serial/mcf.c:586:5-14: WARNING: Unsigned expression compared with zero: port -> irq < 0

vim +586 drivers/tty/serial/mcf.c

49aa49bfd40d71 drivers/serial/mcf.c     Greg Ungerer      2007-10-23  570  
9671f09921d93e drivers/tty/serial/mcf.c Bill Pemberton    2012-11-19  571  static int mcf_probe(struct platform_device *pdev)
49aa49bfd40d71 drivers/serial/mcf.c     Greg Ungerer      2007-10-23  572  {
49aa49bfd40d71 drivers/serial/mcf.c     Greg Ungerer      2007-10-23  573  	struct uart_port *port;
ee23fc34d94a73 drivers/tty/serial/mcf.c Greg Ungerer      2025-01-15  574  	struct resource *res;
49aa49bfd40d71 drivers/serial/mcf.c     Greg Ungerer      2007-10-23  575  
ee23fc34d94a73 drivers/tty/serial/mcf.c Greg Ungerer      2025-01-15  576  	if (pdev->id >= MCF_MAXPORTS)
ee23fc34d94a73 drivers/tty/serial/mcf.c Greg Ungerer      2025-01-15  577  		return -ENODEV;
ee23fc34d94a73 drivers/tty/serial/mcf.c Greg Ungerer      2025-01-15  578  	port = &mcf_ports[pdev->id].port;
ee23fc34d94a73 drivers/tty/serial/mcf.c Greg Ungerer      2025-01-15  579  
ee23fc34d94a73 drivers/tty/serial/mcf.c Greg Ungerer      2025-01-15  580  	port->membase = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
ee23fc34d94a73 drivers/tty/serial/mcf.c Greg Ungerer      2025-01-15  581  	if (IS_ERR(port->membase))
ee23fc34d94a73 drivers/tty/serial/mcf.c Greg Ungerer      2025-01-15  582  		return PTR_ERR(port->membase);
ee23fc34d94a73 drivers/tty/serial/mcf.c Greg Ungerer      2025-01-15  583  	port->mapbase = res->start;
49aa49bfd40d71 drivers/serial/mcf.c     Greg Ungerer      2007-10-23  584  
ee23fc34d94a73 drivers/tty/serial/mcf.c Greg Ungerer      2025-01-15  585  	port->irq = platform_get_irq(pdev, 0);
ee23fc34d94a73 drivers/tty/serial/mcf.c Greg Ungerer      2025-01-15 @586  	if (port->irq < 0)
ee23fc34d94a73 drivers/tty/serial/mcf.c Greg Ungerer      2025-01-15  587  		return port->irq;
ee23fc34d94a73 drivers/tty/serial/mcf.c Greg Ungerer      2025-01-15  588  
ee23fc34d94a73 drivers/tty/serial/mcf.c Greg Ungerer      2025-01-15  589  	port->line = pdev->id;
49aa49bfd40d71 drivers/serial/mcf.c     Greg Ungerer      2007-10-23  590  	port->type = PORT_MCF;
201d8975ae5ada drivers/tty/serial/mcf.c Greg Ungerer      2015-01-08  591  	port->dev = &pdev->dev;
49aa49bfd40d71 drivers/serial/mcf.c     Greg Ungerer      2007-10-23  592  	port->iotype = SERIAL_IO_MEM;
49aa49bfd40d71 drivers/serial/mcf.c     Greg Ungerer      2007-10-23  593  	port->uartclk = MCF_BUSCLK;
49aa49bfd40d71 drivers/serial/mcf.c     Greg Ungerer      2007-10-23  594  	port->ops = &mcf_uart_ops;
5fda7a0e715c32 drivers/tty/serial/mcf.c Peter Hurley      2014-06-16  595  	port->flags = UPF_BOOT_AUTOCONF;
2fc0184dae7be5 drivers/tty/serial/mcf.c Ricardo Ribalda   2014-11-06  596  	port->rs485_config = mcf_config_rs485;
0139da50dc53f0 drivers/tty/serial/mcf.c Ilpo Järvinen     2022-07-04  597  	port->rs485_supported = mcf_rs485_supported;
4be87603b6dc9e drivers/tty/serial/mcf.c Angelo Dureghello 2020-10-02  598  	port->has_sysrq = IS_ENABLED(CONFIG_SERIAL_MCF_CONSOLE);
49aa49bfd40d71 drivers/serial/mcf.c     Greg Ungerer      2007-10-23  599  
49aa49bfd40d71 drivers/serial/mcf.c     Greg Ungerer      2007-10-23  600  	uart_add_one_port(&mcf_driver, port);
49aa49bfd40d71 drivers/serial/mcf.c     Greg Ungerer      2007-10-23  601  	return 0;
49aa49bfd40d71 drivers/serial/mcf.c     Greg Ungerer      2007-10-23  602  }
49aa49bfd40d71 drivers/serial/mcf.c     Greg Ungerer      2007-10-23  603  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki