All of lore.kernel.org
 help / color / mirror / Atom feed
* [Openvpn-devel] [XS] Change in openvpn[master]: openvpnserv: Remove redundant bit-wise operation
       [not found] <gerrit.1775592384000.I7f983168c263e49da7665fc20bd1ecdd426c21d0@...2715...>
@ 2026-04-07 20:06 ` flichtenheld (Code Review)
  2026-04-07 20:53 ` cron2 (Code Review)
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: flichtenheld (Code Review) @ 2026-04-07 20:06 UTC (permalink / raw)
  To: plaisthos <arne-openvpn@; +Cc: openvpn-devel

[-- Attachment #1: Type: text/plain, Size: 2006 bytes --]

Attention is currently required from: plaisthos.

Hello plaisthos,

I'd like you to do a code review.
Please visit

    http://gerrit.openvpn.net/c/openvpn/+/1623?usp=email

to review the following change.


Change subject: openvpnserv: Remove redundant bit-wise operation
......................................................................

openvpnserv: Remove redundant bit-wise operation

Found by cppcheck.

Change-Id: I7f983168c263e49da7665fc20bd1ecdd426c21d0
Signed-off-by: Frank Lichtenheld <frank@...2641...>
---
M src/openvpnserv/interactive.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/23/1623/1

diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive.c
index a2f9f09..ace25b9 100644
--- a/src/openvpnserv/interactive.c
+++ b/src/openvpnserv/interactive.c
@@ -3410,7 +3410,7 @@
     ea[0].Trustee.TrusteeForm = TRUSTEE_IS_SID;
     ea[0].Trustee.TrusteeType = TRUSTEE_IS_UNKNOWN;
     ea[0].Trustee.ptstrName = (LPWSTR)svc_user->User.Sid;
-    ea[1].grfAccessPermissions = READ_CONTROL | SYNCHRONIZE | PROCESS_VM_READ | SYNCHRONIZE
+    ea[1].grfAccessPermissions = READ_CONTROL | PROCESS_VM_READ | SYNCHRONIZE
                                  | PROCESS_TERMINATE | PROCESS_QUERY_INFORMATION;
     ea[1].grfAccessMode = SET_ACCESS;
     ea[1].grfInheritance = NO_INHERITANCE;

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1623?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I7f983168c263e49da7665fc20bd1ecdd426c21d0
Gerrit-Change-Number: 1623
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <frank@...2641...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...1227...>

[-- Attachment #2: Type: text/html, Size: 3210 bytes --]

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [Openvpn-devel] [XS] Change in openvpn[master]: openvpnserv: Remove redundant bit-wise operation
       [not found] <gerrit.1775592384000.I7f983168c263e49da7665fc20bd1ecdd426c21d0@...2715...>
  2026-04-07 20:06 ` [Openvpn-devel] [XS] Change in openvpn[master]: openvpnserv: Remove redundant bit-wise operation flichtenheld (Code Review)
@ 2026-04-07 20:53 ` cron2 (Code Review)
  2026-04-07 20:53 ` [Openvpn-devel] [PATCH v1] " Gert Doering
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: cron2 (Code Review) @ 2026-04-07 20:53 UTC (permalink / raw)
  To: flichtenheld <frank@; +Cc: plaisthos <arne-openvpn@

[-- Attachment #1: Type: text/plain, Size: 1136 bytes --]

Attention is currently required from: flichtenheld, plaisthos.

cron2 has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1623?usp=email )

Change subject: openvpnserv: Remove redundant bit-wise operation
......................................................................


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1623?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I7f983168c263e49da7665fc20bd1ecdd426c21d0
Gerrit-Change-Number: 1623
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <frank@...2641...>
Gerrit-Reviewer: cron2 <gert@...1296...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...1227...>
Gerrit-Attention: flichtenheld <frank@...2641...>
Gerrit-Comment-Date: Tue, 07 Apr 2026 20:53:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

[-- Attachment #2: Type: text/html, Size: 2103 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Openvpn-devel] [PATCH v1] openvpnserv: Remove redundant bit-wise operation
       [not found] <gerrit.1775592384000.I7f983168c263e49da7665fc20bd1ecdd426c21d0@...2715...>
  2026-04-07 20:06 ` [Openvpn-devel] [XS] Change in openvpn[master]: openvpnserv: Remove redundant bit-wise operation flichtenheld (Code Review)
  2026-04-07 20:53 ` cron2 (Code Review)
@ 2026-04-07 20:53 ` Gert Doering
  2026-04-08 12:34   ` [Openvpn-devel] [PATCH applied] " Gert Doering
  2026-04-08 12:34 ` [Openvpn-devel] [XS] Change in openvpn[master]: " cron2 (Code Review)
  2026-04-08 12:34 ` cron2 (Code Review)
  4 siblings, 1 reply; 6+ messages in thread
From: Gert Doering @ 2026-04-07 20:53 UTC (permalink / raw)
  To: openvpn-devel

From: Frank Lichtenheld <frank@...2641...>

Found by cppcheck.

Change-Id: I7f983168c263e49da7665fc20bd1ecdd426c21d0
Signed-off-by: Frank Lichtenheld <frank@...2641...>
Acked-by: Gert Doering <gert@...1296...>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1623
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1623
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Gert Doering <gert@...1296...>

        
diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive.c
index a2f9f09..ace25b9 100644
--- a/src/openvpnserv/interactive.c
+++ b/src/openvpnserv/interactive.c
@@ -3410,7 +3410,7 @@
     ea[0].Trustee.TrusteeForm = TRUSTEE_IS_SID;
     ea[0].Trustee.TrusteeType = TRUSTEE_IS_UNKNOWN;
     ea[0].Trustee.ptstrName = (LPWSTR)svc_user->User.Sid;
-    ea[1].grfAccessPermissions = READ_CONTROL | SYNCHRONIZE | PROCESS_VM_READ | SYNCHRONIZE
+    ea[1].grfAccessPermissions = READ_CONTROL | PROCESS_VM_READ | SYNCHRONIZE
                                  | PROCESS_TERMINATE | PROCESS_QUERY_INFORMATION;
     ea[1].grfAccessMode = SET_ACCESS;
     ea[1].grfInheritance = NO_INHERITANCE;


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [Openvpn-devel] [PATCH applied] Re: openvpnserv: Remove redundant bit-wise operation
  2026-04-07 20:53 ` [Openvpn-devel] [PATCH v1] " Gert Doering
@ 2026-04-08 12:34   ` Gert Doering
  0 siblings, 0 replies; 6+ messages in thread
From: Gert Doering @ 2026-04-08 12:34 UTC (permalink / raw)
  To: Frank Lichtenheld <frank@; +Cc: openvpn-devel

Maybe it's just me, but I needed to look twice until I saw it... 
("SYNCHRONIZE" was or-ed in twice, which won't make it any stronger)
- but then it's quite obviously correct.  BB compile-tested for me.

Since this isn't changing/fixing functionality, it does not need to
go to 2.7

Your patch has been applied to the master branch.

commit df430b03d5959e87fbf502b7430be07f49a0d0ba
Author: Frank Lichtenheld
Date:   Tue Apr 7 22:53:36 2026 +0200

     openvpnserv: Remove redundant bit-wise operation

     Signed-off-by: Frank Lichtenheld <frank@...2641...>
     Acked-by: Gert Doering <gert@...1296...>
     Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1623
     Message-Id: <20260407205344.31263-1-gert@...1296...>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36547.html
     Signed-off-by: Gert Doering <gert@...1296...>


--
kind regards,

Gert Doering



^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Openvpn-devel] [XS] Change in openvpn[master]: openvpnserv: Remove redundant bit-wise operation
       [not found] <gerrit.1775592384000.I7f983168c263e49da7665fc20bd1ecdd426c21d0@...2715...>
                   ` (2 preceding siblings ...)
  2026-04-07 20:53 ` [Openvpn-devel] [PATCH v1] " Gert Doering
@ 2026-04-08 12:34 ` cron2 (Code Review)
  2026-04-08 12:34 ` cron2 (Code Review)
  4 siblings, 0 replies; 6+ messages in thread
From: cron2 (Code Review) @ 2026-04-08 12:34 UTC (permalink / raw)
  To: flichtenheld <frank@; +Cc: openvpn-devel

[-- Attachment #1: Type: text/plain, Size: 2292 bytes --]

cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1623?usp=email )

The following approvals got outdated and were removed:
Code-Review+2 by cron2


Change subject: openvpnserv: Remove redundant bit-wise operation
......................................................................

openvpnserv: Remove redundant bit-wise operation

Found by cppcheck.

Change-Id: I7f983168c263e49da7665fc20bd1ecdd426c21d0
Signed-off-by: Frank Lichtenheld <frank@...2641...>
Acked-by: Gert Doering <gert@...1296...>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1623
Message-Id: <20260407205344.31263-1-gert@...1296...>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36547.html
Signed-off-by: Gert Doering <gert@...1296...>
---
M src/openvpnserv/interactive.c
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/23/1623/2

diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive.c
index c96d3f2..4268214 100644
--- a/src/openvpnserv/interactive.c
+++ b/src/openvpnserv/interactive.c
@@ -3410,7 +3410,7 @@
     ea[0].Trustee.TrusteeForm = TRUSTEE_IS_SID;
     ea[0].Trustee.TrusteeType = TRUSTEE_IS_UNKNOWN;
     ea[0].Trustee.ptstrName = (LPWSTR)svc_user->User.Sid;
-    ea[1].grfAccessPermissions = READ_CONTROL | SYNCHRONIZE | PROCESS_VM_READ | SYNCHRONIZE
+    ea[1].grfAccessPermissions = READ_CONTROL | PROCESS_VM_READ | SYNCHRONIZE
                                  | PROCESS_TERMINATE | PROCESS_QUERY_INFORMATION;
     ea[1].grfAccessMode = SET_ACCESS;
     ea[1].grfInheritance = NO_INHERITANCE;

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1623?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I7f983168c263e49da7665fc20bd1ecdd426c21d0
Gerrit-Change-Number: 1623
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2641...>
Gerrit-Reviewer: cron2 <gert@...1296...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>

[-- Attachment #2: Type: text/html, Size: 3555 bytes --]

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [Openvpn-devel] [XS] Change in openvpn[master]: openvpnserv: Remove redundant bit-wise operation
       [not found] <gerrit.1775592384000.I7f983168c263e49da7665fc20bd1ecdd426c21d0@...2715...>
                   ` (3 preceding siblings ...)
  2026-04-08 12:34 ` [Openvpn-devel] [XS] Change in openvpn[master]: " cron2 (Code Review)
@ 2026-04-08 12:34 ` cron2 (Code Review)
  4 siblings, 0 replies; 6+ messages in thread
From: cron2 (Code Review) @ 2026-04-08 12:34 UTC (permalink / raw)
  To: flichtenheld <frank@; +Cc: plaisthos <arne-openvpn@

[-- Attachment #1: Type: text/plain, Size: 2074 bytes --]

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1623?usp=email )

Change subject: openvpnserv: Remove redundant bit-wise operation
......................................................................

openvpnserv: Remove redundant bit-wise operation

Found by cppcheck.

Change-Id: I7f983168c263e49da7665fc20bd1ecdd426c21d0
Signed-off-by: Frank Lichtenheld <frank@...2641...>
Acked-by: Gert Doering <gert@...1296...>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1623
Message-Id: <20260407205344.31263-1-gert@...1296...>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36547.html
Signed-off-by: Gert Doering <gert@...1296...>
---
M src/openvpnserv/interactive.c
1 file changed, 1 insertion(+), 1 deletion(-)




diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive.c
index c96d3f2..4268214 100644
--- a/src/openvpnserv/interactive.c
+++ b/src/openvpnserv/interactive.c
@@ -3410,7 +3410,7 @@
     ea[0].Trustee.TrusteeForm = TRUSTEE_IS_SID;
     ea[0].Trustee.TrusteeType = TRUSTEE_IS_UNKNOWN;
     ea[0].Trustee.ptstrName = (LPWSTR)svc_user->User.Sid;
-    ea[1].grfAccessPermissions = READ_CONTROL | SYNCHRONIZE | PROCESS_VM_READ | SYNCHRONIZE
+    ea[1].grfAccessPermissions = READ_CONTROL | PROCESS_VM_READ | SYNCHRONIZE
                                  | PROCESS_TERMINATE | PROCESS_QUERY_INFORMATION;
     ea[1].grfAccessMode = SET_ACCESS;
     ea[1].grfInheritance = NO_INHERITANCE;

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1623?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: merged
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I7f983168c263e49da7665fc20bd1ecdd426c21d0
Gerrit-Change-Number: 1623
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2641...>
Gerrit-Reviewer: cron2 <gert@...1296...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>

[-- Attachment #2: Type: text/html, Size: 3302 bytes --]

^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-04-08 12:34 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <gerrit.1775592384000.I7f983168c263e49da7665fc20bd1ecdd426c21d0@...2715...>
2026-04-07 20:06 ` [Openvpn-devel] [XS] Change in openvpn[master]: openvpnserv: Remove redundant bit-wise operation flichtenheld (Code Review)
2026-04-07 20:53 ` cron2 (Code Review)
2026-04-07 20:53 ` [Openvpn-devel] [PATCH v1] " Gert Doering
2026-04-08 12:34   ` [Openvpn-devel] [PATCH applied] " Gert Doering
2026-04-08 12:34 ` [Openvpn-devel] [XS] Change in openvpn[master]: " cron2 (Code Review)
2026-04-08 12:34 ` cron2 (Code Review)

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.