From: Prithvi Tambewagh <activprithvi@gmail.com>
To: gregkh@linuxfoundation.org, abrahamadekunle50@gmail.com,
b9788213@gmail.com, straube.linux@gmail.com,
tmimiharoen@gmail.com, filippo.muschera@gmail.com,
ethantidmore06@gmail.com, andriy.shevchenko@linux.intel.com,
rayfraytech@gmail.com, david@cardinalsystem.net,
weibu@redadmin.org, dharanitharan725@gmail.com,
ignacio.pena87@gmail.com, dan.carpenter@linaro.org,
karanja99erick@gmail.com, luka.gejak@linux.dev,
khushalchitturi@gmail.com, suunj1331@gmail.com,
s9430939@naver.com, nikolayof23@gmail.com,
bryant.boatright@proton.me, ysinghcin@gmail.com
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linux.dev, skhan@linuxfoundation.org,
david.hunter.linux@gmail.com, khalid@kernel.org,
Prithvi Tambewagh <activprithvi@gmail.com>
Subject: [PATCH v4 0/5] staging: rtl8723bs: Code cleanup in drivers/staging/rtl8723bs
Date: Thu, 9 Apr 2026 19:20:21 +0530 [thread overview]
Message-ID: <20260409135026.137904-1-activprithvi@gmail.com> (raw)
This patch series focuses on code cleanup in drivers/staging/rtl8723bs,
majorly focusing on fixing checkpatch warnings of constant being on right
side of test in comparisons, deletion of empty if block ,use of
read_poll_timeout_atomic(), and other code simplifications.
Changes since v3:
- Rebased the patches on top of staging-next
- Remove compilation output from cover letter
- Add changes in each patch version in cover letter
v3 link: https://lore.kernel.org/linux-staging/1D11A73B-4869-47DB-B8F5-FB3F0D7FF932@linux.dev/T/#m3190af744bc1e1f151e9e8503c7d20951fe27534
Changes since v2:
- Create patch series, each doing one logical thing
- Use read_poll_timeout_atomic() in _is_fw_read_cmd_down()
- Use single return statement instead of if-else blocks containing return
true and return false, in IsFrameTypeCtrl()
- Remove unnecessary changes from the patches
- Convey testing status of the patches
v2 link: https://lore.kernel.org/linux-staging/20260403094647.fmgop6xh2cjpit3s@inspiron/T/#m3d08fd012119772ea55df48eea80abbea34e8548
Changes since v1:
- Check for more changes of the type of placing constant on right side of
comparison/test in drivers/staging/rtl8723bs/
v1 link: https://lore.kernel.org/linux-staging/20260323145214.ubhshy2gwp52j5zh@inspiron/T/#mc3b693b37c49fbdde89171b7f1bf61b7ba8eb964
This patch series is compile tested using the following commands, which
include setting the necessary configurations:
1. make defconfig
2. scripts/config --enable CONFIG_STAGING
3. scripts/config --module CONFIG_MMC
4. scripts/config --module CONFIG_RTL8723BS
5. make olddefconfig
6. make -j$(nproc)
7. git rebase -i --exec "make -j$(nproc) M=drivers/staging/rtl8723bs" HEAD~5
However, as Luka reviewed v3 - since these are only style changes, testing
is not necessary, so I dropped RFT tag from the patch series.
Prithvi Tambewagh (5):
staging: rtl8723bs: move constant to right side of test in comparison
staging: rtl8723bs: remove empty if statement block
staging: rtl8723bs: simplify boolean return in IsFrameTypeCtrl()
staging: rtl8723bs: use read_poll_timeout_atomic in
_is_fw_read_cmd_down
staging: rtl8723bs: remove duplicate rate checks in
PHY_GetTxPowerIndexBase()
.../staging/rtl8723bs/hal/HalBtc8723b2Ant.c | 4 ++--
drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 5 +----
drivers/staging/rtl8723bs/hal/hal_com.c | 2 +-
drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 11 +++++------
drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 18 +++++++-----------
.../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 18 +++++++++---------
drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 2 +-
drivers/staging/rtl8723bs/include/ieee80211.h | 4 ++--
drivers/staging/rtl8723bs/include/wifi.h | 5 +----
9 files changed, 29 insertions(+), 40 deletions(-)
--
2.34.1
next reply other threads:[~2026-04-09 13:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 13:50 Prithvi Tambewagh [this message]
2026-04-09 13:50 ` [PATCH v4 1/5] staging: rtl8723bs: move constant to right side of test in comparison Prithvi Tambewagh
2026-04-09 14:10 ` Luka Gejak
2026-04-09 13:50 ` [PATCH v4 2/5] staging: rtl8723bs: remove empty if statement block Prithvi Tambewagh
2026-04-09 14:10 ` Luka Gejak
2026-04-09 13:50 ` [PATCH v4 3/5] staging: rtl8723bs: simplify boolean return in IsFrameTypeCtrl() Prithvi Tambewagh
2026-04-09 14:10 ` Luka Gejak
2026-04-09 13:50 ` [PATCH v4 4/5] staging: rtl8723bs: use read_poll_timeout_atomic in _is_fw_read_cmd_down Prithvi Tambewagh
2026-04-09 14:10 ` Luka Gejak
2026-04-09 13:50 ` [PATCH v4 5/5] staging: rtl8723bs: remove duplicate rate checks in PHY_GetTxPowerIndexBase() Prithvi Tambewagh
2026-04-09 14:14 ` Luka Gejak
2026-04-09 14:18 ` [PATCH v4 0/5] staging: rtl8723bs: Code cleanup in drivers/staging/rtl8723bs Luka Gejak
2026-04-09 14:50 ` Prithvi
2026-04-09 14:57 ` Luka Gejak
2026-04-09 15:30 ` Prithvi
2026-04-09 15:32 ` Luka Gejak
2026-04-09 15:42 ` Luka Gejak
2026-04-09 15:02 ` Greg KH
2026-04-09 15:39 ` Prithvi
2026-04-09 15:44 ` Luka Gejak
2026-04-09 15:55 ` Andy Shevchenko
2026-04-14 6:15 ` Prithvi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260409135026.137904-1-activprithvi@gmail.com \
--to=activprithvi@gmail.com \
--cc=abrahamadekunle50@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=b9788213@gmail.com \
--cc=bryant.boatright@proton.me \
--cc=dan.carpenter@linaro.org \
--cc=david.hunter.linux@gmail.com \
--cc=david@cardinalsystem.net \
--cc=dharanitharan725@gmail.com \
--cc=ethantidmore06@gmail.com \
--cc=filippo.muschera@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ignacio.pena87@gmail.com \
--cc=karanja99erick@gmail.com \
--cc=khalid@kernel.org \
--cc=khushalchitturi@gmail.com \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=luka.gejak@linux.dev \
--cc=nikolayof23@gmail.com \
--cc=rayfraytech@gmail.com \
--cc=s9430939@naver.com \
--cc=skhan@linuxfoundation.org \
--cc=straube.linux@gmail.com \
--cc=suunj1331@gmail.com \
--cc=tmimiharoen@gmail.com \
--cc=weibu@redadmin.org \
--cc=ysinghcin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.