All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alice Mikityanska <alice.kernel@fastmail.im>
To: Daniel Borkmann <daniel@iogearbox.net>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Xin Long <lucien.xin@gmail.com>,
	Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
	David Ahern <dsahern@kernel.org>,
	Nikolay Aleksandrov <razor@blackwall.org>
Cc: Shuah Khan <shuah@kernel.org>,
	Stanislav Fomichev <stfomichev@gmail.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	Simon Horman <horms@kernel.org>, Florian Westphal <fw@strlen.de>,
	netdev@vger.kernel.org, Alice Mikityanska <alice@isovalent.com>
Subject: [PATCH net-next v3 03/12] geneve: Fix off-by-one comparing with GRO_LEGACY_MAX_SIZE
Date: Fri, 10 Apr 2026 18:09:34 +0300	[thread overview]
Message-ID: <20260410150943.993350-4-alice.kernel@fastmail.im> (raw)
In-Reply-To: <20260410150943.993350-1-alice.kernel@fastmail.im>

From: Alice Mikityanska <alice@isovalent.com>

GRO_LEGACY_MAX_SIZE = 65536; total_len being 65536 is too big to fit
into a u16. As can be seen in skb_gro_receive, packets bigger or equal
to gro_max_size (or GRO_LEGACY_MAX_SIZE) are dropped with -E2BIG. Apply
the same boundary to geneve_post_decap_hint to avoid writing 65536 to a
16-bit iph->tot_len field with an overflow.

Fixes: fd0dd796576e ("geneve: use GRO hint option in the RX path")
Signed-off-by: Alice Mikityanska <alice@isovalent.com>
---
 drivers/net/geneve.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c
index c6563367d382..84e8d6c69172 100644
--- a/drivers/net/geneve.c
+++ b/drivers/net/geneve.c
@@ -603,7 +603,7 @@ static int geneve_post_decap_hint(const struct sock *sk, struct sk_buff *skb,
 	ipv6h = (void *)skb->data + gro_hint->nested_nh_offset;
 	iph = (struct iphdr *)ipv6h;
 	total_len = skb->len - gro_hint->nested_nh_offset;
-	if (total_len > GRO_LEGACY_MAX_SIZE)
+	if (total_len >= GRO_LEGACY_MAX_SIZE)
 		return -E2BIG;
 
 	/*
-- 
2.53.0


  parent reply	other threads:[~2026-04-10 15:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-10 15:09 [PATCH net-next v3 00/12] BIG TCP for UDP tunnels Alice Mikityanska
2026-04-10 15:09 ` [PATCH net-next v3 01/12] net/sched: act_csum: don't mangle UDP tunnel GSO packets Alice Mikityanska
2026-04-10 15:39   ` Davide Caratti
2026-04-10 15:09 ` [PATCH net-next v3 02/12] udp: gso: Simplify handling length in GSO_PARTIAL Alice Mikityanska
2026-04-10 15:09 ` Alice Mikityanska [this message]
2026-04-10 15:09 ` [PATCH net-next v3 04/12] net: Use helpers to get/set UDP len tree-wide Alice Mikityanska
2026-04-10 15:09 ` [PATCH net-next v3 05/12] net: Enable BIG TCP with partial GSO Alice Mikityanska
2026-04-10 15:09 ` [PATCH net-next v3 06/12] udp: Support gro_ipv4_max_size > 65536 Alice Mikityanska
2026-04-10 15:09 ` [PATCH net-next v3 07/12] udp: Support BIG TCP GSO packets where they can occur Alice Mikityanska
2026-04-10 15:09 ` [PATCH net-next v3 08/12] udp: Validate UDP length in udp_gro_receive Alice Mikityanska
2026-04-10 15:09 ` [PATCH net-next v3 09/12] udp: Set length in UDP header to 0 for big GSO packets Alice Mikityanska
2026-04-10 15:09 ` [PATCH net-next v3 10/12] vxlan: Enable BIG TCP packets Alice Mikityanska
2026-04-10 15:09 ` [PATCH net-next v3 11/12] geneve: " Alice Mikityanska
2026-04-10 15:09 ` [PATCH net-next v3 12/12] selftests: net: Add a test for BIG TCP in UDP tunnels Alice Mikityanska
2026-04-16 12:06   ` Willem de Bruijn
2026-04-19 16:24     ` Alice Mikityanska
2026-04-20  7:00       ` Willem de Bruijn
2026-04-13 22:55 ` [PATCH net-next v3 00/12] BIG TCP for " Jakub Kicinski
2026-04-15 12:14   ` Alice Mikityanska
2026-04-16 12:07     ` Willem de Bruijn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260410150943.993350-4-alice.kernel@fastmail.im \
    --to=alice.kernel@fastmail.im \
    --cc=alice@isovalent.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=fw@strlen.de \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=lucien.xin@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=razor@blackwall.org \
    --cc=shuah@kernel.org \
    --cc=stfomichev@gmail.com \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.