Re: [GIT PULL] RISC-V SpacemiT Devicetrees for v7.1

From: Yixun Lan <dlan@kernel.org>
To: Linus Walleij <linusw@kernel.org>
Cc: soc@kernel.org, Yixun Lan <dlan@gentoo.org>,
	Arnd Bergmann <arnd@arndb.de>,
	spacemit@lists.linux.dev, linux-riscv@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] RISC-V SpacemiT Devicetrees for v7.1
Date: Sat, 11 Apr 2026 07:37:46 +0800	[thread overview]
Message-ID: <20260410233746-GKA1167630@kernel.org> (raw)
In-Reply-To: <CAD++jLkQfUwhvDOCkhK2NtRyXrb6y9rwpDckR6h0G3+dzYwW3A@mail.gmail.com>

Hi Linus,

On 00:19 Sat 11 Apr     , Linus Walleij wrote:
> Hi Yixun,
> 
> I looked into this pull request.
> 
> I'm sorry if I do stupid mistakes in handling it, I'm new to maintaining
> the SoC tree. Bear with me.
> 
> On Fri, Apr 3, 2026 at 2:32 PM Yixun Lan <dlan@kernel.org> wrote:
> 
> > Aurelien Jarno (7):
> >       riscv: dts: spacemit: drop incorrect pinctrl for combo PHY
> (...)
> > Yixun Lan (9):
> >       riscv: dts: spacemit: pcie: fix missing power regulator
> 
> [Fixes]
> fatal: Not a valid object name linus/master
Could be the problem that your master branch isn't up-to-date?

> Commit: c68360c0d636 ("riscv: dts: spacemit: drop incorrect pinctrl
> for combo PHY")
..
>     Fixes tag: Fixes: 0be016a4b5d1b9 ("riscv: dts: spacemit: PCIe and
> PHY-related updates")
Above commit was merged for v7.0 cycle, while this PR is for v7.1
The fix isn't that critical and didn't cause any run-time issue, so
I do the fix in this v7.1 cycle..

>     Has these problem(s):
>         - Inspect: Target SHA is not ancestor of Linus' master branch,
> which means it is fixing commit in your branch
> fatal: Not a valid object name linus/master
> Commit: 8a9071299dec ("riscv: dts: spacemit: pcie: fix missing power regulator")
>     Fixes tag: Fixes: 0be016a4b5d1 ("riscv: dts: spacemit: PCIe and
> PHY-related updates")
>     Has these problem(s):
>         - Inspect: Target SHA is not ancestor of Linus' master branch,
> which means it is fixing commit in your branch
> 
> So this means you introduced bugs and fix them in the same pull request?
> 
> Why?
> 
> The practice is to squash such fixes into the offending patches when
> presenting pull requests. But I went ahead anyway, trying to not be so
> picky. (The commits are there, in your branch indeed.)
> 
Glad to learn this, I will keep it in mind..

> - Checked that it was in linux-next OK
Right, I think the commit is actually in v7.0-rc1

> - built DTBS OK
> 
> Pulled in, thanks.
Thank you

> 
> Yours,
> Linus Walleij

-- 
Yixun Lan (dlan)