From: Simon Horman <horms@kernel.org>
To: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,
netdev@vger.kernel.org, Dave Ertman <david.m.ertman@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next 1/10] ice: translate FW to SW for max num TCs encoding
Date: Tue, 14 Apr 2026 09:44:16 +0100 [thread overview]
Message-ID: <20260414084416.GW469338@kernel.org> (raw)
In-Reply-To: <20260410074921.1254213-2-aleksandr.loktionov@intel.com>
On Fri, Apr 10, 2026 at 09:49:12AM +0200, Aleksandr Loktionov wrote:
> From: Dave Ertman <david.m.ertman@intel.com>
>
> The FW uses a 3-bit field in a TLV to represent the maximum number of
> Traffic Classes supported per interface. Since the maximum value is 8,
> and at least one TC must be supported, the encoding uses bit values of
> 000 to represent 8 TCs.
>
> The driver currently does not translate this value and reports 0 max TCs
> to the DCBNL interface instead of 8.
>
> Add a translation when interfacing with the FW to use 0x0 as the value
> for 8 max TCs.
>
> Signed-off-by: Dave Ertman <david.m.ertman@intel.com>
> Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
I'm not sure if you want to reconsider this as a bug fix.
But the code changes look good to me.
Reviewed-by: Simon Horman <horms@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,
netdev@vger.kernel.org, Dave Ertman <david.m.ertman@intel.com>
Subject: Re: [PATCH iwl-next 1/10] ice: translate FW to SW for max num TCs encoding
Date: Tue, 14 Apr 2026 09:44:16 +0100 [thread overview]
Message-ID: <20260414084416.GW469338@kernel.org> (raw)
In-Reply-To: <20260410074921.1254213-2-aleksandr.loktionov@intel.com>
On Fri, Apr 10, 2026 at 09:49:12AM +0200, Aleksandr Loktionov wrote:
> From: Dave Ertman <david.m.ertman@intel.com>
>
> The FW uses a 3-bit field in a TLV to represent the maximum number of
> Traffic Classes supported per interface. Since the maximum value is 8,
> and at least one TC must be supported, the encoding uses bit values of
> 000 to represent 8 TCs.
>
> The driver currently does not translate this value and reports 0 max TCs
> to the DCBNL interface instead of 8.
>
> Add a translation when interfacing with the FW to use 0x0 as the value
> for 8 max TCs.
>
> Signed-off-by: Dave Ertman <david.m.ertman@intel.com>
> Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
I'm not sure if you want to reconsider this as a bug fix.
But the code changes look good to me.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2026-04-14 8:44 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-10 7:49 [Intel-wired-lan] [PATCH iwl-next 0/10] ice: misc cleanups and improvements Aleksandr Loktionov
2026-04-10 7:49 ` Aleksandr Loktionov
2026-04-10 7:49 ` [Intel-wired-lan] [PATCH iwl-next 1/10] ice: translate FW to SW for max num TCs encoding Aleksandr Loktionov
2026-04-10 7:49 ` Aleksandr Loktionov
2026-04-14 8:44 ` Simon Horman [this message]
2026-04-14 8:44 ` Simon Horman
2026-05-08 15:32 ` [Intel-wired-lan] " Nowlin, Alexander
2026-05-08 15:32 ` Nowlin, Alexander
2026-04-10 7:49 ` [Intel-wired-lan] [PATCH iwl-next 2/10] ice: allow setting advertised speed and duplex for all media types Aleksandr Loktionov
2026-04-10 7:49 ` Aleksandr Loktionov
2026-04-14 9:04 ` [Intel-wired-lan] " Simon Horman
2026-04-14 9:04 ` Simon Horman
2026-05-08 15:33 ` [Intel-wired-lan] " Nowlin, Alexander
2026-05-08 15:33 ` Nowlin, Alexander
2026-04-10 7:49 ` [Intel-wired-lan] [PATCH iwl-next 3/10] ice: add PORT_AUI and PORT_NONE ethtool port type reporting Aleksandr Loktionov
2026-04-10 7:49 ` Aleksandr Loktionov
2026-05-08 15:33 ` [Intel-wired-lan] " Nowlin, Alexander
2026-05-08 15:33 ` Nowlin, Alexander
2026-04-10 7:49 ` [Intel-wired-lan] [PATCH iwl-next 4/10] ice: reorder ice_flash_info fields to eliminate padding Aleksandr Loktionov
2026-04-10 7:49 ` Aleksandr Loktionov
2026-04-14 9:16 ` [Intel-wired-lan] " Simon Horman
2026-04-14 9:16 ` Simon Horman
2026-05-08 15:34 ` [Intel-wired-lan] " Nowlin, Alexander
2026-05-08 15:34 ` Nowlin, Alexander
2026-04-10 7:49 ` [Intel-wired-lan] [PATCH iwl-next 5/10] ice: improve Add/Update VSI error messages in ice_vsi_init() Aleksandr Loktionov
2026-04-10 7:49 ` Aleksandr Loktionov
2026-04-14 9:30 ` [Intel-wired-lan] " Simon Horman
2026-04-14 9:30 ` Simon Horman
2026-05-08 15:34 ` [Intel-wired-lan] " Nowlin, Alexander
2026-05-08 15:34 ` Nowlin, Alexander
2026-04-10 7:49 ` [Intel-wired-lan] [PATCH iwl-next 6/10] ice: increase OICR interrupt moderation rate to 20K interrupts/sec Aleksandr Loktionov
2026-04-10 7:49 ` Aleksandr Loktionov
2026-04-14 9:33 ` [Intel-wired-lan] " Simon Horman
2026-04-14 9:33 ` Simon Horman
2026-05-08 15:35 ` [Intel-wired-lan] " Nowlin, Alexander
2026-05-08 15:35 ` Nowlin, Alexander
2026-04-10 7:49 ` [Intel-wired-lan] [PATCH iwl-next 7/10] ice: emit user-visible info message for non-contiguous ETS TC config Aleksandr Loktionov
2026-04-10 7:49 ` Aleksandr Loktionov
2026-04-14 9:35 ` [Intel-wired-lan] " Simon Horman
2026-04-14 9:35 ` Simon Horman
2026-05-08 15:36 ` [Intel-wired-lan] " Nowlin, Alexander
2026-05-08 15:36 ` Nowlin, Alexander
2026-04-10 7:49 ` [Intel-wired-lan] [PATCH iwl-next 8/10] ice: move ice_phy_get_speed_eth56g() from ice_ptp_hw.c to ice_common.c Aleksandr Loktionov
2026-04-10 7:49 ` Aleksandr Loktionov
2026-04-14 9:38 ` [Intel-wired-lan] " Simon Horman
2026-04-14 9:38 ` Simon Horman
2026-05-08 15:37 ` [Intel-wired-lan] " Nowlin, Alexander
2026-05-08 15:37 ` Nowlin, Alexander
2026-04-10 7:49 ` [Intel-wired-lan] [PATCH iwl-next 9/10] ice: use inline helpers instead of memcmp() for IPv6 mask checks in ice_ethtool_fdir Aleksandr Loktionov
2026-04-10 7:49 ` Aleksandr Loktionov
2026-04-14 9:39 ` [Intel-wired-lan] " Simon Horman
2026-04-14 9:39 ` Simon Horman
2026-05-08 15:38 ` [Intel-wired-lan] " Nowlin, Alexander
2026-05-08 15:38 ` Nowlin, Alexander
2026-04-10 7:49 ` [Intel-wired-lan] [PATCH iwl-next 10/10] ice: promote Tx FIFO drain timeout message from dev_dbg to dev_warn Aleksandr Loktionov
2026-04-10 7:49 ` Aleksandr Loktionov
2026-04-14 9:39 ` [Intel-wired-lan] " Simon Horman
2026-04-14 9:39 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260414084416.GW469338@kernel.org \
--to=horms@kernel.org \
--cc=aleksandr.loktionov@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=david.m.ertman@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.