From: Simon Horman <horms@kernel.org>
To: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,
netdev@vger.kernel.org, Kiran Patil <kiran.patil@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net 5/5] iavf: return 0 when TC flower filter not found after qdisc teardown
Date: Wed, 15 Apr 2026 14:53:15 +0100 [thread overview]
Message-ID: <20260415135315.GK772670@horms.kernel.org> (raw)
In-Reply-To: <20260413073035.4082204-6-aleksandr.loktionov@intel.com>
On Mon, Apr 13, 2026 at 09:30:35AM +0200, Aleksandr Loktionov wrote:
> From: Kiran Patil <kiran.patil@intel.com>
>
> When an egress qdisc is destroyed, the driver proactively deletes all
> associated cloud filters to prevent stale hardware state, decrementing
> num_cloud_filters to zero in the process.
>
> The kernel netdev layer is unaware of this implicit cleanup and may
> still try to delete the same filters individually. If the filter is
> not found in the driver's list and num_cloud_filters is already zero,
> return 0 instead of -EINVAL to avoid confusing upper layers that
> believe the filter is still offloaded in hardware.
>
> Fixes: 0075fa0fadd0 ("i40evf: Add support to apply cloud filters")
> Signed-off-by: Kiran Patil <kiran.patil@intel.com>
> Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Sashiko has some comments on this function - which do not
seem related to the logic this patch touches.
I'd encourage you to take a look at some point as a follow-up activity.
...
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,
netdev@vger.kernel.org, Kiran Patil <kiran.patil@intel.com>
Subject: Re: [PATCH iwl-net 5/5] iavf: return 0 when TC flower filter not found after qdisc teardown
Date: Wed, 15 Apr 2026 14:53:15 +0100 [thread overview]
Message-ID: <20260415135315.GK772670@horms.kernel.org> (raw)
In-Reply-To: <20260413073035.4082204-6-aleksandr.loktionov@intel.com>
On Mon, Apr 13, 2026 at 09:30:35AM +0200, Aleksandr Loktionov wrote:
> From: Kiran Patil <kiran.patil@intel.com>
>
> When an egress qdisc is destroyed, the driver proactively deletes all
> associated cloud filters to prevent stale hardware state, decrementing
> num_cloud_filters to zero in the process.
>
> The kernel netdev layer is unaware of this implicit cleanup and may
> still try to delete the same filters individually. If the filter is
> not found in the driver's list and num_cloud_filters is already zero,
> return 0 instead of -EINVAL to avoid confusing upper layers that
> believe the filter is still offloaded in hardware.
>
> Fixes: 0075fa0fadd0 ("i40evf: Add support to apply cloud filters")
> Signed-off-by: Kiran Patil <kiran.patil@intel.com>
> Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Sashiko has some comments on this function - which do not
seem related to the logic this patch touches.
I'd encourage you to take a look at some point as a follow-up activity.
...
next prev parent reply other threads:[~2026-04-15 13:53 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-13 7:30 [Intel-wired-lan] [PATCH iwl-net 0/5] iavf: five correctness fixes Aleksandr Loktionov
2026-04-13 7:30 ` Aleksandr Loktionov
2026-04-13 7:30 ` [Intel-wired-lan] [PATCH iwl-net 1/5] iavf: fix null pointer dereference in iavf_detect_recover_hung Aleksandr Loktionov
2026-04-13 7:30 ` Aleksandr Loktionov
2026-04-15 12:48 ` [Intel-wired-lan] " Simon Horman
2026-04-15 12:48 ` Simon Horman
2026-05-11 8:25 ` [Intel-wired-lan] " Romanowski, Rafal
2026-05-11 8:25 ` Romanowski, Rafal
2026-05-11 11:39 ` Loktionov, Aleksandr
2026-05-11 11:39 ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-04-13 7:30 ` [Intel-wired-lan] [PATCH iwl-net 2/5] iavf: fix error path in iavf_request_misc_irq Aleksandr Loktionov
2026-04-13 7:30 ` Aleksandr Loktionov
2026-04-13 11:53 ` [Intel-wired-lan] " Przemek Kitszel
2026-04-13 11:53 ` Przemek Kitszel
2026-05-11 8:25 ` [Intel-wired-lan] " Romanowski, Rafal
2026-05-11 8:25 ` Romanowski, Rafal
2026-04-15 13:26 ` Simon Horman
2026-04-15 13:26 ` Simon Horman
2026-04-13 7:30 ` [Intel-wired-lan] [PATCH iwl-net 3/5] iavf: prevent VSI corruption when ring params changed during reset Aleksandr Loktionov
2026-04-13 7:30 ` Aleksandr Loktionov
2026-04-15 13:28 ` [Intel-wired-lan] " Simon Horman
2026-04-15 13:28 ` Simon Horman
2026-05-11 8:22 ` [Intel-wired-lan] " Romanowski, Rafal
2026-05-11 8:22 ` Romanowski, Rafal
2026-04-13 7:30 ` [Intel-wired-lan] [PATCH iwl-net 4/5] iavf: fix TC boundary check in iavf_handle_tclass Aleksandr Loktionov
2026-04-13 7:30 ` Aleksandr Loktionov
2026-04-15 13:46 ` [Intel-wired-lan] " Simon Horman
2026-04-15 13:46 ` Simon Horman
2026-05-11 8:22 ` [Intel-wired-lan] " Romanowski, Rafal
2026-05-11 8:22 ` Romanowski, Rafal
2026-05-11 11:32 ` Loktionov, Aleksandr
2026-05-11 11:32 ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-04-13 7:30 ` [Intel-wired-lan] [PATCH iwl-net 5/5] iavf: return 0 when TC flower filter not found after qdisc teardown Aleksandr Loktionov
2026-04-13 7:30 ` Aleksandr Loktionov
2026-04-15 13:53 ` Simon Horman [this message]
2026-04-15 13:53 ` Simon Horman
2026-05-11 8:23 ` [Intel-wired-lan] " Romanowski, Rafal
2026-05-11 8:23 ` Romanowski, Rafal
2026-05-11 8:21 ` [Intel-wired-lan] [PATCH iwl-net 0/5] iavf: five correctness fixes Romanowski, Rafal
2026-05-11 8:21 ` Romanowski, Rafal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260415135315.GK772670@horms.kernel.org \
--to=horms@kernel.org \
--cc=aleksandr.loktionov@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kiran.patil@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.