All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] staging: fbtft: fb_tinylcd: fix alignment in write_reg call
@ 2026-04-17 10:14 Prasaanth
  2026-04-17 11:20 ` Andy Shevchenko
  0 siblings, 1 reply; 3+ messages in thread
From: Prasaanth @ 2026-04-17 10:14 UTC (permalink / raw)
  To: linux-staging
  Cc: andy, gregkh, dri-devel, linux-fbdev, linux-kernel, Prasaanth

Fix alignment of multiline arguments in write_reg() call to
match kernel coding style

Reported by checkpatch.pl

Signed-off-by: Prasaanth <prasaanth2k@gmail.com>
---
 drivers/staging/fbtft/fb_tinylcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/fbtft/fb_tinylcd.c b/drivers/staging/fbtft/fb_tinylcd.c
index 9469248f2..60cda57bc 100644
--- a/drivers/staging/fbtft/fb_tinylcd.c
+++ b/drivers/staging/fbtft/fb_tinylcd.c
@@ -38,7 +38,7 @@ static int init_display(struct fbtft_par *par)
 	write_reg(par, 0xE5, 0x00);
 	write_reg(par, 0xF0, 0x36, 0xA5, 0x53);
 	write_reg(par, 0xE0, 0x00, 0x35, 0x33, 0x00, 0x00, 0x00,
-		       0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
+		  0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
 	write_reg(par, MIPI_DCS_SET_PIXEL_FORMAT, 0x55);
 	write_reg(par, MIPI_DCS_EXIT_SLEEP_MODE);
 	udelay(250);
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] staging: fbtft: fb_tinylcd: fix alignment in write_reg call
  2026-04-17 10:14 [PATCH] staging: fbtft: fb_tinylcd: fix alignment in write_reg call Prasaanth
@ 2026-04-17 11:20 ` Andy Shevchenko
  2026-04-17 11:31   ` Prasaanth Sakthivel
  0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2026-04-17 11:20 UTC (permalink / raw)
  To: Prasaanth
  Cc: linux-staging, andy, gregkh, dri-devel, linux-fbdev, linux-kernel

On Fri, Apr 17, 2026 at 03:44:57PM +0530, Prasaanth wrote:
> Fix alignment of multiline arguments in write_reg() call to
> match kernel coding style
> 
> Reported by checkpatch.pl

NAK. Use a common sense.

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] staging: fbtft: fb_tinylcd: fix alignment in write_reg call
  2026-04-17 11:20 ` Andy Shevchenko
@ 2026-04-17 11:31   ` Prasaanth Sakthivel
  0 siblings, 0 replies; 3+ messages in thread
From: Prasaanth Sakthivel @ 2026-04-17 11:31 UTC (permalink / raw)
  To: Andy Shevchenko
  Cc: linux-staging, andy, gregkh, dri-devel, linux-fbdev, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 471 bytes --]

Thanks for the feedback, I understand.

I’ll look for more meaningful issues to work on.

On Fri, Apr 17, 2026 at 4:50 PM Andy Shevchenko <andriy.shevchenko@intel.com>
wrote:

> On Fri, Apr 17, 2026 at 03:44:57PM +0530, Prasaanth wrote:
> > Fix alignment of multiline arguments in write_reg() call to
> > match kernel coding style
> >
> > Reported by checkpatch.pl
>
> NAK. Use a common sense.
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
>

[-- Attachment #2: Type: text/html, Size: 888 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-04-17 21:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-17 10:14 [PATCH] staging: fbtft: fb_tinylcd: fix alignment in write_reg call Prasaanth
2026-04-17 11:20 ` Andy Shevchenko
2026-04-17 11:31   ` Prasaanth Sakthivel

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.