All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sanjaikumar V S <sanjaikumarvs@gmail.com>
To: pratyush@kernel.org
Cc: hd@os-cillation.de, linux-kernel@vger.kernel.org,
	linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com,
	mwalle@kernel.org, richard@nod.at, sanjaikumar.vs@dicortech.com,
	sanjaikumarvs@gmail.com, stable@vger.kernel.org,
	tudor.ambarus@linaro.org, vigneshr@ti.com
Subject: Re: [PATCH v5] mtd: spi-nor: Fix SST AAI write mode opcode handling
Date: Mon, 20 Apr 2026 09:02:37 +0000	[thread overview]
Message-ID: <20260420090237.21-1-sanjaikumarvs@gmail.com> (raw)
In-Reply-To: <40364d66-f8a2-4efb-a4d3-70f0aa3137e2@os-cillation.de>

Hi Pratyush,

In v4 you suggested updating dirmap_info with the right opcodes. I went
with a different approach in v5 -- disabling dirmap for SST AAI devices
in sst_nor_late_init() instead. The reasoning is that updating
dirmap_info at runtime is problematic since AAI requires dynamic opcode
and address byte changes per write, and controllers may cache the
template at dirmap_create time.

Hendrik has tested this approach on his SST25VF032B.

Does this approach work for you, or would you prefer a different
direction?

Thanks,
Sanjaikumar

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Sanjaikumar V S <sanjaikumarvs@gmail.com>
To: pratyush@kernel.org
Cc: hd@os-cillation.de, linux-kernel@vger.kernel.org,
	linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com,
	mwalle@kernel.org, richard@nod.at, sanjaikumar.vs@dicortech.com,
	sanjaikumarvs@gmail.com, stable@vger.kernel.org,
	tudor.ambarus@linaro.org, vigneshr@ti.com
Subject: Re: [PATCH v5] mtd: spi-nor: Fix SST AAI write mode opcode handling
Date: Mon, 20 Apr 2026 09:02:37 +0000	[thread overview]
Message-ID: <20260420090237.21-1-sanjaikumarvs@gmail.com> (raw)
In-Reply-To: <40364d66-f8a2-4efb-a4d3-70f0aa3137e2@os-cillation.de>

Hi Pratyush,

In v4 you suggested updating dirmap_info with the right opcodes. I went
with a different approach in v5 -- disabling dirmap for SST AAI devices
in sst_nor_late_init() instead. The reasoning is that updating
dirmap_info at runtime is problematic since AAI requires dynamic opcode
and address byte changes per write, and controllers may cache the
template at dirmap_create time.

Hendrik has tested this approach on his SST25VF032B.

Does this approach work for you, or would you prefer a different
direction?

Thanks,
Sanjaikumar

  reply	other threads:[~2026-04-20  9:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-31  9:50 [PATCH v5] mtd: spi-nor: Fix SST AAI write mode opcode handling Sanjaikumar V S
2026-03-31  9:50 ` Sanjaikumar V S
2026-04-01 15:53 ` Hendrik Donner
2026-04-01 15:53   ` Hendrik Donner
2026-04-20  9:02   ` Sanjaikumar V S [this message]
2026-04-20  9:02     ` Sanjaikumar V S

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260420090237.21-1-sanjaikumarvs@gmail.com \
    --to=sanjaikumarvs@gmail.com \
    --cc=hd@os-cillation.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=mwalle@kernel.org \
    --cc=pratyush@kernel.org \
    --cc=richard@nod.at \
    --cc=sanjaikumar.vs@dicortech.com \
    --cc=stable@vger.kernel.org \
    --cc=tudor.ambarus@linaro.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.